riscv: lib: relax assembly constraints in hweight
PATCH v2 1/1 riscv: lib: relax assembly constraints in hweight
From: Qingfang Deng <[email protected]>
rd and rs don't have to be the same. In some cases where rs needs to be saved for later usage, this will save us some mv instructions.
---
v2: updated title as suggested by Xiao.
arch/riscv/include/asm/arch_hweight.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/riscv/include/asm/arch_hweight.h +4 -4
@@ -26,9 +26,9 @@ static __always_inline unsigned int __arch_hweight32(unsigned int w) asm (".option push\n" ".option arch,+zbb\n" -CPOPW "%0, %0\n" +CPOPW "%0, %1\n" ".option pop\n" - :"+r" (w) : :); + :"=r" (w) :"r" (w) :);return w;
@@ -57,9 +57,9 @@ static __always_inline unsigned long __arch_hweight64(__u64 w) asm (".option push\n" ".option arch,+zbb\n" -"cpop %0, %0\n" +"cpop %0, %1\n" ".option pop\n" - :"+r" (w) : :); + :"=r" (w) :"r" (w) :);return w;
Signature · 1 line
2.34.1
Quoted 56 lines
-----Original Message-----
From: Qingfang Deng <[email protected]>
Sent: Monday, May 27, 2024 5:24 PM
To: Paul Walmsley <[email protected]>; Palmer Dabbelt <[email protected]>; Albert Ou <[email protected]>; linux- [email protected]; [email protected]
Cc: Wang, Xiao W <[email protected]>; Qingfang Deng <[email protected]>
Subject: [PATCH v2] riscv: lib: relax assembly constraints in hweightFrom: Qingfang Deng <[email protected]>
rd and rs don't have to be the same. In some cases where rs needs to be saved for later usage, this will save us some mv instructions.
Signed-off-by Qingfang Deng <[email protected]>---
v2: updated title as suggested by Xiao.arch/riscv/include/asm/arch_hweight.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)arch/riscv/include/asm/arch_hweight.h +4
-5@@ -26,9 +26,9 @@ static __always_inline unsigned int __arch_hweight32(unsigned int w) asm (".option push\n" ".option arch,+zbb\n" - CPOPW "%0, %0\n" + CPOPW "%0, %1\n" ".option pop\n" - : "+r" (w) : :); + : "=r" (w) : "r" (w) :);return w;@@ -57,9 +57,9 @@ static __always_inline unsigned long __arch_hweight64(__u64 w) asm (".option push\n" ".option arch,+zbb\n" - "cpop %0, %0\n" + "cpop %0, %1\n" ".option pop\n" - : "+r" (w) : :); + : "=r" (w) : "r" (w) :);return w; --
Quoted 1 line
2.34.1
This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Hello:
This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Quoted 8 lines · On Mon, 27 May 2024 17:24:04 +0800 you wrote:
From: Qingfang Deng <[email protected]>
rd and rs don't have to be the same. In some cases where rs needs to be saved for later usage, this will save us some mv instructions.
Signed-off-by Qingfang Deng <[email protected]>[...]
Here is the summary with links:
- [v2] riscv: lib: relax assembly constraints in hweight
https://git.kernel.org/riscv/c/93b63f68d00a
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html