tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblank
PATCH 1/1 tests/intel/kms_pm_dc: Add a new test to validate the deep sleep state during extended vblank
Add a new test to validate deep sleep states during extended vblank scenarios, where two frames are committed simultaneously for a given time with reduced refresh rate.
v2: dealy of one frame added to simulate extended vblank.
remove vrr related debug checks.
v3: fix typo and add define. (Suraj)
--- tests/intel/kms_pm_dc.c | 54 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
tests/intel/kms_pm_dc.c +54 -0
@@ -76,6 +76,10 @@* * SUBTEST: dc9-dpms * Description: This test validates display engine entry to DC9 state +* +* SUBTEST: deep-pkgc +* Description: This test validates display engine entry to PKGC10 state for extended vblank +* Functionality: pm_dc */ /* DC State Flags */
@@ -89,6 +93,7 @@#define PACKAGE_CSTATE_PATH "pmc_core/package_cstate_show"#define KMS_POLL_DISABLE 0#define DC9_RESETS_DC_COUNTERS (devid) (!(IS_DG1(devid) || IS_DG2(devid) || AT_LEAST_DISPLAY(devid, 14))) +#define MSECS 1000000IGT_TEST_DESCRIPTION ("Tests to validate display power DC states." );
@@ -584,6 +589,46 @@ static unsigned int read_pkgc_counter(int debugfs_root_fd)return get_dc_counter (str); } +static void test_deep_pkgc_state (data_t *data) +{ +unsigned int pre_val =0 , cur_val =0 ; +time_t start =time (NULL ), duration =2 , delay; +enum pipe pipe; +bool pkgc_flag; +igt_display_t *display = &data->display; +igt_plane_t *primary; +igt_output_t *output; + +for_each_pipe_with_valid_output (display, pipe, output) { +igt_output_set_pipe (output, pipe); + data->output = output; + data->mode =igt_output_get_mode (output); +setup_videoplayback (data); +igt_require (igt_output_has_prop (output,IGT_CONNECTOR_VRR_CAPABLE )); +igt_require (igt_output_get_prop (output,IGT_CONNECTOR_VRR_CAPABLE )); + + primary =igt_output_get_plane_type (data->output, +DRM_PLANE_TYPE_PRIMARY ); + pre_val =read_pkgc_counter (data->debugfs_root_fd); + delay =1 * (MSECS / data->mode->vrefresh); +while (time (NULL ) - start < duration) { +igt_plane_set_fb (primary, &data->fb_rgb); +igt_display_commit (&data->display); +usleep (delay); + +igt_plane_set_fb (primary, &data->fb_rgr); +igt_display_commit (&data->display); + cur_val =read_pkgc_counter (data->debugfs_root_fd); +if (cur_val > pre_val) { + pkgc_flag = true; +continue ; + } + } + } +cleanup_dc3co_fbs (data); +igt_assert_f (pkgc_flag,"PKGC10 is not achieved.\n" ); +} +static void test_pkgc_state_dpms (data_t *data) {unsigned int timeout_sec =6 ;
@@ -687,6 +732,15 @@ igt_maintest_dc_state_psr (&data,CHECK_DC6 ); } +igt_describe ("This test validates display engine entry to PKGC10 state " +"during extended vblank" ); + igt_subtest("deep-pkgc") { +igt_require_f (igt_pm_pc8_plus_residencies_enabled (data.msr_fd), +"PC8+ residencies not supported\n" ); +igt_require (intel_display_ver (data.devid) >=20 ); +test_deep_pkgc_state (&data); + } +igt_describe ("This test validates display engine entry to DC5 state " "while all connectors's DPMS property set to OFF" ); igt_subtest("dc5-dpms") {
Signature · 1 line
2.25.1
Hi Jeevan,
Quoted 36 lines · Jeevan B
Add a new test to validate deep sleep states during extended vblank scenarios, where two frames are committed simultaneously for a given time with reduced refresh rate.
v2: dealy of one frame added to simulate extended vblank.
remove vrr related debug checks.
v3: fix typo and add define. (Suraj)Signed-off-by Jeevan B <[email protected]>--- tests/intel/kms_pm_dc.c | 54 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)tests/intel/kms_pm_dc.c +5
-0@@ -76,6 +76,10 @@* * SUBTEST: dc9-dpms * Description: This test validates display engine entry to DC9 state +* +* SUBTEST: deep-pkgc +* Description: This test validates display engine entry to PKGC10 state for extended vblank +* Functionality: pm_dc */ /* DC State Flags */ @@ -89,6 +93,7 @@#define PACKAGE_CSTATE_PATH "pmc_core/package_cstate_show"#define KMS_POLL_DISABLE 0#define DC9_RESETS_DC_COUNTERS (devid) (!(IS_DG1(devid) || IS_DG2(devid) || AT_LEAST_DISPLAY(devid, 14))) +#define MSECS 1000000IGT_TEST_DESCRIPTION ("Tests to validate display power DC states." );
tests/intel/kms_pm_dc.c static unsigned int read_pkgc_counter(int debugfs_root_fd) · line 597
Quoted 9 lines
tests/intel/kms_pm_dc.c +6
-0@@ -584,6 +589,46 @@ static unsigned int read_pkgc_counter(int debugfs_root_fd)return get_dc_counter (str); } +static void test_deep_pkgc_state (data_t *data) +{ +unsigned int pre_val =0 , cur_val =0 ; +time_t start =time (NULL ), duration =2 , delay; +enum pipe pipe; +bool pkgc_flag;
Please initialize this flag with "false".
tests/intel/kms_pm_dc.c static unsigned int read_pkgc_counter(int debugfs_root_fd) · line 603
Quoted 6 lines
tests/intel/kms_pm_dc.c +6
-0+igt_display_t *display = &data->display; +igt_plane_t *primary; +igt_output_t *output; + +for_each_pipe_with_valid_output (display, pipe, output) { +igt_output_set_pipe (output, pipe);
Please do igt_display_reset()/igt_output_set_pipe(NULL) before setting the output to pipe.
tests/intel/kms_pm_dc.c static unsigned int read_pkgc_counter(int debugfs_root_fd) · line 608
Quoted 5 lines
tests/intel/kms_pm_dc.c +5
-0+ data->output = output; + data->mode =igt_output_get_mode (output); +setup_videoplayback (data); +igt_require (igt_output_has_prop (output,IGT_CONNECTOR_VRR_CAPABLE )); +igt_require (igt_output_get_prop (output,IGT_CONNECTOR_VRR_CAPABLE ));
Check for the config capabilities before setting up anything. (Move these checks to just after initializing the loops)
if (!has_vrr_capable || !get_vrr_capable)
continue;
tests/intel/kms_pm_dc.c static unsigned int read_pkgc_counter(int debugfs_root_fd) · line 620
Quoted 12 lines
tests/intel/kms_pm_dc.c +12
-0+ + primary =igt_output_get_plane_type (data->output, +DRM_PLANE_TYPE_PRIMARY ); + pre_val =read_pkgc_counter (data->debugfs_root_fd); + delay =1 * (MSECS / data->mode->vrefresh); +while (time (NULL ) - start < duration) { +igt_plane_set_fb (primary, &data->fb_rgb); +igt_display_commit (&data->display); +usleep (delay); + +igt_plane_set_fb (primary, &data->fb_rgr); +igt_display_commit (&data->display);
Why do we need 2 commits, lets simplify this as below:
pre_val = read_pkgc_counter(data->debugfs_root_fd);
delay = 1 * (MSECS / data->mode->vrefresh);+
+ igt_plane_set_fb(primary, &data->fb_rgb);
+ igt_display_commit(&data->display);
+
+ flip = true;
+
while (time(NULL) - start < duration) {
- igt_plane_set_fb(primary, &data->fb_rgb);
+ flip = !flip;
+ igt_plane_set_fb(primary, flip ? &data->fb_rgb : &data->fb_rgr);
igt_display_commit(&data->display);- usleep(delay);
- igt_plane_set_fb(primary, &data->fb_rgr);
- igt_display_commit(&data->display);
cur_val = read_pkgc_counter(data->debugfs_root_fd);
if (cur_val > pre_val) {
pkgc_flag = true;
- continue;
+ break;
}
+ usleep(delay);
}
}tests/intel/kms_pm_dc.c static unsigned int read_pkgc_counter(int debugfs_root_fd) · line 624
Quoted 4 lines
tests/intel/kms_pm_dc.c +4
-0+ cur_val =read_pkgc_counter (data->debugfs_root_fd); +if (cur_val > pre_val) { + pkgc_flag = true; +continue ;
If PKGC states achieved, we must do the "break" instead of "continue". Right?
tests/intel/kms_pm_dc.c static unsigned int read_pkgc_counter(int debugfs_root_fd) · line 629
Quoted 5 lines
tests/intel/kms_pm_dc.c +5
-0+ } + } + } +cleanup_dc3co_fbs (data); +igt_assert_f (pkgc_flag,"PKGC10 is not achieved.\n" );
It'll throw an error if there is no valid output found, instead we must skip.
- Bhanu
Quoted 21 lines
tests/intel/kms_pm_dc.c +11
-0+} +static void test_pkgc_state_dpms (data_t *data) {unsigned int timeout_sec =6 ;@@ -687,6 +732,15 @@ igt_maintest_dc_state_psr (&data,CHECK_DC6 ); } +igt_describe ("This test validates display engine entry to PKGC10 state " +"during extended vblank" ); + igt_subtest("deep-pkgc") { +igt_require_f (igt_pm_pc8_plus_residencies_enabled (data.msr_fd), +"PC8+ residencies not supported\n" ); +igt_require (intel_display_ver (data.devid) >=20 ); +test_deep_pkgc_state (&data); + } +igt_describe ("This test validates display engine entry to DC5 state " "while all connectors's DPMS property set to OFF" ); igt_subtest("dc5-dpms") {