Skip to contentSkip to conversation

iio: imu: inv_icm42600: delete unneeded update watermark call

PATCH New [email protected] 1 participant 1 message May 27, 2024

Subsystems (3)
Stable branch IIO Invensense ICM-426xx IMU driver
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 iio: imu: inv_icm42600: delete unneeded update watermark call

From: Jean-Baptiste Maneyrol <[email protected]>

Update watermark will be done inside the hwfifo_set_watermark callback just after the update_scan_mode. It is useless to do it here.

Fixes 7f85e42a6c54 ("iio: imu: inv_icm42600: add buffer support in iio devices")
Cc [email protected]
Signed-off-by Jean-Baptiste Maneyrol <[email protected]>
---
 drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c | 4 ----
 drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c  | 4 ----
 2 files changed, 8 deletions(-)
drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c +0 -4
index 83d8504ebfff..4b2566693614 100644
@@ -130,10 +130,6 @@ static int inv_icm42600_accel_update_scan_mode(struct iio_dev *indio_dev,
 	/* update data FIFO write */
 	inv_sensors_timestamp_apply_odr(ts, 0, 0, 0);
 	ret = inv_icm42600_buffer_set_fifo_en(st, fifo_en | st->fifo.en);
-	if (ret)
-		goto out_unlock;
-
-	ret = inv_icm42600_buffer_update_watermark(st);
 
 out_unlock:
 	mutex_unlock(&st->lock);
drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c +0 -4
index e6f8de80128c..938af5b640b0 100644
@@ -130,10 +130,6 @@ static int inv_icm42600_gyro_update_scan_mode(struct iio_dev *indio_dev,
 	/* update data FIFO write */
 	inv_sensors_timestamp_apply_odr(ts, 0, 0, 0);
 	ret = inv_icm42600_buffer_set_fifo_en(st, fifo_en | st->fifo.en);
-	if (ret)
-		goto out_unlock;
-
-	ret = inv_icm42600_buffer_update_watermark(st);
 
 out_unlock:
 	mutex_unlock(&st->lock);
Signature · 1 line
2.34.1