iio: dac: ad9739a: drop COMPILE_TEST option
PATCH 1/1 iio: dac: ad9739a: drop COMPILE_TEST option
From: Arnd Bergmann <[email protected]>
Build testing without SPI results in a warning:
WARNING: unmet direct dependencies detected for REGMAP_SPI
Depends on [n]: SPI [=n]
Selected by [m]:
- AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
There is no need for this particular COMPILE_TEST option, as allmodconfig and randconfig testing can just assume that SPI is enabled separately.
Drop it to avoid the warning.
--- drivers/iio/dac/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/dac/Kconfig +1 -1
@@ -133,7 +133,7 @@ config AD5624R_SPI config AD9739A tristate "Analog Devices AD9739A RF DAC spi driver" - depends on SPI || COMPILE_TEST + depends on SPI select REGMAP_SPI select IIO_BACKEND help
Signature · 1 line
2.39.2
Quoted 9 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Build testing without SPI results in a warning:
WARNING: unmet direct dependencies detected for
REGMAP_SPIDepends on [n]: SPI [=n]
Selected by [m]:
- AD9739A [=m] && IIO [=m] && (SPI [=n] ||COMPILE_TEST[=y])
Quoted 7 lines
There is no need for this particular
COMPILE_TESToption, as allmodconfig and randconfig testing can just assume that SPI is enabled separately.Drop it to avoid the warning.
Signed-off-by Arnd Bergmann <[email protected]>---
Only for my understanding. When does COMPILE_TEST makes sense to add?
- Nuno Sá
Quoted 13 lines · Nuno Sá
Quoted 12 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Build testing without SPI results in a warning:
WARNING: unmet direct dependencies detected for
REGMAP_SPIDepends on [n]: SPI [=n]
Selected by [m]:
- AD9739A [=m] && IIO [=m] && (SPI [=n] ||COMPILE_TEST[=y])There is no need for this particular
COMPILE_TESToption, as allmodconfig and randconfig testing can just assume that SPI is enabled separately.
Quoted 8 lines
Quoted 4 lines
Drop it to avoid the warning.
Signed-off-by Arnd Bergmann <[email protected]>---
Reviewed-by Nuno Sa <[email protected]>Only for my understanding. When does
COMPILE_TESTmakes sense to add?
The most common use is to enable building a driver that is platform specific on x86 allmodconfig or on randconfig, e.g.
config LPC18XX_DAC
tristate "NXP LPC18xx DAC driver" depends on ARCH_LPC18XX || COMPILE_TEST depends on HAS_IOMEM
Since ARCH_LPC18XX is only visible on arch/arm, the driver would never be build tested on anything else without the ||COMPILE_TEST.
Arnd
Quoted 27 lines · Arnd Bergmann
Quoted 13 lines · Nuno Sá
Quoted 12 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Build testing without SPI results in a warning:
WARNING: unmet direct dependencies detected for
REGMAP_SPIDepends on [n]: SPI [=n]
Selected by [m]:
- AD9739A [=m] && IIO [=m] && (SPI [=n] ||COMPILE_TEST[=y])There is no need for this particular
COMPILE_TESToption, as allmodconfig and randconfig testing can just assume that SPI is enabled separately.Quoted 8 lines
Quoted 4 lines
Drop it to avoid the warning.
Signed-off-by Arnd Bergmann <[email protected]>---
Reviewed-by Nuno Sa <[email protected]>Only for my understanding. When does
COMPILE_TESTmakes sense to add?The most common use is to enable building a driver that is platform specific on x86 allmodconfig or on randconfig, e.g.
Quoted 8 lines
config
LPC18XX_DAC
tristate "NXP LPC18xx DAC driver" depends onARCH_LPC18XX||COMPILE_TESTdepends onHAS_IOMEMSince
ARCH_LPC18XXis only visible onarch/arm, the driver would never be build tested on anything else without the ||COMPILE_TEST.
Makes sense... Thanks!
- Nuno Sá
Quoted 33 lines · On Wed, 29 May 2024 10:09:28 +0200 Nuno Sá <[email protected]> wrote:
Quoted 32 lines · Arnd Bergmann
Quoted 13 lines · Nuno Sá
Quoted 12 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Build testing without SPI results in a warning:
WARNING: unmet direct dependencies detected for
REGMAP_SPIDepends on [n]: SPI [=n]
Selected by [m]:
- AD9739A [=m] && IIO [=m] && (SPI [=n] ||COMPILE_TEST[=y])There is no need for this particular
COMPILE_TESToption, as allmodconfig and randconfig testing can just assume that SPI is enabled separately.Quoted 8 lines
Quoted 4 lines
Drop it to avoid the warning.
Signed-off-by Arnd Bergmann <[email protected]>---
Reviewed-by Nuno Sa <[email protected]>Only for my understanding. When does
COMPILE_TESTmakes sense to add?The most common use is to enable building a driver that is platform specific on x86 allmodconfig or on randconfig, e.g.
config
LPC18XX_DAC
tristate "NXP LPC18xx DAC driver" depends onARCH_LPC18XX||COMPILE_TESTdepends onHAS_IOMEM
Quoted 8 lines
Quoted 3 lines
Since
ARCH_LPC18XXis only visible onarch/arm, the driver would never be build tested on anything else without the ||COMPILE_TEST.Makes sense... Thanks!
- Nuno Sá
Applied. Thanks