Skip to contentSkip to conversation

nfs02: Add subtest for O_DIRECT

PATCH In review Martin Doucha 2 participants 4 messages May 28, 2024 – Jun 5, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfs02: Add subtest for O_DIRECT

---
 testcases/network/nfs/nfs_stress/nfs02.sh | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)
testcases/network/nfs/nfs_stress/nfs02.sh +14 -1
index b7fbbce9c..100909790 100755
@@ -8,7 +8,7 @@
 #
 # Ported by: Robbie Williamson ([email protected])
 
-TST_CNT=3
+TST_CNT=4
 TST_TESTFUNC="do_test"
 LTP_DATAFILES="$LTPROOT/testcases/bin/datafiles"
 
@@ -46,5 +46,18 @@ do_test3()
 	tst_res TPASS "test3 passed"
 }
 
+do_test4()
+{
+	tst_res TINFO "do_test4, copy data in direct mode"
+	ROD dd oflag=direct if="$LTP_DATAFILES/ascii.jmb" of=ascii2.jmb
+	echo 3 >/proc/sys/vm/drop_caches
+	ROD dd iflag=direct if=ascii2.jmb of="$TST_TMPDIR/ascii2.jmb"
+	echo 3 >/proc/sys/vm/drop_caches
+	tst_res TINFO "compare both ascii.jmbs"
+	ROD diff "$LTP_DATAFILES/ascii.jmb" ascii2.jmb
+	ROD diff "$LTP_DATAFILES/ascii.jmb" "$TST_TMPDIR/ascii2.jmb"
+	tst_res TPASS "test4 passed"
+}
+
 . nfs_lib.sh
 tst_run
Signature · 5 lines
2.44.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v1 1/1
#1 lore raw

Hi Martin,

Quoted 19 lines
---
 testcases/network/nfs/nfs_stress/nfs02.sh | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)
testcases/network/nfs/nfs_stress/nfs02.sh +1 -1
index b7fbbce9c..100909790 100755
@@ -8,7 +8,7 @@
 
 # Ported by: Robbie Williamson ([email protected])
 
-TST_CNT=3
+TST_CNT=4
 TST_TESTFUNC="do_test"
 LTP_DATAFILES="$LTPROOT/testcases/bin/datafiles"
 

testcases/network/nfs/nfs_stress/nfs02.sh do_test3() · line 50

Quoted 5 lines
testcases/network/nfs/nfs_stress/nfs02.sh +2 -0
@@ -46,5 +46,18 @@ do_test3()
 	tst_res TPASS "test3 passed"
 }
 
+do_test4()
+{

I suggest to add here before merge:

tst_require_cmds dd diff

Thank you for this test!

Kind regards,
Petr

Quoted 13 lines
testcases/network/nfs/nfs_stress/nfs02.sh +11 -0
+	tst_res TINFO "do_test4, copy data in direct mode"
+	ROD dd oflag=direct if="$LTP_DATAFILES/ascii.jmb" of=ascii2.jmb
+	echo 3 >/proc/sys/vm/drop_caches
+	ROD dd iflag=direct if=ascii2.jmb of="$TST_TMPDIR/ascii2.jmb"
+	echo 3 >/proc/sys/vm/drop_caches
+	tst_res TINFO "compare both ascii.jmbs"
+	ROD diff "$LTP_DATAFILES/ascii.jmb" ascii2.jmb
+	ROD diff "$LTP_DATAFILES/ascii.jmb" "$TST_TMPDIR/ascii2.jmb"
+	tst_res TPASS "test4 passed"
+}
+
 . nfs_lib.sh
 tst_run
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
Quoted 6 lines · Petr Vorel

Hi Martin,

Quoted 3 lines
testcases/network/nfs/nfs_stress/nfs02.sh +0 -0
@@ -46,5 +46,18 @@ do_test3()
  	tst_res TPASS "test3 passed"
  }
Quoted 6 lines

testcases/network/nfs/nfs_stress/nfs02.sh do_test3() · line 50

Quoted 2 lines
testcases/network/nfs/nfs_stress/nfs02.sh +2 -0
+do_test4()
+{

I suggest to add here before merge:

tst_require_cmds dd diff

Please do. Thanks.

Signature · 11 lines
Martin Doucha   [email protected]
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Hi Martin,

Quoted 5 lines
Quoted 3 lines

I suggest to add here before merge:

tst_require_cmds dd diff

Please do. Thanks.

Merged with this change.
Thanks a lot for this test!

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp