Skip to contentSkip to conversation

scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'

PATCH Applied [email protected] 3 participants 4 messages May 28, 2024 – Jun 5, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'

From: "Dr. David Alan Gilbert" <[email protected]>

'scsi_dif_tuple' is unused since
commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized sectors.").

Remove it.

---
 drivers/scsi/qla2xxx/qla_isr.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/scsi/qla2xxx/qla_isr.c +0 -6
index d48007e18288..fe98c76e9be3 100644
@@ -3014,12 +3014,6 @@ qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len,
 	}
 }
 
-struct scsi_dif_tuple {
-	__be16 guard;       /* Checksum */
-	__be16 app_tag;         /* APPL identifier */
-	__be32 ref_tag;         /* Target LBA or indirect LBA */
-};
-
 /*
  * Checks the guard or meta-data for the type of error
  * detected by the HBA. In case of errors, we set the
Signature · 1 line
2.45.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · On 5/28/24 14:56, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

'scsi_dif_tuple' is unused since
commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized sectors.").

Remove it.

---
  drivers/scsi/qla2xxx/qla_isr.c | 6 ------
  1 file changed, 6 deletions(-)
drivers/scsi/qla2xxx/qla_isr.c +0 -0
index d48007e18288..fe98c76e9be3 100644
@@ -3014,12 +3014,6 @@ qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len,
  	}
  }

drivers/scsi/qla2xxx/qla_isr.c qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len, · line 3019

Quoted 10 lines
drivers/scsi/qla2xxx/qla_isr.c +0 -6
 
-struct scsi_dif_tuple {
-	__be16 guard;       /* Checksum */
-	__be16 app_tag;         /* APPL identifier */
-	__be32 ref_tag;         /* Target LBA or indirect LBA */
-};
-
  /*
   * Checks the guard or meta-data for the type of error
   * detected by the HBA. In case of errors, we set the

Looks Good.

Signature · 1 line
Himanshu Madhani                                Oracle Linux Engineering
#2 lore raw
In reply to [email protected]
Quoted 5 lines

'scsi_dif_tuple' is unused since commit 8cb2049c7448 ("[SCSI] qla2xxx:
T10 DIF - Handle uninitalized sectors.").

Remove it.

Applied to 6.11/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#3 lore raw
In reply to [email protected]
Quoted 8 lines · On Tue, 28 May 2024 22:56:40 +0100, [email protected] wrote:

'scsi_dif_tuple' is unused since
commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized sectors.").

Remove it.

[...]

Applied to 6.11/scsi-queue, thanks!

[1/1] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'

      https://git.kernel.org/mkp/scsi/c/96281dfa266d
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering