Skip to contentSkip to conversation

"Reset registers to enhance robustness."

PATCH New Pope B.Lei 3 participants 5 messages May 29, 2024 – May 30, 2024

lore
Share & tools
lore

Pope B.Lei

author
#0 lore raw

PATCH 1/1 "Reset registers to enhance robustness."

---
V1: If the registers are not initialized, they may remain in an x-state in certain DV verification environments due to the lack of written values, causing the x-state to propagate during the boot process. Adding register initialization enhances robustness.

 firmware/fw_base.S | 2 ++
 1 file changed, 2 insertions(+)
firmware/fw_base.S +2 -0
index b950c0b..10889a9 100644
@@ -36,6 +36,8 @@
 	.globl _start
 	.globl _start_warm
 _start:
+	/* Reset registers to enhance robustness. */
+	call	_reset_regs
 	/* Find preferred boot HART id */
 	MOV_3R	s0, a0, s1, a1, s2, a2
 	call	fw_boot_hart
Signature · 1 line
2.35.2.windows.1
#1 lore raw

PATCH 1/1 "Reset registers to enhance robustness."

Quoted 4 lines · Pope B.Lei

---
V1: If the registers are not initialized, they may remain in an x-state in certain DV verification environments

Don?t do that then? If you want equal traces, use a well-defined start or use smarter trace equivalence checking. The code being added serves zero practical purpose in a real system.

Jess

Quoted 25 lines

due to the lack of written values, causing the x-state to propagate during the boot process. Adding register initialization enhances robustness. firmware/fw_base.S | 2 ++

1 file changed, 2 insertions(+)
firmware/fw_base.S +0 -0
index b950c0b..10889a9 100644
@@ -36,6 +36,8 @@

.globl _start
.globl _start_warm
_start:
+ /* Reset registers to enhance robustness. */
+ call _reset_regs
/* Find preferred boot HART id */
MOV_3R s0, a0, s1, a1, s2, a2
call fw_boot_hart

Signature · 7 lines
2.35.2.windows.1


-- 
opensbi mailing list
opensbi at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi
author
#2 lore raw

PATCH 1/1 "Reset registers to enhance robustness."

Due to the completeness of Opensbi's functionality and its excellent, stable code, I use Opensbi to boot multiple cores for testing in the DV system tests of multi-core RISCV SOCs. The DV verification system is also a real system, and in a certain sense, using Opensbi during the DV verification phase is even more valuable.

Quoted 39 lines · On Wed, May 29, 2024 at 3:40?PM Jessica Clarke <[email protected]> wrote:
Quoted 4 lines · Pope B.Lei

---
V1: If the registers are not initialized, they may remain in an x-state in certain DV verification environments

Don?t do that then? If you want equal traces, use a well-defined start or use smarter trace equivalence checking. The code being added serves zero practical purpose in a real system.

Jess

Quoted 25 lines

due to the lack of written values, causing the x-state to propagate during the boot process. Adding register initialization enhances robustness. firmware/fw_base.S | 2 ++

1 file changed, 2 insertions(+)
firmware/fw_base.S +0 -0
index b950c0b..10889a9 100644
@@ -36,6 +36,8 @@

.globl _start
.globl _start_warm
_start:
+ /* Reset registers to enhance robustness. */
+ call _reset_regs
/* Find preferred boot HART id */
MOV_3R s0, a0, s1, a1, s2, a2
call fw_boot_hart
--
2.35.2.windows.1

--
opensbi mailing list
opensbi at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi

#3 lore raw

PATCH 1/1 "Reset registers to enhance robustness."

In reply to Pope B.Lei

? 2024-05-29???? 15:37 +0800?Pope B.Lei???

Quoted 4 lines

---
V1: If the registers are not initialized, they may remain in an x-state in certain DV verification environments due to the lack of written values, causing the x-state to propagate during the boot process. Adding register initialization enhances robustness.

In DV system, all registers should be written to prevent the existence of registers in x-state state. _reset_regs cannot write all registers for parameter passing. If all registers are written, it will affect the function of opensbi.

So I don't think it's a good way to stop a register from having x-state state.

Regards,
Xiang W

Quoted 20 lines

?firmware/fw_base.S | 2 ++
?1 file changed, 2 insertions(+)

firmware/fw_base.S +0 -0
index b950c0b..10889a9 100644
@@ -36,6 +36,8 @@

? .globl _start
? .globl _start_warm
?_start:

firmware/fw_base.S +2 -0
+	/* Reset registers to enhance robustness. */
+	call	_reset_regs

? /* Find preferred boot HART id */
? MOV_3R s0, a0, s1, a1, s2, a2
? call fw_boot_hart

Signature · 1 line
2.35.2.windows.1
author
#4 lore raw

PATCH 1/1 "Reset registers to enhance robustness."

Dear Xiang:
You are right. In actual use, I will add an operation to set the
parameter to a fixed value. However, since this is just an operation in the DV environment, I didn't push it.

Referring to the approach of the kernel, my understanding is that
it is worthwhile to clean up irrelevant content in the context during a switch.

    https://patchwork.kernel.org/project/linux-mm/patch/20190624054311.30256-17-hch at lst.de/

Regards,
B.Lei

Quoted 37 lines · On Thu, May 30, 2024 at 9:08?AM Xiang W <[email protected]> wrote:

? 2024-05-29???? 15:37 +0800?Pope B.Lei???

Quoted 4 lines

---
V1: If the registers are not initialized, they may remain in an x-state in certain DV verification environments due to the lack of written values, causing the x-state to propagate during the boot process. Adding register initialization enhances robustness.

In DV system, all registers should be written to prevent the existence of registers in x-state state. _reset_regs cannot write all registers for parameter passing. If all registers are written, it will affect the function of opensbi.

So I don't think it's a good way to stop a register from having x-state state.

Regards,
Xiang W

Quoted 20 lines
 firmware/fw_base.S | 2 ++
 1 file changed, 2 insertions(+)
firmware/fw_base.S +2 -1
index b950c0b..10889a9 100644
@@ -36,6 +36,8 @@
      .globl _start
      .globl _start_warm
 _start:
+     /* Reset registers to enhance robustness. */
+     call    _reset_regs
      /* Find preferred boot HART id */
      MOV_3R  s0, a0, s1, a1, s2, a2
      call    fw_boot_hart
--

2.35.2.windows.1