ALSA: ump: Don't clear bank selection after sending a program change
PATCH 1/1 ALSA: ump: Don't clear bank selection after sending a program change
The current code clears the bank selection MSB/LSB after sending a program change, but this can be wrong, as many apps may not send the full bank selection with both MSB and LSB but sending only one. Better to keep the previous bank set.
Fixes 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support")
Cc <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
--- sound/core/ump_convert.c | 1 - 1 file changed, 1 deletion(-)
sound/core/ump_convert.c +0 -1
@@ -404,7 +404,6 @@ static int cvt_legacy_cmd_to_ump(struct ump_cvt_to_ump *cvt, midi2->pg.bank_msb = cc->cc_bank_msb; midi2->pg.bank_lsb = cc->cc_bank_lsb; cc->bank_set =0 ; - cc->cc_bank_msb = cc->cc_bank_lsb =0 ; }break ;case UMP_MSG_STATUS_CHANNEL_PRESSURE :
Signature · 1 line
2.43.0