Skip to contentSkip to conversation

fuse2fs: explicitly set _FILE_OFFSET_BITS again

PATCH Applied Darrick J. Wong 2 participants 2 messages May 29, 2024 – Oct 25, 2024

lore
Share & tools
lore

Darrick J. Wong

author
#0 lore raw

PATCH 1/1 fuse2fs: explicitly set _FILE_OFFSET_BITS again

From: Darrick J. Wong <[email protected]>

In commit 3ab99d9b602, the build system was changed not to set _FILE_OFFSET_BITS explicitly due to some weird error on mips64el. Unfortunately, this breaks the aarch64 Debian build because libfuse 2.9.9 requires this value to be set explicitly. Restore this dumb preprocessor symbol dependency with even more hackery as documented in the commit.

Fixes 3ab99d9b602 ("Remove explicit #define of _FILE_OFFSET_BITS")
Signed-off-by Darrick J. Wong <[email protected]>
---
 misc/fuse2fs.c |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)
misc/fuse2fs.c +16 -0
index 56a0d545..01293868 100644
@@ -26,7 +26,23 @@
 #endif
 #include <sys/ioctl.h>
 #include <unistd.h>
+#ifdef __SET_FOB_FOR_FUSE
+# error Do not set magic value __SET_FOB_FOR_FUSE!!!!
+#endif
+#ifndef _FILE_OFFSET_BITS
+/*
+ * Old versions of libfuse (e.g. Debian 2.9.9 package) required that the build
+ * system set _FILE_OFFSET_BITS explicitly, even if doing so isn't required to
+ * get a 64-bit off_t.  AC_SYS_LARGEFILE doesn't set any _FILE_OFFSET_BITS if
+ * it's not required (such as on aarch64), so we must inject it here.
+ */
+# define __SET_FOB_FOR_FUSE
+# define _FILE_OFFSET_BITS 64
+#endif /* _FILE_OFFSET_BITS */
 #include <fuse.h>
+#ifdef __SET_FOB_FOR_FUSE
+# undef _FILE_OFFSET_BITS
+#endif /* __SET_FOB_FOR_FUSE */
 #include <inttypes.h>
 #include "ext2fs/ext2fs.h"
 #include "ext2fs/ext2_fs.h"
Applied
#1 lore raw
Quoted 8 lines · Darrick J. Wong

In commit 3ab99d9b602, the build system was changed not to set _FILE_OFFSET_BITS explicitly due to some weird error on mips64el. Unfortunately, this breaks the aarch64 Debian build because libfuse 2.9.9 requires this value to be set explicitly. Restore this dumb preprocessor symbol dependency with even more hackery as documented in the commit.

[...]

Applied, thanks!

[1/1] fuse2fs: explicitly set _FILE_OFFSET_BITS again

      commit: fb702218ab47b045cbbaf3268984fbdc5f75632e

Best regards,

Signature · 1 line
Theodore Ts'o <[email protected]>