Skip to contentSkip to conversation

USB: serial: spcp8x5: remove unused struct 'spcp8x5_usb_ctrl_arg'

PATCH In review [email protected] 3 participants 6 messages May 29, 2024 – Jul 5, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: serial: spcp8x5: remove unused struct 'spcp8x5_usb_ctrl_arg'

From: "Dr. David Alan Gilbert" <[email protected]>

'spcp8x5_usb_ctrl_arg' has been unused since the original commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").

Remove it.

---
 drivers/usb/serial/spcp8x5.c | 10 ----------
 1 file changed, 10 deletions(-)
drivers/usb/serial/spcp8x5.c +0 -10
index 09a972a838ee..6b294bf8bc43 100644
@@ -49,16 +49,6 @@ static const struct usb_device_id id_table[] = {
 };
 MODULE_DEVICE_TABLE(usb, id_table);
 
-struct spcp8x5_usb_ctrl_arg {
-	u8	type;
-	u8	cmd;
-	u8	cmd_type;
-	u16	value;
-	u16	index;
-	u16	length;
-};
-
-
 /* spcp8x5 spec register define */
 #define MCR_CONTROL_LINE_RTS		0x02
 #define MCR_CONTROL_LINE_DTR		0x01
Signature · 1 line
2.45.1
#1 lore raw
Quoted 8 lines · * [email protected] ([email protected]) wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

'spcp8x5_usb_ctrl_arg' has been unused since the original commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").

Remove it.

Ping?

Dave

Quoted 28 lines
---
 drivers/usb/serial/spcp8x5.c | 10 ----------
 1 file changed, 10 deletions(-)
drivers/usb/serial/spcp8x5.c +0 -10
index 09a972a838ee..6b294bf8bc43 100644
@@ -49,16 +49,6 @@ static const struct usb_device_id id_table[] = {
 };
 MODULE_DEVICE_TABLE(usb, id_table);
 
-struct spcp8x5_usb_ctrl_arg {
-	u8	type;
-	u8	cmd;
-	u8	cmd_type;
-	u16	value;
-	u16	index;
-	u16	length;
-};
-
-
 /* spcp8x5 spec register define */
 #define MCR_CONTROL_LINE_RTS		0x02
 #define MCR_CONTROL_LINE_DTR		0x01
Signature · 1 line
2.45.1
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
maintainer
#2 lore raw
Quoted 11 lines · Dr. David Alan Gilbert
Quoted 8 lines · * [email protected] ([email protected]) wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

'spcp8x5_usb_ctrl_arg' has been unused since the original commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").

Remove it.

Ping?

It's only been 2 weeks for a "remove some unused code" type of patch, which will be gotten to, but realize that people are traveling and the like... Give it some time.

In the meantime, why not help review other patches on the list?

thanks,

greg k-h

#3 lore raw
Quoted 9 lines · * Greg KH ([email protected]) wrote:
Quoted 8 lines · Dr. David Alan Gilbert
Quoted 7 lines · * [email protected] ([email protected]) wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

'spcp8x5_usb_ctrl_arg' has been unused since the original commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").

Remove it.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Ping?

It's only been 2 weeks for a "remove some unused code" type of patch, which will be gotten to, but realize that people are traveling and the like... Give it some time.

OK, it was only a gentle ping, not a moan; and that seems to have unstuck a few others in the large set this is part of.

Quoted 1 line

In the meantime, why not help review other patches on the list?

Sure, I'll keep an eye out for stuff that doesn't require too much detailed knowledge of any particular subsystem.

Dave

Quoted 3 lines

thanks,

greg k-h

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#5 lore raw
Quoted 11 lines · * Johan Hovold ([email protected]) wrote:
Quoted 8 lines · On Thu, May 30, 2024 at 12:47:22AM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

'spcp8x5_usb_ctrl_arg' has been unused since the original commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").

Remove it.

Now applied, thanks.

Thanks!

Dave

Quoted 2 lines

Johan

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/