Skip to contentSkip to conversation

fpga: altera-fpga2sdram: remove unused struct 'prop_map'

PATCH Applied [email protected] 3 participants 5 messages May 30, 2024 – Jun 14, 2024 FPGA manager framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fpga: altera-fpga2sdram: remove unused struct 'prop_map'

From: "Dr. David Alan Gilbert" <[email protected]>

'prop_map' has been unused since the original
commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").

Remove it.

---
 drivers/fpga/altera-fpga2sdram.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/fpga/altera-fpga2sdram.c +0 -6
index 6b60ca004345..f4de3fea0b2d 100644
@@ -75,12 +75,6 @@ static int alt_fpga2sdram_enable_set(struct fpga_bridge *bridge, bool enable)
 	return _alt_fpga2sdram_enable_set(bridge->priv, enable);
 }
 
-struct prop_map {
-	char *prop_name;
-	u32 *prop_value;
-	u32 prop_max;
-};
-
 static const struct fpga_bridge_ops altera_fpga2sdram_br_ops = {
 	.enable_set = alt_fpga2sdram_enable_set,
 	.enable_show = alt_fpga2sdram_enable_show,
Signature · 1 line
2.45.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Thu, May 30, 2024 at 09:52:45PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

'prop_map' has been unused since the original
commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").

Remove it.

Quoted 24 lines
---
 drivers/fpga/altera-fpga2sdram.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/fpga/altera-fpga2sdram.c +0 -6
index 6b60ca004345..f4de3fea0b2d 100644
@@ -75,12 +75,6 @@ static int alt_fpga2sdram_enable_set(struct fpga_bridge *bridge, bool enable)
 	return _alt_fpga2sdram_enable_set(bridge->priv, enable);
 }
 
-struct prop_map {
-	char *prop_name;
-	u32 *prop_value;
-	u32 prop_max;
-};
-
 static const struct fpga_bridge_ops altera_fpga2sdram_br_ops = {
 	.enable_set = alt_fpga2sdram_enable_set,
 	.enable_show = alt_fpga2sdram_enable_show,
Signature · 1 line
2.45.1
#2 lore raw
In reply to [email protected]
Quoted 1 line · On Thu, May 30, 2024 at 09:52:45PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

This is only needed if the person sending the patch is not the author.

Quoted 3 lines

'prop_map' has been unused since the original
commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").

Please use 'fixes:' tag.

Thanks,
Yilun

Quoted 29 lines

Remove it.

---
 drivers/fpga/altera-fpga2sdram.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/fpga/altera-fpga2sdram.c +0 -6
index 6b60ca004345..f4de3fea0b2d 100644
@@ -75,12 +75,6 @@ static int alt_fpga2sdram_enable_set(struct fpga_bridge *bridge, bool enable)
 	return _alt_fpga2sdram_enable_set(bridge->priv, enable);
 }
 
-struct prop_map {
-	char *prop_name;
-	u32 *prop_value;
-	u32 prop_max;
-};
-
 static const struct fpga_bridge_ops altera_fpga2sdram_br_ops = {
 	.enable_set = alt_fpga2sdram_enable_set,
 	.enable_show = alt_fpga2sdram_enable_show,
Signature · 1 line
2.45.1
#3 lore raw
Quoted 10 lines · * Xu Yilun ([email protected]) wrote:
Quoted 1 line · On Thu, May 30, 2024 at 09:52:45PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

This is only needed if the person sending the patch is not the author.

Quoted 3 lines

'prop_map' has been unused since the original
commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").

Please use 'fixes:' tag.

I've avoided using fixes: on this series because it's not a bug; stable and downstream maintainers use Fixes: to indicate that they should pick up a patch on top of something they already have; there's no need for anyone to backport this.

Dave

Quoted 33 lines

Thanks,
Yilun

Quoted 29 lines

Remove it.

---
 drivers/fpga/altera-fpga2sdram.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/fpga/altera-fpga2sdram.c +0 -6
index 6b60ca004345..f4de3fea0b2d 100644
@@ -75,12 +75,6 @@ static int alt_fpga2sdram_enable_set(struct fpga_bridge *bridge, bool enable)
 	return _alt_fpga2sdram_enable_set(bridge->priv, enable);
 }
 
-struct prop_map {
-	char *prop_name;
-	u32 *prop_value;
-	u32 prop_max;
-};
-
 static const struct fpga_bridge_ops altera_fpga2sdram_br_ops = {
 	.enable_set = alt_fpga2sdram_enable_set,
 	.enable_show = alt_fpga2sdram_enable_show,
Signature · 1 line
2.45.1
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
Acked-by Applied
#4 lore raw
Quoted 10 lines · Dr. David Alan Gilbert
Quoted 9 lines · * Xu Yilun ([email protected]) wrote:
Quoted 1 line · On Thu, May 30, 2024 at 09:52:45PM +0100, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

This is only needed if the person sending the patch is not the author.

Quoted 3 lines

'prop_map' has been unused since the original
commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").

Quoted 6 lines
Quoted 1 line

Please use 'fixes:' tag.

I've avoided using fixes: on this series because it's not a bug; stable and downstream maintainers use Fixes: to indicate that they should pick up a patch on top of something they already have; there's no need for anyone to backport this.

It's good to me.

Applied to for-next.