Skip to contentSkip to conversation

bcachefs: track writeback errors using the generic tracking infrastructure

PATCH New Youling Tang 1 participant 1 message May 31, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcachefs: track writeback errors using the generic tracking infrastructure

From: Youling Tang <[email protected]>

We already using mapping_set_error() in bch2_writepage_io_done(), so all we need to do is to use file_check_and_advance_wb_err() when handling fsync() requests in bch2_fsync().

---
 fs/bcachefs/fs-io.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
fs/bcachefs/fs-io.c +6 -1
index ef20b64033e0..f5b266e51261 100644
@@ -192,7 +192,7 @@ int bch2_fsync(struct file *file, loff_t start, loff_t end, int datasync)
 {
 	struct bch_inode_info *inode = file_bch_inode(file);
 	struct bch_fs *c = inode->v.i_sb->s_fs_info;
-	int ret;
+	int ret, err;
 
 	ret = file_write_and_wait_range(file, start, end);
 	if (ret)
@@ -205,6 +205,11 @@ int bch2_fsync(struct file *file, loff_t start, loff_t end, int datasync)
 	ret = bch2_err_class(ret);
 	if (ret == -EROFS)
 		ret = -EIO;
+
+	err = file_check_and_advance_wb_err(file);
+	if (!ret)
+		ret = err;
+
 	return ret;
 }
 
Signature · 1 line
2.34.1