Skip to contentSkip to conversation

bpf: plug a warn about bpf_session_cookie without CONFIG_FPROBE

PATCH In review Mateusz Guzik 2 participants 2 messages Jun 1, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bpf: plug a warn about bpf_session_cookie without CONFIG_FPROBE

Building a kernel without said option results in:
WARN: resolve_btfids: unresolved symbol bpf_session_cookie

This is a bare-minimum patch to sort it out.

There are other uses of the bpf_session_cookie thing spread out thorought the file, they don't seem to break anything though.

---

I don't care how this gets addressed, I just want the warning gone. So I am not going to fight any ideas how to do it, as long as it gets done.

 kernel/bpf/verifier.c | 2 ++
 1 file changed, 2 insertions(+)
kernel/bpf/verifier.c +2 -0
index 48f3a9acdef3..b081bdd6f477 100644
@@ -11128,7 +11128,9 @@ BTF_ID(func, bpf_iter_css_task_new)
 #else
 BTF_ID_UNUSED
 #endif
+#ifdef CONFIG_FPROBES
 BTF_ID(func, bpf_session_cookie)
+#endif
 
 static bool is_kfunc_ret_null(struct bpf_kfunc_call_arg_meta *meta)
 {
Signature · 1 line
2.39.2
#1 lore raw
Quoted 8 lines · Mateusz Guzik

Building a kernel without said option results in:
WARN: resolve_btfids: unresolved symbol bpf_session_cookie

This is a bare-minimum patch to sort it out.

There are other uses of the bpf_session_cookie thing spread out thorought the file, they don't seem to break anything though.

Quoted 6 lines

---

I don't care how this gets addressed, I just want the warning gone. So I am not going to fight any ideas how to do it, as long as it gets done.

it's fixed by:
https://lore.kernel.org/bpf/[email protected]/

thanks,
jirka

Quoted 22 lines
 kernel/bpf/verifier.c | 2 ++
 1 file changed, 2 insertions(+)
kernel/bpf/verifier.c +2 -0
index 48f3a9acdef3..b081bdd6f477 100644
@@ -11128,7 +11128,9 @@ BTF_ID(func, bpf_iter_css_task_new)
 #else
 BTF_ID_UNUSED
 #endif
+#ifdef CONFIG_FPROBES
 BTF_ID(func, bpf_session_cookie)
+#endif
 
 static bool is_kfunc_ret_null(struct bpf_kfunc_call_arg_meta *meta)
 {
Signature · 1 line
2.39.2