cmd: bcb: Fix bcb compilation when CONFIG_CMD_BCB=n
PATCH 1/1 cmd: bcb: Fix bcb compilation when CONFIG_CMD_BCB=n
commit dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields") introduced the bcb_get() function.
When CONFIG_CMD_BCB=n, that function is stubbed.
The stubbed function has a wrong prototype: value_size arg is missing.
Add the missing argument to fix build when CONFIG_CMD_BCB=n.
--- include/bcb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/bcb.h +2 -1
@@ -58,7 +58,8 @@ static inline int bcb_set(enum bcb_field field, const char *value)return -EOPNOTSUPP ; } -static inline int bcb_get (enum bcb_field field,char *value_out) +static inline int bcb_get (enum bcb_field field, +char *value_out,size_t value_size) {return -EOPNOTSUPP ; }
---
base-commit: ea722aa5eb33740ae77e8816aeb72b385e621cd0
change-id: 20240603-bcb-compil-d8eaf7074475
Best regards,
Signature · 1 line
Mattijs Korpershoek <[email protected]>
hi,
Le 03/06/2024 à 11:04, Mattijs Korpershoek a écrit :
Quoted 33 lines
commit
dfeb4f0d7935("cmd: bcb: extend BCB C API to allow read/write the fields") introduced thebcb_get()function.When
CONFIG_CMD_BCB=n, that function is stubbed.
The stubbed function has a wrong prototype:value_sizearg is missing.Add the missing argument to fix build when
CONFIG_CMD_BCB=n.Fixes dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields")Signed-off-by Mattijs Korpershoek <[email protected]>--- include/bcb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)include/bcb.h +2
-2@@ -58,7 +58,8 @@ static inline int bcb_set(enum bcb_field field, const char *value)return -EOPNOTSUPP ; } -static inline int bcb_get (enum bcb_field field,char *value_out) +static inline int bcb_get (enum bcb_field field, +char *value_out,size_t value_size) {return -EOPNOTSUPP ; } ---base-commit:
ea722aa5eb33740ae77e8816aeb72b385e621cd0
change-id: 20240603-bcb-compil-d8eaf7074475
Quoted 1 line
Best regards,
Regards
Guillaume
Dmitrii Merkurev
Reviewed-byThank you and sorry for missing that
Quoted 33 lines · Mattijs Korpershoek
commit
dfeb4f0d7935("cmd: bcb: extend BCB C API to allow read/write the fields") introduced thebcb_get()function.When
CONFIG_CMD_BCB=n, that function is stubbed.
The stubbed function has a wrong prototype:value_sizearg is missing.Add the missing argument to fix build when
CONFIG_CMD_BCB=n.Fixes dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields")Signed-off-by Mattijs Korpershoek <[email protected]>--- include/bcb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)include/bcb.h +2
-2@@ -58,7 +58,8 @@ static inline int bcb_set(enum bcb_field field, const char *value)return -EOPNOTSUPP ; } -static inline int bcb_get (enum bcb_field field,char *value_out) +static inline int bcb_get (enum bcb_field field, +char *value_out,size_t value_size) {return -EOPNOTSUPP ; } ---base-commit:
ea722aa5eb33740ae77e8816aeb72b385e621cd0
change-id: 20240603-bcb-compil-d8eaf7074475
Quoted 5 lines
Best regards,
Signature · 1 line
Mattijs Korpershoek <[email protected]>
Signature · 1 line
Julien Masson
Quoted 9 lines · Mattijs Korpershoek
commit
dfeb4f0d7935("cmd: bcb: extend BCB C API to allow read/write the fields") introduced thebcb_get()function.When
CONFIG_CMD_BCB=n, that function is stubbed.
The stubbed function has a wrong prototype:value_sizearg is missing.Add the missing argument to fix build when
CONFIG_CMD_BCB=n.[...]
Applied to u-boot/master, thanks!
Signature · 1 line
Tom