Skip to contentSkip to conversation

mei: me: release irq in mei_me_pci_resume error path

PATCH New Tomas Winkler 1 participant 1 message Jun 4, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mei: me: release irq in mei_me_pci_resume error path

The mei_me_pci_resume doesn't release irq on the error path, in case mei_start() fails.

Fixes 33ec08263147 ("mei: revamp mei reset state machine")

---
V2: add Fixes reference and target to stable

 drivers/misc/mei/pci-me.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/misc/mei/pci-me.c +3 -1
index 7f59dd38c32f52dccf632fb4..6589635f8ba32b35fd28876d 100644
@@ -385,8 +385,10 @@ static int mei_me_pci_resume(struct device *device)
 	}
 
 	err = mei_restart(dev);
-	if (err)
+	if (err) {
+		free_irq(pdev->irq, dev);
 		return err;
+	}
 
 	/* Start timer if stopped in suspend */
 	schedule_delayed_work(&dev->timer_work, HZ);
Signature · 1 line
2.45.0