Skip to contentSkip to conversation

Potentially-breaking change in x86-power-control

DISCUSSION Zev Weiss 1 participant 1 message Jun 4, 2024

lore
Share & tools
lore

Zev Weiss

author
#0 lore raw

Hello all,

This is just a heads-up to users of x86-power-control that a potentially-breaking change has just been merged. The patch in
https://gerrit.openbmc.org/c/openbmc/x86-power-control/+/71283 (which just went in as commit edc86f3524e9) makes it so that the polarity configuration on input signals is no longer ignored. At time of writing it hasn't yet gotten SRCREV-bumped into openbmc/openbmc, but barring something unexpected it probably will be soon.

If the polarity settings in your platform's config are already correct nothing will change, but if you've inadvertently had incorrect polarity settings on your input signals, that error will no longer be silently papered over and you'll probably see some incorrect behavior until you fix it. I recommend testing with the latest version and fixing any configuration problems it turns up.

Thanks,
Zev