Skip to contentSkip to conversation

lib/Kconfig.debug: document panic= command line option for PANIC_TIMEOUT

PATCH Superseded Brian Masney 2 participants 3 messages Jun 5, 2024 Library code

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/Kconfig.debug: document panic= command line option for PANIC_TIMEOUT

PANIC_TIMEOUT can also be controlled with the panic= kernel command line option, so let's reference it in the Kconfig help. This option is already documented in kernel-parameters.txt.

---
 lib/Kconfig.debug | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
lib/Kconfig.debug +2 -1
index 59b6765d86b8..a6eb7425b888 100644
@@ -1043,7 +1043,8 @@ config PANIC_TIMEOUT
 	  Set the timeout value (in seconds) until a reboot occurs when
 	  the kernel panics. If n = 0, then we wait forever. A timeout
 	  value n > 0 will wait n seconds before rebooting, while a timeout
-	  value n < 0 will reboot immediately.
+	  value n < 0 will reboot immediately. The kernel command line
+	  option panic= may be used to override this option.
 
 config LOCKUP_DETECTOR
 	bool
Signature · 1 line
2.45.1
Reviewed-by on v1 1/1
#1 lore raw

Brian Masney <[email protected]> writes:

Hello Brian,

Quoted 14 lines

PANIC_TIMEOUT can also be controlled with the panic= kernel command line option, so let's reference it in the Kconfig help. This option is already documented in kernel-parameters.txt.

---
 lib/Kconfig.debug | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
lib/Kconfig.debug +0 -0
index 59b6765d86b8..a6eb7425b888 100644

lib/Kconfig.debug config PANIC_TIMEOUT · line 1048

Quoted 7 lines
lib/Kconfig.debug +2 -1
@@ -1043,7 +1043,8 @@ config PANIC_TIMEOUT
 	  Set the timeout value (in seconds) until a reboot occurs when
 	  the kernel panics. If n = 0, then we wait forever. A timeout
 	  value n > 0 will wait n seconds before rebooting, while a timeout
-	  value n < 0 will reboot immediately.
+	  value n < 0 will reboot immediately. The kernel command line
+	  option panic= may be used to override this option.
 

Thanks for adding this, I wasn't aware of that panic= cmdline before.

Maybe it could also be mentioned that the timeout can be overriden by user-space using the /proc/sys/kernel/panic sysfs entry too ?

Regardless, the patch looks good to me.

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
#2 lore raw
Quoted 28 lines · Javier Martinez Canillas

Brian Masney <[email protected]> writes:

Hello Brian,

Quoted 14 lines

PANIC_TIMEOUT can also be controlled with the panic= kernel command line option, so let's reference it in the Kconfig help. This option is already documented in kernel-parameters.txt.

---
 lib/Kconfig.debug | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
lib/Kconfig.debug +0 -0
index 59b6765d86b8..a6eb7425b888 100644

lib/Kconfig.debug config PANIC_TIMEOUT · line 1048

Quoted 7 lines
lib/Kconfig.debug +2 -1
@@ -1043,7 +1043,8 @@ config PANIC_TIMEOUT
 	  Set the timeout value (in seconds) until a reboot occurs when
 	  the kernel panics. If n = 0, then we wait forever. A timeout
 	  value n > 0 will wait n seconds before rebooting, while a timeout
-	  value n < 0 will reboot immediately.
+	  value n < 0 will reboot immediately. The kernel command line
+	  option panic= may be used to override this option.
 

Thanks for adding this, I wasn't aware of that panic= cmdline before.

Quoted 6 lines

Maybe it could also be mentioned that the timeout can be overriden by user-space using the /proc/sys/kernel/panic sysfs entry too ?

Regardless, the patch looks good to me.

I can add that. I'll wait a few days send a v2 to see if there's any other feedback.

Brian