Skip to contentSkip to conversation

modpost: do not warn about missing MODULE_DESCRIPTION() for vmlinux.o

PATCH In review Masahiro Yamada 2 participants 2 messages Jun 6, 2024 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 modpost: do not warn about missing MODULE_DESCRIPTION() for vmlinux.o

Building with W=1 incorrectly emits the following warning:

WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o

This check should apply only to modules.

Fixes 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing")

---

 scripts/mod/modpost.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
scripts/mod/modpost.c +3 -2
index 937294ff164f..f48d72d22dc2 100644
@@ -1647,10 +1647,11 @@ static void read_symbols(const char *modname)
 			namespace = get_next_modinfo(&info, "import_ns",
 						     namespace);
 		}
+
+		if (extra_warn && !get_modinfo(&info, "description"))
+			warn("missing MODULE_DESCRIPTION() in %s\n", modname);
 	}
 
-	if (extra_warn && !get_modinfo(&info, "description"))
-		warn("missing MODULE_DESCRIPTION() in %s\n", modname);
 	for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
 		symname = remove_dot(info.strtab + sym->st_name);
 
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw

LGMT, thanks

Quoted 35 lines · Masahiro Yamada

Building with W=1 incorrectly emits the following warning:

WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o

This check should apply only to modules.

Fixes 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing")

---

 scripts/mod/modpost.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
scripts/mod/modpost.c +3 -3
index 937294ff164f..f48d72d22dc2 100644
@@ -1647,10 +1647,11 @@ static void read_symbols(const char *modname)
                        namespace = get_next_modinfo(&info, "import_ns",
                                                     namespace);
                }
+
+               if (extra_warn && !get_modinfo(&info, "description"))
+                       warn("missing MODULE_DESCRIPTION() in %s\n", modname);
        }
 
-       if (extra_warn && !get_modinfo(&info, "description"))
-               warn("missing MODULE_DESCRIPTION() in %s\n", modname);
        for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
                symname = remove_dot(info.strtab + sym->st_name);
 
--

2.43.0