selftests/mm: use asm volatile to not optimize mmap read variable
Subsystems (4)
PATCH v3 1/1 selftests/mm: use asm volatile to not optimize mmap read variable
From: Pankaj Raghav <[email protected]>
create_pagecache_thp_and_fd() in split_huge_page_test.c used the variable dummy to perform mmap read.
However, this test was skipped even on XFS which has large folio support. The issue was compiler (gcc 13.2.0) was optimizing out the dummy variable, therefore, not creating huge page in the page cache.
Use asm volatile() trick to force the compiler not to optimize out the loop where we read from the mmaped addr. This is similar to what is being done in other tests (cow.c, etc)
As the variable is now used in the asm statement, remove the unused attribute.
---
Changes since v2:
- Use the asm volatile trick to force the compiler to not optimize the read into dummy variable. (David)
tools/testing/selftests/mm/split_huge_page_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/mm/split_huge_page_test.c +2 -1
@@ -300,7 +300,7 @@ int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, int *fd, char **addr) {size_t i; -int __attribute__((unused)) dummy =0 ; +int dummy =0 ;srand (time (NULL ));
@@ -341,6 +341,7 @@ int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, int *fd,for (size_t i =0 ; i < fd_size; i++) dummy += *(*addr + i); + asmvolatile ("" :"+r" (dummy));if (!check_huge_file (*addr, fd_size / pmd_pagesize, pmd_pagesize)) {ksft_print_msg ("No large pagecache folio generated, please provide a filesystem supporting large folio\n" );
base-commit: d97496ca23a2d4ee80b7302849404859d9058bcd
Signature · 1 line
2.44.1
Zi Yan
reviewerQuoted 16 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
create_pagecache_thp_and_fd()insplit_huge_page_test.cused the variable dummy to perform mmap read.However, this test was skipped even on XFS which has large folio support. The issue was compiler (gcc 13.2.0) was optimizing out the dummy variable, therefore, not creating huge page in the page cache.
Use asm
volatile()trick to force the compiler not to optimize out the loop where we read from the mmaped addr. This is similar to what is being done in other tests (cow.c, etc)As the variable is now used in the asm statement, remove the unused attribute.
Quoted 9 lines
Signed-off-by Pankaj Raghav <[email protected]>---
Changes since v2:
- Use the asm volatile trick to force the compiler to not optimize the read into dummy variable. (David)tools/testing/selftests/mm/split_huge_page_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
LGTM. Reviewed-by: Zi Yan <[email protected]>
Best Regards,
Yan, Zi
Quoted 47 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
create_pagecache_thp_and_fd()insplit_huge_page_test.cused the variable dummy to perform mmap read.However, this test was skipped even on XFS which has large folio support. The issue was compiler (gcc 13.2.0) was optimizing out the dummy variable, therefore, not creating huge page in the page cache.
Use asm
volatile()trick to force the compiler not to optimize out the loop where we read from the mmaped addr. This is similar to what is being done in other tests (cow.c, etc)As the variable is now used in the asm statement, remove the unused attribute.
Signed-off-by Pankaj Raghav <[email protected]>---
Changes since v2:
- Use the asm volatile trick to force the compiler to not optimize the read into dummy variable. (David)tools/testing/selftests/mm/split_huge_page_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)tools/testing/selftests/mm/split_huge_page_test.c +2
-1@@ -300,7 +300,7 @@ int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, int *fd, char **addr) {size_t i; -int __attribute__((unused)) dummy =0 ; +int dummy =0 ;srand (time (NULL ));@@ -341,6 +341,7 @@ int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, int *fd,for (size_t i =0 ; i < fd_size; i++) dummy += *(*addr + i); + asmvolatile ("" :"+r" (dummy));if (!check_huge_file (*addr, fd_size / pmd_pagesize, pmd_pagesize)) {ksft_print_msg ("No large pagecache folio generated, please provide a filesystem supporting large folio\n" );
Quoted 1 line
base-commit:
d97496ca23a2d4ee80b7302849404859d9058bcd
I was wondering if we should factor that out into a mm-selftest helper function, but that can be done later.
Signature · 3 lines
Cheers, David / dhildenb
Andrew Morton
maintainerQuoted 9 lines · On Thu, 6 Jun 2024 20:36:19 +0000 "Pankaj Raghav (Samsung)"…
From: Pankaj Raghav <[email protected]>
create_pagecache_thp_and_fd()insplit_huge_page_test.cused the variable dummy to perform mmap read.However, this test was skipped even on XFS which has large folio support. The issue was compiler (gcc 13.2.0) was optimizing out the dummy variable, therefore, not creating huge page in the page cache.
Quoted 7 lines
Use asm
volatile()trick to force the compiler not to optimize out the loop where we read from the mmaped addr. This is similar to what is being done in other tests (cow.c, etc)As the variable is now used in the asm statement, remove the unused attribute.
What are the runtime effects of this change? An inappropriate test failure? If so, shouldn't we fix 6.9.x kernels also? And is fc4d182316bd ("mm: huge_memory: enable debugfs to split huge pages to any order") an appropriate Fixes: target?
Quoted 15 lines · Andrew Morton
Quoted 13 lines · On Thu, 6 Jun 2024 20:36:19 +0000 "Pankaj Raghav (Samsung)"…
From: Pankaj Raghav <[email protected]>
create_pagecache_thp_and_fd()insplit_huge_page_test.cused the variable dummy to perform mmap read.However, this test was skipped even on XFS which has large folio support. The issue was compiler (gcc 13.2.0) was optimizing out the dummy variable, therefore, not creating huge page in the page cache.
Use asm
volatile()trick to force the compiler not to optimize out the loop where we read from the mmaped addr. This is similar to what is being done in other tests (cow.c, etc)
Quoted 8 lines
Quoted 3 lines
As the variable is now used in the asm statement, remove the unused attribute.
What are the runtime effects of this change? An inappropriate test failure? If so, shouldn't we fix 6.9.x kernels also? And is
fc4d182316bd("mm:huge_memory: enable debugfs to split huge pages to any order") an appropriate Fixes: target?
I mentioned it here in the commit message:
However, this test was skipped even on XFS which has large folio support.
So the test just skip these cases and does not fail. That is why I didn't use the Fixes tag. Let me know if it needs one.
--
Pankaj