Skip to contentSkip to conversation

Revert 5aec989 because it prevents ALC236 headphones from working and causes freezing on reboot

PATCH New Nick 1 participant 1 message Jun 9, 2024 Sound

lore
Share & tools
lore

Nick

author
#0 lore raw

PATCH 1/1 Revert 5aec989 because it prevents ALC236 headphones from working and causes freezing on reboot

---
 sound/pci/hda/patch_realtek.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/pci/hda/patch_realtek.c +2 -2
index e3c0b9d5552d..993c1e8b68d9 100644
@@ -581,8 +581,6 @@ static void alc_shutup_pins(struct hda_codec *codec)
 	struct alc_spec *spec = codec->spec;
 
 	switch (codec->core.vendor_id) {
-	case 0x10ec0236:
-	case 0x10ec0256:
 	case 0x19e58326:
 	case 0x10ec0283:
 	case 0x10ec0286:
@@ -3650,6 +3648,8 @@ static void alc256_shutup(struct hda_codec *codec)
 	/* If disable 3k pulldown control for alc257, the Mic detection will not work correctly
 	 * when booting with headset plugged. So skip setting it for the codec alc257
 	 */
+	if (codec->core.vendor_id != 0x10ec0257)
+		alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
 	if (spec->en_3kpull_low)
 		alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
 
Signature · 1 line
2.45.1