arm: dts: mvebu: Update DTS for Thecus N2350 board
PATCH 1/1 arm: dts: mvebu: Update DTS for Thecus N2350 board
- Change the spi-max-frequency to 50000000 (50 Mhz). According to the data sheet[1], the MX25L3205D max frequency is 86 Mhz. Using 50 Mhz in the DTS to ensure u-boot is consistent with what Linux kernel expected.
- Update GPIO fan to conform to the latest DT binding.
[1] MX25L3205D-MX25L1605D-MX25L6405D-Macronix-MX25L3205DM2I-12G-datasheet.pdf
---
arch/arm/dts/armada-385-thecus-n2350.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm/dts/armada-385-thecus-n2350.dts +5 -5
@@ -2,7 +2,7 @@ /* * Device Tree file for Thecus N2350 board * - * Copyright (C) 2018-2023 Tony Dinh <[email protected]> + * Copyright (C) 2018-2024 Tony Dinh <[email protected]> * Copyright (C) 2018 Manuel Jung <[email protected]> */
@@ -143,9 +143,9 @@ fan { compatible = "gpio-fan"; gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>; - gpio-fan,speed-map = < 0 0 - 600 1 - 3000 2 >; + gpio-fan,speed-map = < 0 0>, + <600 1>, + <3000 2 >; pinctrl-0 = <&pmx_fan>; pinctrl-names = "default"; };
@@ -415,7 +415,7 @@ compatible = "jedec,spi-nor"; reg = <0>; - spi-max-frequency = <108000000>; + spi-max-frequency = <50000000>; spi-cpha; partition@0 {
Signature · 1 line
2.39.2
Hello Tony,
Please see a few comments below.
Quoted 4 lines · Tony Dinh
- Change the spi-max-frequency to 50000000 (50 Mhz). According to the data sheet[1], the MX25L3205D max frequency is 86 Mhz. Using 50 Mhz in the DTS to ensure u-boot is consistent with what Linux kernel expected.
- Update GPIO fan to conform to the latest DT binding.
There's no need for the bullet points, plain prose will do fine instead.
Quoted 1 line
[1] MX25L3205D-MX25L1605D-MX25L6405D-Macronix-MX25L3205DM2I-12G-datasheet.pdf
Unless you can provide a real, working URL for the datasheet, this reference should actually be deleted.
Quoted 42 lines
Signed-off-by Tony Dinh <[email protected]>---
arch/arm/dts/armada-385-thecus-n2350.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)arch/arm/dts/armada-385-thecus-n2350.dts +5
-5@@ -2,7 +2,7 @@ /* * Device Tree file for Thecus N2350 board * - * Copyright (C) 2018-2023 Tony Dinh <[email protected]> + * Copyright (C) 2018-2024 Tony Dinh <[email protected]> * Copyright (C) 2018 Manuel Jung <[email protected]> */@@ -143,9 +143,9 @@ fan { compatible = "gpio-fan"; gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>; - gpio-fan,speed-map = < 0 0 - 600 1 - 3000 2 >; + gpio-fan,speed-map = < 0 0>, + <600 1>, + <3000 2 >; pinctrl-0 = <&pmx_fan>; pinctrl-names = "default"; };@@ -415,7 +415,7 @@ compatible = "jedec,spi-nor"; reg = <0>; - spi-max-frequency = <108000000>; + spi-max-frequency = <50000000>; spi-cpha; partition@0 {
Hi Dragan,
Quoted 5 lines · Dragan Simic
Hello Tony,
Please see a few comments below.
Quoted 7 lines
Quoted 4 lines · Tony Dinh
- Change the spi-max-frequency to 50000000 (50 Mhz). According to the data sheet[1], the MX25L3205D max frequency is 86 Mhz. Using 50 Mhz in the DTS to ensure u-boot is consistent with what Linux kernel expected.
- Update GPIO fan to conform to the latest DT binding.There's no need for the bullet points, plain prose will do fine instead.
I like bullet points :) All my patch descriptions have bullet points when there are 2 or more different items.
Quoted 7 lines
Quoted 3 lines
[1] MX25L3205D-MX25L1605D-MX25L6405D-Macronix-MX25L3205DM2I-12G-datasheet.pdf
Unless you can provide a real, working URL for the datasheet, this reference
should actually be deleted.
It was my oversight. That should have been this URL:
https://www.macronix.com/Lists/Datasheet/Attachments/8575/MX25L3205D,%203V,%2032Mb,%20v1.5.pdf
I'll wait for Stefan to review the patch and let him decide whether I should send in a V2 patch or he will modify the commit description.
Thanks for the comments!
All the best,
Tony
Quoted 43 lines
Quoted 43 lines
Signed-off-by Tony Dinh <[email protected]>---
arch/arm/dts/armada-385-thecus-n2350.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)arch/arm/dts/armada-385-thecus-n2350.dts +5
-5@@ -2,7 +2,7 @@ /* * Device Tree file for Thecus N2350 board * - * Copyright (C) 2018-2023 Tony Dinh <[email protected]> + * Copyright (C) 2018-2024 Tony Dinh <[email protected]> * Copyright (C) 2018 Manuel Jung <[email protected]> */@@ -143,9 +143,9 @@ fan { compatible = "gpio-fan"; gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>; - gpio-fan,speed-map = < 0 0 - 600 1 - 3000 2 >; + gpio-fan,speed-map = < 0 0>, + <600 1>, + <3000 2 >; pinctrl-0 = <&pmx_fan>; pinctrl-names = "default"; };@@ -415,7 +415,7 @@ compatible = "jedec,spi-nor"; reg = <0>; - spi-max-frequency = <108000000>; + spi-max-frequency = <50000000>; spi-cpha; partition@0 {
Quoted 27 lines · Tony Dinh
Hi Dragan,
Quoted 5 lines · Dragan Simic
Hello Tony,
Please see a few comments below.
Quoted 7 lines
Quoted 4 lines · Tony Dinh
- Change the spi-max-frequency to 50000000 (50 Mhz). According to the data sheet[1], the MX25L3205D max frequency is 86 Mhz. Using 50 Mhz in the DTS to ensure u-boot is consistent with what Linux kernel expected.
- Update GPIO fan to conform to the latest DT binding.There's no need for the bullet points, plain prose will do fine instead.
I like bullet points :) All my patch descriptions have bullet points when there are 2 or more different items.
Quoted 7 lines
Quoted 3 lines
[1] MX25L3205D-MX25L1605D-MX25L6405D-Macronix-MX25L3205DM2I-12G-datasheet.pdf
Unless you can provide a real, working URL for the datasheet, this reference
should actually be deleted.
Quoted 6 lines
It was my oversight. That should have been this URL:
https://www.macronix.com/Lists/Datasheet/Attachments/8575/MX25L3205D,%203V,%2032Mb,%20v1.5.pdf
I'll wait for Stefan to review the patch and let him decide whether I should send in a V2 patch or he will modify the commit description.
I've changed the commit message accordingly.
Applied to u-boot-marvell/master
Thanks,
Stefan
Quoted 43 lines
Thanks for the comments!
All the best,
TonyQuoted 38 lines
Quoted 38 lines
Signed-off-by Tony Dinh <[email protected]>---
arch/arm/dts/armada-385-thecus-n2350.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)arch/arm/dts/armada-385-thecus-n2350.dts +4
-4@@ -2,7 +2,7 @@ /* * Device Tree file for Thecus N2350 board * - * Copyright (C) 2018-2023 Tony Dinh <[email protected]> + * Copyright (C) 2018-2024 Tony Dinh <[email protected]> * Copyright (C) 2018 Manuel Jung <[email protected]> */@@ -143,9 +143,9 @@ fan { compatible = "gpio-fan"; gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>; - gpio-fan,speed-map = < 0 0 - 600 1 - 3000 2 >; + gpio-fan,speed-map = < 0 0>, + <600 1>, + <3000 2 >; pinctrl-0 = <&pmx_fan>; pinctrl-names = "default"; };@@ -415,7 +415,7 @@ compatible = "jedec,spi-nor"; reg = <0>;
Quoted 5 lines
Quoted 5 lines
arch/arm/dts/armada-385-thecus-n2350.dts line 421
Quoted 5 lines
arch/arm/dts/armada-385-thecus-n2350.dts +1
-1- spi-max-frequency = <108000000>; + spi-max-frequency = <50000000>; spi-cpha; partition@0 {
Viele Grüße,
Stefan Roese
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]