arm64: dts: rockchip: make "poweroff" work on rock-5a
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: make "poweroff" work on rock-5a
to make "poweroff" command work, add "system-power-controller;" into pmic@0. without this, "poweroff" works as same as "reboot".
--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +2 -0
@@ -395,6 +395,8 @@ pmic@0 { <&rk806_dvs2_null>, <&rk806_dvs3_null>; spi-max-frequency = <1000000>; + system-power-controller; + vcc1-supply = <&vcc5v0_sys>; vcc2-supply = <&vcc5v0_sys>; vcc3-supply = <&vcc5v0_sys>;
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hello Fukami,
Quoted 6 lines · FUKAUMI Naoki
to make "poweroff" command work, add "system-power-controller;" into pmic@0. without this, "poweroff" works as same as "reboot".
Fixes 75fdcbc8f4c1 ("arm64: dts: rockchip: add PMIC to rock-5a")Signed-off-by FUKAUMI Naoki <[email protected]>
Looking good to me, with a small remark below.
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts pmic@0 { · line 397
Quoted 13 lines
--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +0
-0@@ -395,6 +395,8 @@ pmic@0 { <&rk806_dvs2_null>, <&rk806_dvs3_null>; spi-max-frequency = <1000000>;
I don't think there's need for the empty line right above, i.e. between the "spi-max-frequency" and "system-power-controller" lines.
Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +2
-0+ system-power-controller; + vcc1-supply = <&vcc5v0_sys>; vcc2-supply = <&vcc5v0_sys>; vcc3-supply = <&vcc5v0_sys>;
Quoted 5 lines · Dragan Simic
Hello Fukami,
Quoted 2 lines · FUKAUMI Naoki
to make "poweroff" command work, add "system-power-controller;" into pmic@0. without this, "poweroff" works as same as "reboot".
Sorry, I forgot to add that the description above could be reworded a bit, e.g. not to repeat what's already visible in the patch itself.
For example:
Designate the RK806 PMIC on the Radxa ROCK 5A as the system power controller, so the board shuts down properly on poweroff(8).
The patch subject could also be tweaked a bit, e.g. to refer to the board as "Radxa ROCK 5A".
Quoted 34 lines
Quoted 2 lines
Fixes 75fdcbc8f4c1 ("arm64: dts: rockchip: add PMIC to rock-5a")Signed-off-by FUKAUMI Naoki <[email protected]>Looking good to me, with a small remark below.
Reviewed-by Dragan Simic <[email protected]>arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts pmic@0 { · line 397
Quoted 13 lines
--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +0
-0@@ -395,6 +395,8 @@ pmic@0 { <&rk806_dvs2_null>, <&rk806_dvs3_null>; spi-max-frequency = <1000000>;I don't think there's need for the empty line right above, i.e. between the "spi-max-frequency" and "system-power-controller" lines.
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts pmic@0 { · line 402
Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +2
-0+ system-power-controller; + vcc1-supply = <&vcc5v0_sys>; vcc2-supply = <&vcc5v0_sys>; vcc3-supply = <&vcc5v0_sys>;_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hello Dragan,
Thank you so much for your reply!
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 10 lines · Dragan Simic
Quoted 5 lines · Dragan Simic
Hello Fukami,
Quoted 2 lines · FUKAUMI Naoki
to make "poweroff" command work, add "system-power-controller;" into pmic@0. without this, "poweroff" works as same as "reboot".
Sorry, I forgot to add that the description above could be reworded a bit, e.g. not to repeat what's already visible in the patch itself.
Quoted 43 lines
For example:
Designate the RK806 PMIC on the Radxa ROCK 5A as the system power controller, so the board shuts down properly on poweroff(8).
The patch subject could also be tweaked a bit, e.g. to refer to the board as "Radxa ROCK 5A".
Quoted 34 lines
Quoted 2 lines
Fixes 75fdcbc8f4c1 ("arm64: dts: rockchip: add PMIC to rock-5a")Signed-off-by FUKAUMI Naoki <[email protected]>Looking good to me, with a small remark below.
Reviewed-by Dragan Simic <[email protected]>arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts pmic@0 { · line 397
Quoted 13 lines
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 2 ++1 file changed, 2 insertions(+)arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +0
-0@@ -395,6 +395,8 @@ pmic@0 { <&rk806_dvs2_null>, <&rk806_dvs3_null>; spi-max-frequency = <1000000>;I don't think there's need for the empty line right above, i.e. between the "spi-max-frequency" and "system-power-controller" lines.
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts pmic@0 { · line 402
Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +2
-0+ system-power-controller; + vcc1-supply = <&vcc5v0_sys>; vcc2-supply = <&vcc5v0_sys>; vcc3-supply = <&vcc5v0_sys>;_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v2 1/1 arm64: dts: rockchip: make poweroff(8) work on Radxa ROCK 5A
In reply to FUKAUMI NaokiDesignate the RK806 PMIC on the Radxa ROCK 5A as the system power controller, so the board shuts down properly on poweroff(8).
Changes in v2:
- remove an empty line above "system-power-controller;"
- reword commit message
- add R-b tag
--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1 -0
@@ -394,6 +394,7 @@ pmic@0 { pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, <&rk806_dvs2_null>, <&rk806_dvs3_null>; spi-max-frequency = <1000000>; + system-power-controller; vcc1-supply = <&vcc5v0_sys>; vcc2-supply = <&vcc5v0_sys>;
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v2] arm64: dts: rockchip: make poweroff(8) work on Radxa ROCK 5A
Hello Fukami,
Quoted 7 lines · FUKAUMI Naoki
Designate the RK806 PMIC on the Radxa ROCK 5A as the system power controller, so the board shuts down properly on poweroff(8).
Fixes 75fdcbc8f4c1 ("arm64: dts: rockchip: add PMIC to rock-5a")Signed-off-by FUKAUMI Naoki <[email protected]>Reviewed-by Dragan Simic <[email protected]>
Thanks for the v2. Just another small suggestion, the tags above should go like this, with no empty lines between them:
Quoted 21 lines
Changes in v2:
- remove an empty line above "system-power-controller;"
- reword commit message
- add R-b tag--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1
-0@@ -394,6 +394,7 @@ pmic@0 { pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, <&rk806_dvs2_null>, <&rk806_dvs3_null>; spi-max-frequency = <1000000>; + system-power-controller; vcc1-supply = <&vcc5v0_sys>; vcc2-supply = <&vcc5v0_sys>;
PATCH v3 1/1 arm64: dts: rockchip: make poweroff(8) work on Radxa ROCK 5A
In reply to FUKAUMI NaokiDesignate the RK806 PMIC on the Radxa ROCK 5A as the system power controller, so the board shuts down properly on poweroff(8).
Changes in v3:
- sort tags
Changes in v2:
- remove an empty line above "system-power-controller;"
- reword commit message
- add R-b tag
--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1 -0
@@ -394,6 +394,7 @@ pmic@0 { pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, <&rk806_dvs2_null>, <&rk806_dvs3_null>; spi-max-frequency = <1000000>; + system-power-controller; vcc1-supply = <&vcc5v0_sys>; vcc2-supply = <&vcc5v0_sys>;
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v3] arm64: dts: rockchip: make poweroff(8) work on Radxa ROCK 5A
Hi,
Am Mittwoch, 12. Juni 2024, 05:35:23 CEST schrieb FUKAUMI Naoki:
Quoted 6 lines
Designate the RK806 PMIC on the Radxa ROCK 5A as the system power controller, so the board shuts down properly on poweroff(8).
Fixes 75fdcbc8f4c1 ("arm64: dts: rockchip: add PMIC to rock-5a")Reviewed-by Dragan Simic <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>
applied as fix for 6.10
Same comment about patch-versions in mail-threads like on the cd-gpios revert.
Thanks
Heiko