Skip to contentSkip to conversation

monitor: too large shift exponent displaying payload expression

PATCH New Pablo Neira Ayuso 1 participant 1 message Jun 11, 2024 netfilter

lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH v2 1/1 monitor: too large shift exponent displaying payload expression

ASAN reports too large shift exponent when displaying traces for raw payload expression:

trace id ec23e848 ip x y packet: oif "wlan0" src/netlink.c:2100:32: runtime error: shift exponent 1431657095 is too large for 32-bit type 'int'

skip if proto_unknown_template is set on in this payload expression.

Fixes be5d9120e81e ("nft monitor [ trace ]")

---
v2: check for proto_unknown_template, otherwise problem persists.

 src/netlink.c | 1 +
 1 file changed, 1 insertion(+)
src/netlink.c +1 -0
index 0088b742d573..efb0b69939dc 100644
@@ -2096,6 +2096,7 @@ restart:
 		/* Skip unknown and filtered expressions */
 		desc = lhs->payload.desc;
 		if (lhs->dtype == &invalid_type ||
+		    lhs->payload.tmpl == &proto_unknown_template ||
 		    desc->checksum_key == payload_hdr_field(lhs) ||
 		    desc->format.filter & (1 << payload_hdr_field(lhs))) {
 			expr_free(lhs);
Signature · 1 line
2.30.2