scsi: core: Fix an incorrect comment
PATCH v2 1/1 scsi: core: Fix an incorrect comment
The comment that scsi_static_device_list would go away was added more than 18 years ago. Today, that list is still there and a large number of additional entries have been added. This shows that this comment is incorrect. Hence fix that comment.
---
Changes compared to v1: addressed Christoph's review feedback.
drivers/scsi/scsi_devinfo.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/scsi/scsi_devinfo.c +5 -6
@@ -39,13 +39,12 @@ static LIST_HEAD(scsi_dev_info_list);static char scsi_dev_flags[256 ];/* -* scsi_static_device_list: deprecated list of devices that require -* settings that differ from the default, includes black-listed (broken) -* devices. The entries here are added to the tail of scsi_dev_info_list -* via scsi_dev_info_list_init. +* scsi_static_device_list: list of devices that require settings that differ +* from the default, includes black-listed (broken) devices. The entries here +* are added to the tail of scsi_dev_info_list via scsi_dev_info_list_init. * -* Do not add to this list, use the command line or proc interface to add -* to the scsi_dev_info_list. This table will eventually go away. +* If possible, set the BLIST_* flags from inside a SCSI LLD rather than +* adding an entry to this list. */ static struct { char *vendor;
Martin K. Petersen
AppliedBart,
Quoted 4 lines
The comment that
scsi_static_device_listwould go away was added more than 18 years ago. Today, that list is still there and a large number of additional entries have been added. This shows that this comment is incorrect. Hence fix that comment.
Applied to 6.11/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 6 lines · Bart Van Assche
The comment that
scsi_static_device_listwould go away was added more than 18 years ago. Today, that list is still there and a large number of additional entries have been added. This shows that this comment is incorrect. Hence fix that comment.
Applied to 6.11/scsi-queue, thanks!
[1/1] scsi: core: Fix an incorrect comment
https://git.kernel.org/mkp/scsi/c/14d38356ec33
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering