i2c: Add nop fwnode operations
Subsystems (2)
PATCH 1/1 i2c: Add nop fwnode operations
Add nop variants of i2c_find_device_by_fwnode(), i2c_find_adapter_by_fwnode() and i2c_get_adapter_by_fwnode() for use without CONFIG_I2C.
---
Hi Wolfram, others,
This is to support COMPILE_TEST (drivers/media/pci/intel/ipu-bridge.c for instance). Alternatively we'd need #ifdefs. Similar OF functions have dummies, too.
We currently get:
ERROR: modpost: "i2c_acpi_new_device_by_fwnode" [drivers/media/pci/intel/ipu-bridge.ko] undefined!
ERROR: modpost: "i2c_find_device_by_fwnode" [drivers/media/pci/intel/ipu-bridge.ko] undefined!
- Sakari
include/linux/i2c.h | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-)
include/linux/i2c.h +22 -2
@@ -960,8 +960,6 @@ int i2c_handle_smbus_host_notify(struct i2c_adapter *adap, unsigned short addr);#define builtin_i2c_driver (__i2c_driver) \ builtin_driver(__i2c_driver, i2c_add_driver) -#endif /* I2C */ -/* must call put_device() when done with returned i2c_client device */ struct i2c_client *i2c_find_device_by_fwnode (struct fwnode_handle *fwnode);
@@ -971,6 +969,28 @@ struct i2c_adapter *i2c_find_adapter_by_fwnode(struct fwnode_handle *fwnode);/* must call i2c_put_adapter() when done with returned i2c_adapter device */ struct i2c_adapter *i2c_get_adapter_by_fwnode (struct fwnode_handle *fwnode); +#else /* I2C */ + +static inline struct i2c_client * +i2c_find_device_by_fwnode (struct fwnode_handle *fwnode) +{ +return NULL ; +} + +static inline struct i2c_adapter * +i2c_find_adapter_by_fwnode (struct fwnode_handle *fwnode) +{ +return NULL ; +} + +static inline struct i2c_adapter * +i2c_get_adapter_by_fwnode (struct fwnode_handle *fwnode) +{ +return NULL ; +} + +#endif /* !I2C */ +#if IS_ENABLED (CONFIG_OF )/* must call put_device() when done with returned i2c_client device */ static inline struct i2c_client *of_find_i2c_device_by_node (struct device_node *node)
Signature · 1 line
2.39.2
Wolfram Sang
AppliedQuoted 5 lines · Sakari Ailus
Add nop variants of
i2c_find_device_by_fwnode(),i2c_find_adapter_by_fwnode()andi2c_get_adapter_by_fwnode()for use withoutCONFIG_I2C.Signed-off-by Sakari Ailus <[email protected]>
Applied to for-current, thanks!
Quoted 8 lines · Wolfram Sang
Quoted 5 lines · Sakari Ailus
Add nop variants of
i2c_find_device_by_fwnode(),i2c_find_adapter_by_fwnode()andi2c_get_adapter_by_fwnode()for use withoutCONFIG_I2C.Signed-off-by Sakari Ailus <[email protected]>Applied to for-current, thanks!
Thank you, Wolfram!
Signature · 1 line
Sakari Ailus