add mseal to /proc/pid/smaps
Subsystems (5)
cover add mseal to /proc/pid/smaps
From: Jeff Xu <[email protected]>
Add mseal information in /proc/pid/smaps to indicate the VMA is sealed.
I appreicate Adhemerval Zanella Netto to bring this to my attention. [1]
[1] https://public-inbox.org/libc-alpha/[email protected]/#t
Jeff Xu (1):
/proc/pid/smaps: add mseal info for vma
Documentation/filesystems/proc.rst | 1 + fs/proc/task_mmu.c | 3 +++ include/linux/mm.h | 5 +++++ mm/internal.h | 5 ----- 4 files changed, 9 insertions(+), 5 deletions(-)
Signature · 1 line
2.45.2.627.g7a2c4fd464-goog
PATCH 1/1 /proc/pid/smaps: add mseal info for vma
From: Jeff Xu <[email protected]>
Add sp in /proc/pid/smaps to indicate vma is sealed
--- Documentation/filesystems/proc.rst | 1 + fs/proc/task_mmu.c | 3 +++ include/linux/mm.h | 5 +++++ mm/internal.h | 5 ----- 4 files changed, 9 insertions(+), 5 deletions(-)
Documentation/filesystems/proc.rst +1 -0
@@ -571,6 +571,7 @@ encoded manner. The codes are the following: um userfaultfd missing tracking uw userfaultfd wr-protect tracking ss shadow stack page + sp sealed page == ======================================= Note that there is no guarantee that every flag and associated mnemonic will
fs/proc/task_mmu.c +3 -0
@@ -711,6 +711,9 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)#endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */ #ifdef CONFIG_X86_USER_SHADOW_STACK [ilog2 (VM_SHADOW_STACK )] ="ss" , +#endif +#ifdef CONFIG_64BIT + [ilog2(VM_SEALED)] = "sp", #endif };size_t i;
include/linux/mm.h +5 -0
@@ -314,6 +314,11 @@ extern unsigned int kobjsize(const void *objp);#define VM_NOHUGEPAGE 0x40000000/* MADV_NOHUGEPAGE marked this vma */ #define VM_MERGEABLE 0x80000000/* KSM may merge identical pages */ +#ifdef CONFIG_64BIT +/* VM is sealed, in vm_flags */ +#define VM_SEALED _BITUL(63) +#endif +#ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS #define VM_HIGH_ARCH_BIT_0 32/* bit only usable on 64-bit architectures */ #define VM_HIGH_ARCH_BIT_1 33/* bit only usable on 64-bit architectures */
mm/internal.h +0 -5
@@ -1509,11 +1509,6 @@ void __meminit __init_single_page(struct page *page, unsigned long pfn,unsigned long shrink_slab (gfp_t gfp_mask,int nid,struct mem_cgroup *memcg,int priority); -#ifdef CONFIG_64BIT -/* VM is sealed, in vm_flags */ -#define VM_SEALED _BITUL(63) -#endif -#ifdef CONFIG_64BIT static inline int can_do_mseal (unsigned long flags) {
Signature · 1 line
2.45.2.627.g7a2c4fd464-goog
Jann Horn
reviewerRe: [PATCH v1 1/1] /proc/pid/smaps: add mseal info for vma
Hi!
Quoted 15 lines · On Fri, Jun 14, 2024 at 8:24 PM <[email protected]> wrote:
Add sp in
/proc/pid/smapsto indicate vma is sealedSigned-off-by Jeff Xu <[email protected]>--- Documentation/filesystems/proc.rst | 1 + fs/proc/task_mmu.c | 3 +++ include/linux/mm.h | 5 +++++ mm/internal.h | 5 ----- 4 files changed, 9 insertions(+), 5 deletions(-)Documentation/filesystems/proc.rst +0
-0
Documentation/filesystems/proc.rst encoded manner. The codes are the following: · line 574
Quoted 4 lines
Documentation/filesystems/proc.rst +1
-0@@ -571,6 +571,7 @@ encoded manner. The codes are the following: um userfaultfd missing tracking uw userfaultfd wr-protect tracking ss shadow stack page + sp sealed page
Nit: Why "page"? The sealing is a property of the VMA, not of the pages mapped into it. Maybe "sealed area" and an abbreviation like "sl" would make sense?
Quoted 6 lines
include/linux/mm.h +0
-0@@ -314,6 +314,11 @@ extern unsigned int kobjsize(const void *objp);#define VM_NOHUGEPAGE 0x40000000/* MADV_NOHUGEPAGE marked this vma */
include/linux/mm.h extern unsigned int kobjsize(const void *objp); · line 324
Quoted 10 lines
include/linux/mm.h +5
-0#define VM_MERGEABLE 0x80000000/* KSM may merge identical pages */ +#ifdef CONFIG_64BIT +/* VM is sealed, in vm_flags */ +#define VM_SEALED _BITUL(63) +#endif +#ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS #define VM_HIGH_ARCH_BIT_0 32/* bit only usable on 64-bit architectures */ #define VM_HIGH_ARCH_BIT_1 33/* bit only usable on 64-bit architectures */
Other 64-bit flags are defined further down; maybe it would make sense to move this definition below the definition of VM_ALLOW_ANY_UNCACHED, so that the definitions are sorted by the number of the bit?
Re: [PATCH v1 1/1] /proc/pid/smaps: add mseal info for vma
Quoted 36 lines · Jann Horn
Hi!
Quoted 15 lines · On Fri, Jun 14, 2024 at 8:24 PM <[email protected]> wrote:
Add sp in
/proc/pid/smapsto indicate vma is sealedSigned-off-by Jeff Xu <[email protected]>--- Documentation/filesystems/proc.rst | 1 + fs/proc/task_mmu.c | 3 +++ include/linux/mm.h | 5 +++++ mm/internal.h | 5 ----- 4 files changed, 9 insertions(+), 5 deletions(-)Documentation/filesystems/proc.rst +0
-0Documentation/filesystems/proc.rst encoded manner. The codes are the following: · line 574
Quoted 4 lines
Documentation/filesystems/proc.rst +1
-0@@ -571,6 +571,7 @@ encoded manner. The codes are the following: um userfaultfd missing tracking uw userfaultfd wr-protect tracking ss shadow stack page + sp sealed pageNit: Why "page"? The sealing is a property of the VMA, not of the pages mapped into it. Maybe "sealed area" and an abbreviation like "sl" would make sense?
Quoted 8 lines
include/linux/mm.h +0
-0@@ -314,6 +314,11 @@ extern unsigned int kobjsize(const void *objp);#define VM_NOHUGEPAGE 0x40000000/* MADV_NOHUGEPAGE marked this vma */ #define VM_MERGEABLE 0x80000000/* KSM may merge identical pages */
Quoted 12 lines
include/linux/mm.h extern unsigned int kobjsize(const void *objp); · line 324
Quoted 8 lines
include/linux/mm.h +5
-0+#ifdef CONFIG_64BIT +/* VM is sealed, in vm_flags */ +#define VM_SEALED _BITUL(63) +#endif +#ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS #define VM_HIGH_ARCH_BIT_0 32/* bit only usable on 64-bit architectures */ #define VM_HIGH_ARCH_BIT_1 33/* bit only usable on 64-bit architectures */ Other 64-bit flags are defined further down; maybe it would make sense to move this definition below the definition of
VM_ALLOW_ANY_UNCACHED, so that the definitions are sorted by the number of the bit?
Sure. I will update.
Thanks!
-Jeff
Re: [PATCH v1 1/1] /proc/pid/smaps: add mseal info for vma
In reply to Jann HornQuoted 14 lines · Jann Horn
Hi!
Quoted 10 lines · On Fri, Jun 14, 2024 at 8:24 PM <[email protected]> wrote:
Add sp in
/proc/pid/smapsto indicate vma is sealedSigned-off-by Jeff Xu <[email protected]>--- Documentation/filesystems/proc.rst | 1 + fs/proc/task_mmu.c | 3 +++ include/linux/mm.h | 5 +++++ mm/internal.h | 5 ----- 4 files changed, 9 insertions(+), 5 deletions(-)
Quoted 14 lines
Documentation/filesystems/proc.rst encoded manner. The codes are the following: · line 574
Quoted 9 lines
Documentation/filesystems/proc.rst +1
-0@@ -571,6 +571,7 @@ encoded manner. The codes are the following: um userfaultfd missing tracking uw userfaultfd wr-protect tracking ss shadow stack page + sp sealed pageNit: Why "page"? The sealing is a property of the VMA, not of the pages mapped into it. Maybe "sealed area" and an abbreviation like "sl" would make sense?
ok. Maybe just sealed for short:
sl "sealed"
Thanks
-Jeff