Skip to contentSkip to conversation

virtio tests need veth?

TEST Jakub Kicinski 3 participants 8 messages Jun 17, 2024 – Jun 19, 2024

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore
#1 lore raw
Quoted 6 lines · Mon, Jun 17, 2024 at 04:26:14PM CEST, [email protected] wrote:

Hi Jiri!

I finally hooked up the virtio tests to NIPA.
Looks like they are missing CONFIG options?

https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/1-basic-features-sh/stdout

Checking that out. Apparently sole config is really missing. Also, looks like for some reason veth is used instead of virtio_net. Where do you run this command? Do you have 2 virtio_net interfaces looped back together on the system?

#2 lore raw
Quoted 6 lines · Tue, Jun 18, 2024 at 08:36:13AM CEST, [email protected] wrote:
Quoted 5 lines · Mon, Jun 17, 2024 at 04:26:14PM CEST, [email protected] wrote:

Hi Jiri!

I finally hooked up the virtio tests to NIPA.
Looks like they are missing CONFIG options?

Quoted 6 lines
Quoted 1 line

https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/1-basic-features-sh/stdout

Checking that out. Apparently sole config is really missing. Also, looks like for some reason veth is used instead of virtio_net. Where do you run this command? Do you have 2 virtio_net interfaces looped back together on the system?

I guess you have custom tools/testing/selftests/net/forwarding/forwarding.config. Can you send it here?

Quoted 1 line
#7 lore raw
In reply to Jakub Kicinski
Quoted 4 lines · Mon, Jun 17, 2024 at 04:26:14PM CEST, [email protected] wrote:

Hi Jiri!

I finally hooked up the virtio tests to NIPA.
Looks like they are missing CONFIG options?

Could you add:
CONFIG_NET_L3_MASTER_DEV=y
CONFIG_IPV6_MULTIPLE_TABLES=y
CONFIG_NET_VRF=m
CONFIG_BPF_SYSCALL=y
CONFIG_CGROUP_BPF=y
CONFIG_IPV6=y
?

They are in tools/testing/selftests/net/forwarding/config and I assumed since virtio tests depend on net/forwarding/lib.sh, it is not needed to repeat the config options in tools/testing/selftests/drivers/net/virtio_net/config Apparently that was false assumption.

Will send patch adding it once you confirm it helped if that is okay with you .

Thanks!

#3 lore raw
In reply to Jiri Pirko

Hi Jiri,

Quoted 9 lines · Jiri Pirko
Quoted 8 lines · Tue, Jun 18, 2024 at 08:36:13AM CEST, [email protected] wrote:
Quoted 6 lines · Mon, Jun 17, 2024 at 04:26:14PM CEST, [email protected] wrote:

Hi Jiri!

I finally hooked up the virtio tests to NIPA.
Looks like they are missing CONFIG options?

https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/1-basic-features-sh/stdout

Quoted 8 lines
Quoted 4 lines

Checking that out. Apparently sole config is really missing. Also, looks like for some reason veth is used instead of virtio_net. Where do you run this command? Do you have 2 virtio_net interfaces looped back together on the system?

I guess you have custom tools/testing/selftests/net/forwarding/forwarding.config. Can you send it here?

According to the logs from the parent directory [1], the "build/stdout" file shows that only this config file has been used:

tools/testing/selftests/drivers/net/virtio_net/config

(see the 'vng -b' command)

Quoted 6 lines

CONFIG_NET_L3_MASTER_DEV=y
CONFIG_IPV6_MULTIPLE_TABLES=y
CONFIG_NET_VRF=m
CONFIG_BPF_SYSCALL=y
CONFIG_CGROUP_BPF=y
CONFIG_IPV6=y

The "config" file from [1] seems to indicate that all these kconfig are missing, except the BPF ones.

Note that if you want to check locally, virtme-ng helps to reproduce the issues reported by the CI, see [2].

[1] https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/
[2]
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style

Cheers,
Matt

Signature · 1 line
Sponsored by the NGI0 Core fund.
#4 lore raw
Quoted 35 lines · Tue, Jun 18, 2024 at 10:21:54AM CEST, [email protected] wrote:

Hi Jiri,

Quoted 9 lines · Jiri Pirko
Quoted 8 lines · Tue, Jun 18, 2024 at 08:36:13AM CEST, [email protected] wrote:
Quoted 6 lines · Mon, Jun 17, 2024 at 04:26:14PM CEST, [email protected] wrote:

Hi Jiri!

I finally hooked up the virtio tests to NIPA.
Looks like they are missing CONFIG options?

https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/1-basic-features-sh/stdout

Quoted 8 lines
Quoted 4 lines

Checking that out. Apparently sole config is really missing. Also, looks like for some reason veth is used instead of virtio_net. Where do you run this command? Do you have 2 virtio_net interfaces looped back together on the system?

I guess you have custom tools/testing/selftests/net/forwarding/forwarding.config. Can you send it here?

According to the logs from the parent directory [1], the "build/stdout" file shows that only this config file has been used:

tools/testing/selftests/drivers/net/virtio_net/config

(see the 'vng -b' command)

Quoted 6 lines

CONFIG_NET_L3_MASTER_DEV=y
CONFIG_IPV6_MULTIPLE_TABLES=y
CONFIG_NET_VRF=m
CONFIG_BPF_SYSCALL=y
CONFIG_CGROUP_BPF=y
CONFIG_IPV6=y

Quoted 7 lines

The "config" file from [1] seems to indicate that all these kconfig are missing, except the BPF ones.

Note that if you want to check locally, virtme-ng helps to reproduce the issues reported by the CI, see [2].

[1] https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/

Hmm, looking here, I see only command outputs. Would be actually good to see what commands were run to produce those outputs.

Quoted 8 lines

[2]
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style

Cheers,
Matt

Signature · 1 line
Sponsored by the NGI0 Core fund.
#5 lore raw
Quoted 39 lines · Jiri Pirko
Quoted 38 lines · Tue, Jun 18, 2024 at 10:21:54AM CEST, [email protected] wrote:

Hi Jiri,

Quoted 9 lines · Jiri Pirko
Quoted 8 lines · Tue, Jun 18, 2024 at 08:36:13AM CEST, [email protected] wrote:
Quoted 6 lines · Mon, Jun 17, 2024 at 04:26:14PM CEST, [email protected] wrote:

Hi Jiri!

I finally hooked up the virtio tests to NIPA.
Looks like they are missing CONFIG options?

https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/1-basic-features-sh/stdout

Quoted 8 lines
Quoted 4 lines

Checking that out. Apparently sole config is really missing. Also, looks like for some reason veth is used instead of virtio_net. Where do you run this command? Do you have 2 virtio_net interfaces looped back together on the system?

I guess you have custom tools/testing/selftests/net/forwarding/forwarding.config. Can you send it here?

According to the logs from the parent directory [1], the "build/stdout" file shows that only this config file has been used:

tools/testing/selftests/drivers/net/virtio_net/config

(see the 'vng -b' command)

Quoted 6 lines

CONFIG_NET_L3_MASTER_DEV=y
CONFIG_IPV6_MULTIPLE_TABLES=y
CONFIG_NET_VRF=m
CONFIG_BPF_SYSCALL=y
CONFIG_CGROUP_BPF=y
CONFIG_IPV6=y

The "config" file from [1] seems to indicate that all these kconfig are missing, except the BPF ones.

Quoted 7 lines
Quoted 4 lines

Note that if you want to check locally, virtme-ng helps to reproduce the issues reported by the CI, see [2].

[1] https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/

Hmm, looking here, I see only command outputs. Would be actually good to see what commands were run to produce those outputs.

I think only the command to launch the VM is missing.

- In the build logs [1], where we can see 4 commands:

Quoted 2 lines

TREE CMD: make mrproper
TREE CMD: vng -v -b -f

tools/testing/selftests/drivers/net/virtio_net/config

Quoted 2 lines

TREE CMD: make headers
TREE CMD: make -C tools/testing/selftests/drivers/net/virtio_net/

- In the VM logs [2], we don't see the command to start it. I guess it
is supposed to be closed to what is described in the wiki [3]. At the end, we see the env vars that are set in the VM.

- In the test logs [4], we can see the 'make' command at the first line.

I can look at adding the command to start the VM. Do you see anything else missing?

[1]
https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/build/stdout
[2]
https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/vm-start-thr0-0/stdout
[3]
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style#how-to-run
[4]
https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/1-basic-features-sh/stdout

Cheers,
Matt

Signature · 1 line
Sponsored by the NGI0 Core fund.
#6 lore raw
Quoted 57 lines · Tue, Jun 18, 2024 at 02:57:28PM CEST, [email protected] wrote:
Quoted 39 lines · Jiri Pirko
Quoted 38 lines · Tue, Jun 18, 2024 at 10:21:54AM CEST, [email protected] wrote:

Hi Jiri,

Quoted 9 lines · Jiri Pirko
Quoted 8 lines · Tue, Jun 18, 2024 at 08:36:13AM CEST, [email protected] wrote:
Quoted 6 lines · Mon, Jun 17, 2024 at 04:26:14PM CEST, [email protected] wrote:

Hi Jiri!

I finally hooked up the virtio tests to NIPA.
Looks like they are missing CONFIG options?

https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/1-basic-features-sh/stdout

Quoted 8 lines
Quoted 4 lines

Checking that out. Apparently sole config is really missing. Also, looks like for some reason veth is used instead of virtio_net. Where do you run this command? Do you have 2 virtio_net interfaces looped back together on the system?

I guess you have custom tools/testing/selftests/net/forwarding/forwarding.config. Can you send it here?

According to the logs from the parent directory [1], the "build/stdout" file shows that only this config file has been used:

tools/testing/selftests/drivers/net/virtio_net/config

(see the 'vng -b' command)

Quoted 6 lines

CONFIG_NET_L3_MASTER_DEV=y
CONFIG_IPV6_MULTIPLE_TABLES=y
CONFIG_NET_VRF=m
CONFIG_BPF_SYSCALL=y
CONFIG_CGROUP_BPF=y
CONFIG_IPV6=y

The "config" file from [1] seems to indicate that all these kconfig are missing, except the BPF ones.

Quoted 7 lines
Quoted 4 lines

Note that if you want to check locally, virtme-ng helps to reproduce the issues reported by the CI, see [2].

[1] https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/

Hmm, looking here, I see only command outputs. Would be actually good to see what commands were run to produce those outputs.

I think only the command to launch the VM is missing.

- In the build logs [1], where we can see 4 commands:

Quoted 2 lines

TREE CMD: make mrproper
TREE CMD: vng -v -b -f

tools/testing/selftests/drivers/net/virtio_net/config

Quoted 2 lines

TREE CMD: make headers
TREE CMD: make -C tools/testing/selftests/drivers/net/virtio_net/

Quoted 8 lines

- In the VM logs [2], we don't see the command to start it. I guess it is supposed to be closed to what is described in the wiki [3]. At the end, we see the env vars that are set in the VM.

- In the test logs [4], we can see the 'make' command at the first line.

I can look at adding the command to start the VM. Do you see anything else missing?

After your patch to add vm run command into stdout, I see all.

I tested the missing config options added locally, the test runs clearly after that.

I will send patch to fix this in a minute.

Thanks!

Quoted 15 lines

[1]
https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/build/stdout
[2]
https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/vm-start-thr0-0/stdout
[3]
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style#how-to-run
[4]
https://netdev-3.bots.linux.dev/vmksft-virtio/results/643761/1-basic-features-sh/stdout

Cheers,
Matt

Signature · 1 line
Sponsored by the NGI0 Core fund.