xfile: fix missing error unlock in xfile_fcb_find
PATCH 1/1 xfile: fix missing error unlock in xfile_fcb_find
From: Darrick J. Wong <[email protected]>
Fix a missing mutex pthread_mutex_unlock and uninitialized return value in xfile_fcb_find.
Coverity-id: 1604113
Coverity-id: 1604099
Signed-off-by Darrick J. Wong <[email protected]>
--- libxfs/xfile.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
libxfs/xfile.c +3 -3
@@ -179,7 +179,7 @@ xfile_fcb_find( {struct xfile_fcb *fcb;int ret; -int error; +int error =0 ;/* No maximum range means that the caller gets a private memfd. */ if (maxbytes ==0 ) {
@@ -222,13 +222,13 @@ xfile_fcb_find(/* Otherwise, open a new memfd and add it to our list. */ error =xfile_fcb_create (description, &fcb);if (error) -return error; + goto out_unlock; ret =ftruncate (fcb->fd, maxbytes);if (ret) { error = -errno;xfile_fcb_irele (fcb,0 , maxbytes); -return error; + goto out_unlock; }list_add_tail (&fcb->fcb_list, &fcb_list);
Quoted 8 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Fix a missing mutex
pthread_mutex_unlockand uninitialized return value inxfile_fcb_find.Coverity-id: 1604113
Coverity-id: 1604099Signed-off-by Darrick J. Wong <[email protected]>
Reviewed-by Carlos Maiolino <[email protected]>
Quoted 33 lines
--- libxfs/xfile.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)libxfs/xfile.c +3
-3@@ -179,7 +179,7 @@ xfile_fcb_find( {struct xfile_fcb *fcb;int ret; -int error; +int error =0 ;/* No maximum range means that the caller gets a private memfd. */ if (maxbytes ==0 ) {@@ -222,13 +222,13 @@ xfile_fcb_find(/* Otherwise, open a new memfd and add it to our list. */ error =xfile_fcb_create (description, &fcb);if (error) -return error; + goto out_unlock; ret =ftruncate (fcb->fd, maxbytes);if (ret) { error = -errno;xfile_fcb_irele (fcb,0 , maxbytes); -return error; + goto out_unlock; }list_add_tail (&fcb->fcb_list, &fcb_list);
Looks good:
Reviewed-by Christoph Hellwig <[email protected]>