Adjust Tegra boot order
cover Adjust Tegra boot order
This ensures that the device can boot from a USB device prior to MMC. Useful cases are when installing a new OS from USB while MMC still has a working OS configuration or if the OS configuration is broken in late boot stages (kernel boots but the system does not start).
Svyatoslav Ryhel (1):
include: configs: tegra-common-post: make usb first boot target
include/configs/tegra-common-post.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.43.0
PATCH 1/1 include: configs: tegra-common-post: make usb first boot target
This ensures that the device can boot from a USB device prior to MMC. Useful cases are when installing a new OS from USB while MMC still has a working OS configuration or if the OS configuration is broken in late boot stages (kernel boots but the system does not start).
--- include/configs/tegra-common-post.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/tegra-common-post.h +1 -1
@@ -7,7 +7,7 @@#ifndef __TEGRA_COMMON_POST_H#define __TEGRA_COMMON_POST_H -#define BOOT_TARGETS "mmc1 mmc0 usb pxe dhcp" +#define BOOT_TARGETS "usb mmc1 mmc0 pxe dhcp"#ifdef CONFIG_TEGRA_KEYBOARD #define STDIN_KBD_KBC ",tegra-kbc"
Signature · 1 line
2.43.0
Re: [PATCH v1 1/1] include: configs: tegra-common-post: make usb first boot target
Quoted 9 lines · Svyatoslav Ryhel
This ensures that the device can boot from a USB device prior to MMC. Useful cases are when installing a new OS from USB while MMC still has a working OS configuration or if the OS configuration is broken in late boot stages (kernel boots but the system does not start).
Signed-off-by Svyatoslav Ryhel <[email protected]>--- include/configs/tegra-common-post.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
What's the implication of this if no USB mass storage device is found? How does this behave when USB cannot be read or booting from it doesn't work?
I vaguely recall that boot order doesn't always proceed, though admittedly I haven't tested all of these edge-cases in a long time.
Thierry
Re: [PATCH v1 1/1] include: configs: tegra-common-post: make usb first boot target
18 червня 2024 р. 15:23:09 GMT+03:00, Thierry Reding <[email protected]> написав(-ла):
Quoted 11 lines · Svyatoslav Ryhel
Quoted 9 lines
This ensures that the device can boot from a USB device prior to MMC. Useful cases are when installing a new OS from USB while MMC still has a working OS configuration or if the OS configuration is broken in late boot stages (kernel boots but the system does not start).
Signed-off-by Svyatoslav Ryhel <[email protected]>--- include/configs/tegra-common-post.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines
What's the implication of this if no USB mass storage device is found? How does this behave when USB cannot be read or booting from it doesn't work?
I vaguely recall that boot order doesn't always proceed, though admittedly I haven't tested all of these edge-cases in a long time.
Thierry
If no USB mass storage is found bootflow will continue with the next device in the list (mmc1) with co-responding info that booting from usb failed. I have tested this on lg p895 which has only mmc0 and with asus transformers which have usb, mmc0 and mmc1 in all possible configurations. I did not have booting issues whatsoever. ATM, transformers use boot order which I have proposed in this commit.
Best regards,
Svyatoslav R.
Re: [PATCH v1 1/1] include: configs: tegra-common-post: make usb first boot target
вт, 18 черв. 2024 р. о 17:16 Svyatoslav <[email protected]> пише:
Quoted 32 lines
18 червня 2024 р. 15:23:09 GMT+03:00, Thierry Reding <[email protected]> написав(-ла):
Quoted 11 lines · Svyatoslav Ryhel
Quoted 9 lines
This ensures that the device can boot from a USB device prior to MMC. Useful cases are when installing a new OS from USB while MMC still has a working OS configuration or if the OS configuration is broken in late boot stages (kernel boots but the system does not start).
Signed-off-by Svyatoslav Ryhel <[email protected]>--- include/configs/tegra-common-post.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 8 lines
What's the implication of this if no USB mass storage device is found? How does this behave when USB cannot be read or booting from it doesn't work?
I vaguely recall that boot order doesn't always proceed, though admittedly I haven't tested all of these edge-cases in a long time.
Thierry
If no USB mass storage is found bootflow will continue with the next device in the list (mmc1) with co-responding info that booting from usb failed. I have tested this on lg p895 which has only mmc0 and with asus transformers which have usb, mmc0 and mmc1 in all possible configurations. I did not have booting issues whatsoever. ATM, transformers use boot order which I have proposed in this commit.
Quoted 2 lines
Best regards,
Svyatoslav R.
Thierry,
Since you have not responded to my statement above I assume that you are fine with applying this change. In case you have any objections please answer as soon as you can since I am planning to include it into merge request for the next merge window.
Best regards,
Svyatoslav R.
Re: [PATCH v1 1/1] include: configs: tegra-common-post: make usb first boot target
Quoted 36 lines · Svyatoslav Ryhel
вт, 18 черв. 2024 р. о 17:16 Svyatoslav <[email protected]> пише:
Quoted 32 lines
18 червня 2024 р. 15:23:09 GMT+03:00, Thierry Reding <[email protected]> написав(-ла):
Quoted 11 lines · Svyatoslav Ryhel
Quoted 9 lines
This ensures that the device can boot from a USB device prior to MMC. Useful cases are when installing a new OS from USB while MMC still has a working OS configuration or if the OS configuration is broken in late boot stages (kernel boots but the system does not start).
Signed-off-by Svyatoslav Ryhel <[email protected]>--- include/configs/tegra-common-post.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 8 lines
What's the implication of this if no USB mass storage device is found? How does this behave when USB cannot be read or booting from it doesn't work?
I vaguely recall that boot order doesn't always proceed, though admittedly I haven't tested all of these edge-cases in a long time.
Thierry
If no USB mass storage is found bootflow will continue with the next device in the list (mmc1) with co-responding info that booting from usb failed. I have tested this on lg p895 which has only mmc0 and with asus transformers which have usb, mmc0 and mmc1 in all possible configurations. I did not have booting issues whatsoever. ATM, transformers use boot order which I have proposed in this commit.
Quoted 2 lines
Best regards,
Svyatoslav R.
Quoted 6 lines
Thierry,
Since you have not responded to my statement above I assume that you are fine with applying this change. In case you have any objections please answer as soon as you can since I am planning to include it into merge request for the next merge window.
Sorry, I had meant to reply to this. I have no objections if this was properly tested and there's a reasonable fallback that works.
Thierry
Re: [PATCH v1 1/1] include: configs: tegra-common-post: make usb first boot target
чт, 27 черв. 2024 р. о 14:36 Thierry Reding <[email protected]> пише:
Quoted 40 lines · Svyatoslav Ryhel
Quoted 38 lines
вт, 18 черв. 2024 р. о 17:16 Svyatoslav <[email protected]> пише:
Quoted 32 lines
18 червня 2024 р. 15:23:09 GMT+03:00, Thierry Reding <[email protected]> написав(-ла):
Quoted 11 lines · Svyatoslav Ryhel
Quoted 9 lines
This ensures that the device can boot from a USB device prior to MMC. Useful cases are when installing a new OS from USB while MMC still has a working OS configuration or if the OS configuration is broken in late boot stages (kernel boots but the system does not start).
Signed-off-by Svyatoslav Ryhel <[email protected]>--- include/configs/tegra-common-post.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 8 lines
What's the implication of this if no USB mass storage device is found? How does this behave when USB cannot be read or booting from it doesn't work?
I vaguely recall that boot order doesn't always proceed, though admittedly I haven't tested all of these edge-cases in a long time.
Thierry
If no USB mass storage is found bootflow will continue with the next device in the list (mmc1) with co-responding info that booting from usb failed. I have tested this on lg p895 which has only mmc0 and with asus transformers which have usb, mmc0 and mmc1 in all possible configurations. I did not have booting issues whatsoever. ATM, transformers use boot order which I have proposed in this commit.
Quoted 2 lines
Best regards,
Svyatoslav R.Thierry,
Quoted 8 lines
Quoted 4 lines
Since you have not responded to my statement above I assume that you are fine with applying this change. In case you have any objections please answer as soon as you can since I am planning to include it into merge request for the next merge window.
Sorry, I had meant to reply to this. I have no objections if this was properly tested and there's a reasonable fallback that works.
Np. Thanks for feedback!
Quoted 1 line
Thierry