Skip to contentSkip to conversation

linux-torvalds-next: use tag

PATCH In review Trevor Woerner 4 participants 7 messages Jun 18, 2024 – Jun 19, 2024

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 linux-torvalds-next: use tag

Use the tag name specifically; note that it is no longer reachable from any branch.

---
 recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
recipes-kernel/linux/linux-torvalds-next_git.bb +2 -3
index 9a95eb5bc4d8..1369ba1d707f 100644
@@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$"
 COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3"
 
 LINUX_VERSION = "6.10-rc3"
+KERNEL_VERSION_SANITY_SKIP = "1"
 PV = "${LINUX_VERSION}+git${SRCPV}"
 SRC_URI = " \
-	git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \
+	git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \
 	file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \
 	"
-# this is tag 'next-20240611'
-SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68"
 
 inherit kernel
 inherit kernel-yocto
Signature · 1 line
2.44.0.478.g7774cfed6261
Reviewed-by on v2 1/1
#1 lore raw

Hi Trevor,

Quoted 16 lines · Trevor Woerner via lists.yoctoproject.org

Use the tag name specifically; note that it is no longer reachable from any branch.

---
  recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
recipes-kernel/linux/linux-torvalds-next_git.bb +0 -0
index 9a95eb5bc4d8..1369ba1d707f 100644
@@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$"
  COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3"
 
  LINUX_VERSION = "6.10-rc3"

recipes-kernel/linux/linux-torvalds-next_git.bb COMPATIBLE_MACHINE = "^$" · line 19

Quoted 10 lines
recipes-kernel/linux/linux-torvalds-next_git.bb +2 -3
+KERNEL_VERSION_SANITY_SKIP = "1"
  PV = "${LINUX_VERSION}+git${SRCPV}"
  SRC_URI = " \
-	git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \
+	git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \
  	file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \
  	"
-# this is tag 'next-20240611'
-SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68"
 

Thanks!
Quentin

#2 lore raw

Why is this better? Now bitbake will always run git ls-remote to covert next-20240611 into a957267fa7e9159d3d2ee1421359ebf228570c68 and break parsing this recipe without network access.

Quoted 46 lines · Quentin Schulz via lists.yoctoproject.org

Hi Trevor,

Quoted 16 lines · Trevor Woerner via lists.yoctoproject.org

Use the tag name specifically; note that it is no longer reachable from any branch.

---
  recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
recipes-kernel/linux/linux-torvalds-next_git.bb +0 -0
index 9a95eb5bc4d8..1369ba1d707f 100644
@@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$"
  COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3"
 
  LINUX_VERSION = "6.10-rc3"

recipes-kernel/linux/linux-torvalds-next_git.bb COMPATIBLE_MACHINE = "^$" · line 19

Quoted 10 lines
recipes-kernel/linux/linux-torvalds-next_git.bb +2 -3
+KERNEL_VERSION_SANITY_SKIP = "1"
  PV = "${LINUX_VERSION}+git${SRCPV}"
  SRC_URI = " \
-     git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \
+     git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \
      file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \
      "
-# this is tag 'next-20240611'
-SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68"
 

Thanks!
Quentin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#348): https://lists.yoctoproject.org/g/yocto-patches/message/348
Mute This Topic: https://lists.yoctoproject.org/mt/106745214/3617156
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13388836/3617156/66960823/xyzzy [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw
Quoted 1 line · Martin Jansa via lists.yoctoproject.org

Why is this better?

Because in a repository like linux-next a957267fa7e9159d3d2ee1421359ebf228570c68 could be rebased out of existence? Although now that makes we wonder what would happen to the tag in this situation.

Three days ago this hash was reachable from master, now it is not. That's a lot of churn.

Quoted 3 lines

Now bitbake will always run git ls-remote to
covert next-20240611 into a957267fa7e9159d3d2ee1421359ebf228570c68 and break parsing this recipe without network access.

Is that how you're building with meta-rockchip?

Quoted 54 lines
Quoted 33 lines · Quentin Schulz via lists.yoctoproject.org

Hi Trevor,

Quoted 16 lines · Trevor Woerner via lists.yoctoproject.org

Use the tag name specifically; note that it is no longer reachable from any branch.

---
  recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
recipes-kernel/linux/linux-torvalds-next_git.bb +0 -0
index 9a95eb5bc4d8..1369ba1d707f 100644
@@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$"
  COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3"
 
  LINUX_VERSION = "6.10-rc3"

recipes-kernel/linux/linux-torvalds-next_git.bb COMPATIBLE_MACHINE = "^$" · line 19

Quoted 10 lines
recipes-kernel/linux/linux-torvalds-next_git.bb +2 -3
+KERNEL_VERSION_SANITY_SKIP = "1"
  PV = "${LINUX_VERSION}+git${SRCPV}"
  SRC_URI = " \
-     git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \
+     git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \
      file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \
      "
-# this is tag 'next-20240611'
-SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68"
 
Quoted 7 lines

Thanks!
Quentin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#351): https://lists.yoctoproject.org/g/yocto-patches/message/351
Mute This Topic: https://lists.yoctoproject.org/mt/106745214/900817
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13168745/900817/63955952/xyzzy [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#4 lore raw
Quoted 6 lines · Trevor Woerner via lists.yoctoproject.org
Quoted 1 line · Martin Jansa via lists.yoctoproject.org

Why is this better?

Because in a repository like linux-next a957267fa7e9159d3d2ee1421359ebf228570c68 could be rebased out of existence?

Really? It shouldn't disappear while the tag is still referencing it and if the tag is deleted than this change won't help you as well after first gc in upstream repo.

Quoted 11 lines

Although now that makes we wonder what would happen to the tag in this situation.

Three days ago this hash was reachable from master, now it is not. That's a lot of churn.

Quoted 3 lines

Now bitbake will always run git ls-remote to
covert next-20240611 into a957267fa7e9159d3d2ee1421359ebf228570c68 and break parsing this recipe without network access.

Is that how you're building with meta-rockchip?

I don't even use meta-rockchip, but I'm a bit allergic to ls-remote while parsing recipes I'm not using (and random build failures caused by that when there is a network glitch or something during re-parsing of the recipes), especially when I notice a change like this which IMHO made it worse.

Regards,

Quoted 59 lines
Quoted 36 lines
Quoted 33 lines · Quentin Schulz via lists.yoctoproject.org

Hi Trevor,

Quoted 16 lines · Trevor Woerner via lists.yoctoproject.org

Use the tag name specifically; note that it is no longer reachable from any branch.

---
  recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
recipes-kernel/linux/linux-torvalds-next_git.bb +0 -0
index 9a95eb5bc4d8..1369ba1d707f 100644
@@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$"
  COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3"
 
  LINUX_VERSION = "6.10-rc3"

recipes-kernel/linux/linux-torvalds-next_git.bb COMPATIBLE_MACHINE = "^$" · line 19

Quoted 10 lines
recipes-kernel/linux/linux-torvalds-next_git.bb +2 -3
+KERNEL_VERSION_SANITY_SKIP = "1"
  PV = "${LINUX_VERSION}+git${SRCPV}"
  SRC_URI = " \
-     git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \
+     git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \
      file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \
      "
-# this is tag 'next-20240611'
-SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68"
 
Quoted 12 lines
Quoted 7 lines

Thanks!
Quentin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#352): https://lists.yoctoproject.org/g/yocto-patches/message/352
Mute This Topic: https://lists.yoctoproject.org/mt/106745214/3617156
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13388836/3617156/66960823/xyzzy [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#5 lore raw
In reply to Quentin Schulz

Why use tags ? they are floating SHA1 and bitbake will need n/w access all the time.

Quoted 46 lines · Quentin Schulz via lists.yoctoproject.org

Hi Trevor,

Quoted 16 lines · Trevor Woerner via lists.yoctoproject.org

Use the tag name specifically; note that it is no longer reachable from any branch.

---
  recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
recipes-kernel/linux/linux-torvalds-next_git.bb +0 -0
index 9a95eb5bc4d8..1369ba1d707f 100644
@@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$"
  COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3"
 
  LINUX_VERSION = "6.10-rc3"

recipes-kernel/linux/linux-torvalds-next_git.bb COMPATIBLE_MACHINE = "^$" · line 19

Quoted 10 lines
recipes-kernel/linux/linux-torvalds-next_git.bb +2 -3
+KERNEL_VERSION_SANITY_SKIP = "1"
  PV = "${LINUX_VERSION}+git${SRCPV}"
  SRC_URI = " \
-     git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \
+     git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \
      file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \
      "
-# this is tag 'next-20240611'
-SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68"
 

Thanks!
Quentin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#348): https://lists.yoctoproject.org/g/yocto-patches/message/348
Mute This Topic: https://lists.yoctoproject.org/mt/106745214/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13340786/1997914/645821814/xyzzy [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-