Skip to contentSkip to conversation

kunit/usercopy: Add missing MODULE_DESCRIPTION()

PATCH In review Kees Cook 3 participants 3 messages Jun 19, 2024 – Jul 2, 2024

Subsystems (3)
Memory management Kselftest Library code
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 kunit/usercopy: Add missing MODULE_DESCRIPTION()

From: Jeff Johnson <[email protected]>

Fix warning seen with:

$ make allmodconfig && make W=1 C=1 lib/usercopy_kunit.ko
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o
Signed-off-by Jeff Johnson <[email protected]>
Signed-off-by Kees Cook <[email protected]>

---
At Jeff's reminder, I've split this out of:
https://lore.kernel.org/all/[email protected]/
since the file got renamed.
---
Cc: Shuah Khan <[email protected]>
Cc: Jeff Johnson <[email protected]>
Cc: Brendan Higgins <[email protected]>
Cc: David Gow <[email protected]>
Cc: Rae Moar <[email protected]>
Cc: "Gustavo A. R. Silva" <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 lib/usercopy_kunit.c | 1 +
 1 file changed, 1 insertion(+)
lib/usercopy_kunit.c +1 -0
index e819561a540d..77fa00a13df7 100644
@@ -331,4 +331,5 @@ static struct kunit_suite usercopy_test_suite = {
 
 kunit_test_suites(&usercopy_test_suite);
 MODULE_AUTHOR("Kees Cook <[email protected]>");
+MODULE_DESCRIPTION("Kernel module for testing copy_to/from_user infrastructure");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Kees Cook

From: Jeff Johnson <[email protected]>

Fix warning seen with:

$ make allmodconfig && make W=1 C=1 lib/usercopy_kunit.ko
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o
Signed-off-by Jeff Johnson <[email protected]>
Signed-off-by Kees Cook <[email protected]>

Hi!

This looks good to me.

Reviewed-by Rae Moar <[email protected]>

Thanks!
-Rae

Quoted 33 lines

---
At Jeff's reminder, I've split this out of:
https://lore.kernel.org/all/[email protected]/
since the file got renamed.
---
Cc: Shuah Khan <[email protected]>
Cc: Jeff Johnson <[email protected]>
Cc: Brendan Higgins <[email protected]>
Cc: David Gow <[email protected]>
Cc: Rae Moar <[email protected]>
Cc: "Gustavo A. R. Silva" <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 lib/usercopy_kunit.c | 1 +
 1 file changed, 1 insertion(+)
lib/usercopy_kunit.c +1 -1
index e819561a540d..77fa00a13df7 100644
@@ -331,4 +331,5 @@ static struct kunit_suite usercopy_test_suite = {
 
 kunit_test_suites(&usercopy_test_suite);
 MODULE_AUTHOR("Kees Cook <[email protected]>");
+MODULE_DESCRIPTION("Kernel module for testing copy_to/from_user infrastructure");
 MODULE_LICENSE("GPL");
--

2.34.1

Reviewed-by on v1 1/1
#2 lore raw
In reply to Kees Cook
Quoted 19 lines · Kees Cook

From: Jeff Johnson <[email protected]>

Fix warning seen with:

$ make allmodconfig && make W=1 C=1 lib/usercopy_kunit.ko
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o
Signed-off-by Jeff Johnson <[email protected]>
Signed-off-by Kees Cook <[email protected]>

---
At Jeff's reminder, I've split this out of:
https://lore.kernel.org/all/[email protected]/
since the file got renamed.
---
Cc: Shuah Khan <[email protected]>
Cc: Jeff Johnson <[email protected]>
Cc: Brendan Higgins <[email protected]>
Cc: David Gow <[email protected]>

Quoted 8 lines

Cc: Rae Moar <[email protected]>
Cc: "Gustavo A. R. Silva" <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---

Reviewed-by David Gow <[email protected]>

Cheers,
-- David