Skip to contentSkip to conversation

drivers/net/pse-pd/pd692x0.c:1193:undefined reference to `firmware_upload_unregister'

DISCUSSION kernel test robot 1 participant 1 message Jun 19, 2024

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e5b3efbe1ab1793bb49ae07d56d0973267e65112
commit: 9a993845189004a923b78d0df643e47970147337 net: pse-pd: Add PD692x0 PSE controller driver
date:   9 weeks ago
config: i386-randconfig-006-20240620 (https://download.01.org/0day-ci/archive/20240620/[email protected]/config)
compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240620/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

ld: drivers/net/pse-pd/pd692x0.o: in function `pd692x0_i2c_remove':

>> drivers/net/pse-pd/pd692x0.c:1193:(.text+0x26): undefined reference to `firmware_upload_unregister'
   ld: drivers/net/pse-pd/pd692x0.o: in function `pd692x0_i2c_probe':
>> drivers/net/pse-pd/pd692x0.c:1179:(.text+0x1148): undefined reference to `firmware_upload_register'

vim +1193 drivers/net/pse-pd/pd692x0.c

1108
1109 static int pd692x0_i2c_probe(struct i2c_client *client)
1110 {
1111 struct pd692x0_msg msg, buf = {0}, zero = {0};
1112 struct device *dev = &client->dev;
1113 struct pd692x0_msg_ver ver;
1114 struct pd692x0_priv *priv;
1115 struct fw_upload *fwl;
1116 int ret;
1117
1118 if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
1119 dev_err(dev, "i2c check functionality failed\n");
1120 return -ENXIO;
1121 }
1122
1123 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
1124 if (!priv)
1125 return -ENOMEM;
1126
1127 priv->client = client;
1128 i2c_set_clientdata(client, priv);
1129
1130 ret = i2c_master_recv(client, (u8 *)&buf, sizeof(buf));
1131 if (ret != sizeof(buf)) {
1132 dev_err(dev, "Failed to get device status\n");
1133 return -EIO;
1134 }
1135
1136 /* Probe has been already run and the status dumped */
1137 if (!memcmp(&buf, &zero, sizeof(buf))) {
1138 /* Ask again the controller status */
1139 msg = pd692x0_msg_template_list[PD692X0_MSG_GET_SYS_STATUS];
1140 ret = pd692x0_sendrecv_msg(priv, &msg, &buf);
1141 if (ret < 0) {
1142 dev_err(dev, "Failed to get device status\n");
1143 return ret;
1144 }
1145 }
1146
1147 if (buf.key != 0x03 || buf.sub[0] & 0x01) {
1148 dev_err(dev, "PSE controller error\n");
1149 return -EIO;
1150 }
1151 if (buf.sub[0] & 0x02) {
1152 dev_err(dev, "PSE firmware error. Please update it.\n");
1153 priv->fw_state = PD692X0_FW_BROKEN;
1154 } else {
1155 ver = pd692x0_get_sw_version(priv);
1156 dev_info(&client->dev, "Software version %d.%02d.%d.%d\n",
1157 ver.prod, ver.maj_sw_ver, ver.min_sw_ver,
1158 ver.pa_sw_ver);
1159
1160 if (ver.maj_sw_ver < PD692X0_FW_MAJ_VER) {
1161 dev_err(dev, "Too old firmware version. Please update it\n");
1162 priv->fw_state = PD692X0_FW_NEED_UPDATE;
1163 } else {
1164 priv->fw_state = PD692X0_FW_OK;
1165 }
1166 }
1167
1168 priv->np = dev->of_node;
1169 priv->pcdev.nr_lines = PD692X0_MAX_PIS;
1170 priv->pcdev.owner = THIS_MODULE;
1171 priv->pcdev.ops = &pd692x0_ops;
1172 priv->pcdev.dev = dev;
1173 priv->pcdev.types = ETHTOOL_PSE_C33;
1174 ret = devm_pse_controller_register(dev, &priv->pcdev);
1175 if (ret)
1176 return dev_err_probe(dev, ret,
1177 "failed to register PSE controller\n");
1178

> 1179		fwl = firmware_upload_register(THIS_MODULE, dev, dev_name(dev),
  1180					       &pd692x0_fw_ops, priv);
  1181		if (IS_ERR(fwl))
  1182			return dev_err_probe(dev, PTR_ERR(fwl),
  1183					     "failed to register to the Firmware Upload API\n");
  1184		priv->fwl = fwl;
  1185	
  1186		return 0;
  1187	}
  1188	
  1189	static void pd692x0_i2c_remove(struct i2c_client *client)
  1190	{
  1191		struct pd692x0_priv *priv = i2c_get_clientdata(client);
  1192	
> 1193		firmware_upload_unregister(priv->fwl);

1194 }
1195

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki