Skip to contentSkip to conversation

Fix screen coud be filled with leftover artifacts

PATCH In review Michael Chang via Grub-devel 1 participant 2 messages Jun 20, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix screen coud be filled with leftover artifacts

A regression in grub 2.12 causes the grub screen to become cluttered with artifacts from the previous screen, whether it's the UEFI post ui, UEFI shell, or any graphical UI running before grub. this issue occurs in situations like booting grub from the UEFI shell and going straight to the rescue or command shell, causing visual discomfort.

The regression was introduced by commit 2d7c3abd8 (efi/console: Do not set text-mode until it is actually needed). To address the screen flickering issue, this commit suppresses the text-mode setting until the first output is requested. Before text-mode is set, any attempt to clear the screen has no effect. This inactive period renders the clear screen ineffective in early boot stages, potentially leaving leftover artifacts that will clutter the grub console display, as there is no guarantee there will always be a clear screen after the first output.

The issue is fixed by ensuring grub_console_cls() to work through lazy mode-setting, while also avoiding screen clearing for the hidden menu, which the flicker-free patch aims to improve.

Fixes 2d7c3abd8 (efi/console: Do not set text-mode until we actually need it)
---
 grub-core/normal/menu.c      | 7 ++++---
 grub-core/term/efi/console.c | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)
grub-core/normal/menu.c +4 -3
index 6a90e091f..f24544b27 100644
@@ -881,13 +881,14 @@ show_menu (grub_menu_t menu, int nested, int autobooted)
       if (! e)
 	continue; /* Menu is empty.  */
 
-      grub_cls ();
-
       if (auto_boot)
 	grub_menu_execute_with_fallback (menu, e, autobooted,
 					 &execution_callback, &notify_boot);
       else
-	grub_menu_execute_entry (e, 0);
+	{
+	  grub_cls ();
+	  grub_menu_execute_entry (e, 0);
+	}
       if (autobooted)
 	break;
     }
grub-core/term/efi/console.c +1 -1
index bb587f39d..258b52737 100644
@@ -432,7 +432,7 @@ grub_console_cls (struct grub_term_output *term __attribute__ ((unused)))
   grub_efi_simple_text_output_interface_t *o;
   grub_efi_int32_t orig_attr;
 
-  if (grub_efi_is_finished || text_mode != GRUB_TEXT_MODE_AVAILABLE)
+  if (grub_prepare_for_text_output (term) != GRUB_ERR_NONE)
     return;
 
   o = grub_efi_system_table->con_out;
Signature · 7 lines
2.45.2


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
#1 lore raw
Quoted 5 lines · Michael Chang

A regression in grub 2.12 causes the grub screen to become cluttered with artifacts from the previous screen, whether it's the UEFI post ui, UEFI shell, or any graphical UI running before grub. this issue occurs in situations like booting grub from the UEFI shell and going straight to the rescue or command shell, causing visual discomfort.

Here the captured screen to the issue happened:

https://paste.opensuse.org/pastes/cbef185ed55c

Thanks,
Michael

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel