Skip to contentSkip to conversation

MAINTAINERS: drm : vc4: Add Raspberry Pi as maintainers

PATCH Superseded Dave Stevenson 2 participants 5 messages Jun 20, 2024 – Jun 21, 2024

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 MAINTAINERS: drm : vc4: Add Raspberry Pi as maintainers

Add myself and our kernel maintenance list as maintainers for VC4 alongside Maxime.

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index d1566c647a50..b6dd628d5bc6 100644
@@ -7520,6 +7520,8 @@ F:	include/uapi/drm/v3d_drm.h
 
 DRM DRIVERS FOR VC4
 M:	Maxime Ripard <[email protected]>
+M:	Dave Stevenson <[email protected]>
+M:	Raspberry Pi Kernel Maintenance <[email protected]>
 S:	Supported
 T:	git git://github.com/anholt/linux
 T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/2 MAINTAINERS: drm : vc4: Drop Emma's tree

Emma stepped back from VC4 maintenance a while ago, and all patches are now merged through drm-misc.

Drop Emma's tree from MAINTAINERS.

---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)
MAINTAINERS +0 -1
index b6dd628d5bc6..3deb52366be1 100644
@@ -7523,7 +7523,6 @@ M:	Maxime Ripard <[email protected]>
 M:	Dave Stevenson <[email protected]>
 M:	Raspberry Pi Kernel Maintenance <[email protected]>
 S:	Supported
-T:	git git://github.com/anholt/linux
 T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
 F:	Documentation/devicetree/bindings/display/brcm,bcm2835-*.yaml
 F:	drivers/gpu/drm/vc4/
Signature · 1 line
2.34.1
#2 lore raw
In reply to Dave Stevenson
Quoted 13 lines · Dave Stevenson

Add myself and our kernel maintenance list as maintainers for VC4 alongside Maxime.

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index d1566c647a50..b6dd628d5bc6 100644

MAINTAINERS F: include/uapi/drm/v3d_drm.h · line 7524

Quoted 5 lines
MAINTAINERS +2 -0
@@ -7520,6 +7520,8 @@ F:	include/uapi/drm/v3d_drm.h
 
 DRM DRIVERS FOR VC4
 M:	Maxime Ripard <[email protected]>
+M:	Dave Stevenson <[email protected]>
+M:	Raspberry Pi Kernel Maintenance <[email protected]>

I don't think we can put a list as maintainer, maintainers (and reviewers) should be explicit. We can definitely put the list as Cc with
L: though :)

Maxime

#3 lore raw
Quoted 16 lines · Maxime Ripard
Quoted 14 lines · Dave Stevenson

Add myself and our kernel maintenance list as maintainers for VC4 alongside Maxime.

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index d1566c647a50..b6dd628d5bc6 100644
@@ -7520,6 +7520,8 @@ F:      include/uapi/drm/v3d_drm.h
 
Quoted 8 lines

MAINTAINERS F: include/uapi/drm/v3d_drm.h · line 7524

Quoted 4 lines
MAINTAINERS +2 -0
 DRM DRIVERS FOR VC4
 M:   Maxime Ripard <[email protected]>
+M:   Dave Stevenson <[email protected]>
+M:   Raspberry Pi Kernel Maintenance <[email protected]>

I don't think we can put a list as maintainer, maintainers (and reviewers) should be explicit. We can definitely put the list as Cc with
L: though :)

It's been accepted for Unicam
https://github.com/torvalds/linux/blob/master/MAINTAINERS#L4178-L4183

[email protected] is listed as reviewer for a fair number of entries.

I'd prefer it to be more than just a list as it's obviously not an open list, but I don't really mind.

Dave

#4 lore raw
Quoted 26 lines · Dave Stevenson
Quoted 16 lines · Maxime Ripard
Quoted 14 lines · Dave Stevenson

Add myself and our kernel maintenance list as maintainers for VC4 alongside Maxime.

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index d1566c647a50..b6dd628d5bc6 100644
@@ -7520,6 +7520,8 @@ F:      include/uapi/drm/v3d_drm.h
 
Quoted 8 lines

MAINTAINERS F: include/uapi/drm/v3d_drm.h · line 7524

Quoted 4 lines
MAINTAINERS +2 -0
 DRM DRIVERS FOR VC4
 M:   Maxime Ripard <[email protected]>
+M:   Dave Stevenson <[email protected]>
+M:   Raspberry Pi Kernel Maintenance <[email protected]>

I don't think we can put a list as maintainer, maintainers (and reviewers) should be explicit. We can definitely put the list as Cc with
L: though :)

Quoted 2 lines

It's been accepted for Unicam
https://github.com/torvalds/linux/blob/master/MAINTAINERS#L4178-L4183

I think it's somewhat different in the case of v4l2, you're the one taking the patches and sending a PR iirc. In drm-misc, there's a significant chance someone else will apply it.

Quoted 2 lines

[email protected] is listed as reviewer for a fair number of entries.

It's also a matter of signalling to the rest of the kernel community how important a review is: if I get a review of someone on a patch that isn't listed in MAINTAINERS, then it's valid but not enough for me to merge it.

If it's from a reviewer, then it carries more weight, and if it's from a maintainer, then it's pretty much the final word.

That only works if we explicitly put names in MAINTAINERS.

But I also don't care how many maintainers or reviewers you want to put in MAINTAINERS, so it's not gatekeeping. It's mostly just around documenting what the situation will be :)

Maxime