shell: add echo command check
PATCH 1/1 shell: add echo command check
--- runtest/commands | 1 + testcases/commands/echo/Makefile | 11 +++++ testcases/commands/echo/echo_tests.sh | 62 +++++++++++++++++++++++++++ 3 files changed, 74 insertions(+) create mode 100644 testcases/commands/echo/Makefile create mode 100644 testcases/commands/echo/echo_tests.sh
runtest/commands +1 -0
@@ -12,6 +12,7 @@ gzip01_sh gzip_tests.sh cp01_sh cp_tests.sh ln01_sh ln_tests.sh mkdir01_sh mkdir_tests.sh +echo_tests_sh echo_tests.sh mv01_sh mv_tests.sh du01_sh du01.sh df01_sh df01.sh
testcases/commands/echo/Makefile new file +11 -0
@@ -0,0 +1,11 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2024 UnionTech Ltd. +# Author: Taotao Ma <[email protected]> + +top_srcdir ?= ../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +INSTALL_TARGETS := echo_tests.sh + +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/commands/echo/echo_tests.sh new file +62 -0
63 lines not on this page · raw message
Signature · 5 lines
2.20.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Mataotao,
First, thank you for creating new tests for LTP.
But from what I know LTP now is mainly a face-to-Linux Kernel side test suite,
rather than the userspace or command line test (it had some but slowly being removed from the test suite).
'echo' is daily popular used but belongs to the coreutils package, it's not the core
of kernel part. I guess maintainers have no passion for reviewing patch like this:(.
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Mataotao,
Quoted 3 lines
Hi Mataotao,
First, thank you for creating new tests for LTP.
Thank you!
Quoted 4 lines
But from what I know LTP now is mainly a face-to-Linux Kernel side test suite,
rather than the userspace or command line test (it had some but slowly being removed from the test suite).
+1, these would be better placed in coreutils or the shell project you target.
Quoted 2 lines
'echo' is daily popular used but belongs to the coreutils package, it's not the core
Also, 'echo' is not only binary from coreutils, but also a shell builtin. Moreover, 'echo' is known for various incompatibility across implementations (printf is suggested to be used if compatibility is needed).
Kind regards,
Petr
Quoted 2 lines
of kernel part. I guess maintainers have no passion for reviewing patch like this:(.
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp