mm-memory_hotplug-drop-memblock_phys_free-call-in-try_remove_memory.patch removed from -mm tree
The quilt patch titled
Subject: mm/memory_hotplug: drop memblock_phys_free() call in try_remove_memory()
has been removed from the -mm tree. Its filename was
mm-memory_hotplug-drop-memblock_phys_free-call-in-try_remove_memory.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Jonathan Cameron <[email protected]>
Subject: mm/memory_hotplug: drop memblock_phys_free() call in try_remove_memory()
Date: Wed, 5 Jun 2024 11:20:49 +0300
The call for memblock_phys_free() in try_remove_memory() does not balance any call to memblock_alloc() (or memblock_reserve() for that matter).
There are no memblock_reserve() calls in mm/memory_hotplug.c, no memblock allocations possible after mm_core_init(), and even if memblock_add_node() called from add_memory_resource() would need to allocate memory, that memory would ba allocated from slab.
The patch f9126ab9241f ("memory-hotplug: fix wrong edge when hot add a new node") that introduced that call to memblock_free() does not provide adequate description why that was required and tinkering with memblock in the context of memory hotplug on x86 seems bogus because x86 never kept memblock after boot anyway.
Drop memblock_phys_free() call in try_remove_memory().
---
mm/memory_hotplug.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
mm/memory_hotplug.c renamed from mm/memory_hotplug.c~mm-memory_hotplug-drop-memblock_phys_free-call-in-try_remove_memory +1 -3
@@ -2282,10 +2282,8 @@ static int __ref try_remove_memory(u64 sremove_memory_blocks_and_altmaps (start, size); } -if (IS_ENABLED (CONFIG_ARCH_KEEP_MEMBLOCK )) { -memblock_phys_free (start, size); +if (IS_ENABLED (CONFIG_ARCH_KEEP_MEMBLOCK ))memblock_remove (start, size); - }release_mem_region_adjustable (start, size);
_
Patches currently in -mm which might be from [email protected] are