Correct WL-355608-A8 panel compatible

PATCH Superseded Ryan Walklin 4 participants 17 messages Jun 26, 2024 – Sep 3, 2024

Subsystems (4)

Device tree bindings DRM drivers DRM misc DRM panel drivers

lore

Share & tools

lore

Ryan Walklin

author

2024-06-26 11:20 UTC #0 lore raw

cover Correct WL-355608-A8 panel compatible

The previous patch adding support for this panel [1] referred to previously by its serial number only. As discussed after the patch was committed, the preference is to use the integrating device vendor and name in this circumstance.

This series corrects the panel compatible to reflect the vendor (Anbernic, already in the vendor prefix table), updates the NV3052C panel driver with the new compatible, and lastly adds num-chipselects and sck-gpios to the DT binding example, identified by make dt_bindings_check as required for bit-banged SPI over GPIO lines.

Regards,

Ryan

[1] https://lore.kernel.org/dri-devel/[email protected]/

Ryan Walklin (3):
dt-bindings: display: panel: Rename WL-355608-A8 panel
drm: panel: nv3052c: Correct WL-355608-A8 panel compatible
dt-bindings: display: panel: correct Anbernic RG35XX panel example

 .../{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} | 11 +++++++----
 drivers/gpu/drm/panel/panel-newvision-nv3052c.c       |  2 +-
 2 files changed, 8 insertions(+), 5 deletions(-)
 rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} (76%)

Signature · 1 line

2.45.2

Ryan Walklin

author

2024-06-26 11:20 UTC #1 lore raw

PATCH 1/3 dt-bindings: display: panel: Rename WL-355608-A8 panel

The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Previously committed using the OEM serial without a vendor prefix, however the preference is to use the integrating device vendor and name where the OEM is unknown.

Alter the filename and compatible string to reflect the convention.

Fixes f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")

Signed-off-by Ryan Walklin <[email protected]>

---
 .../{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml}     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
 rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} (81%)

Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml renamed from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +4 -4

similarity index 81%
rename from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
rename to Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
index 397c26be9bda5..a7d5ad0f29389 100644
@@ -1,10 +1,10 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml#
+$id: http://devicetree.org/schemas/display/panel/anbernic,rg35xx-panel.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel
+title: Anbernic RG35XX (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel
 
 maintainers:
   - Ryan Walklin <[email protected]>

@@ -15,7 +15,7 @@ allOf:
 
 properties:
   compatible:
-    const: wl-355608-a8
+    const: anbernic,rg35xx-panel
 
   reg:
     maxItems: 1

@@ -41,7 +41,7 @@ examples:
         #size-cells = <0>;
 
         panel@0 {
-            compatible = "wl-355608-a8";
+            compatible = "anbernic,rg35xx-panel";
             reg = <0>;
 
             spi-3wire;

Signature · 1 line

2.45.2

Neil Armstrong

maintainer

2024-06-26 12:26 UTC #2 lore raw

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

Quoted 45 lines · Ryan Walklin

The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Previously committed using the OEM serial without a vendor prefix, however the preference is to use the integrating device vendor and name where the OEM is unknown.
Alter the filename and compatible string to reflect the convention.
Fixes f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")
Signed-off-by Ryan Walklin <[email protected]>
---
  .../{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml}     | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} (81%)
Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml renamed from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +3 -3
similarity index 81%
rename from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
rename to Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
index 397c26be9bda5..a7d5ad0f29389 100644
@@ -1,10 +1,10 @@
  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
  %YAML 1.2
  ---
-$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml#
+$id: http://devicetree.org/schemas/display/panel/anbernic,rg35xx-panel.yaml#
  $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel
+title: Anbernic RG35XX (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel
 
  maintainers:
    - Ryan Walklin <[email protected]>
@@ -15,7 +15,7 @@ allOf:
 
  properties:
    compatible:
-    const: wl-355608-a8
+    const: anbernic,rg35xx-panel
 
    reg:
      maxItems: 1

Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml examples: · line 44

Quoted 5 lines

Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml renamed from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +1 -1
@@ -41,7 +41,7 @@ examples:
          #size-cells = <0>;
 
          panel@0 {
-            compatible = "wl-355608-a8";
+            compatible = "anbernic,rg35xx-panel";

Can it be more specific ? because there's a lot of rg35xx defined in bindings:
anbernic,rg351m
anbernic,rg351v
anbernic,rg353p
anbernic,rg353ps
anbernic,rg353v
anbernic,rg353vs
anbernic,rg35xx-2024
anbernic,rg35xx-plus
anbernic,rg35xx-h

Neil

Quoted 3 lines

Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml renamed from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +0 -0
              reg = <0>;
 
              spi-3wire;

Maxime Ripard

maintainer

2024-06-26 15:04 UTC #3 lore raw

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

Quoted 49 lines · Neil Armstrong

Quoted 41 lines · Ryan Walklin
The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Previously committed using the OEM serial without a vendor prefix, however the preference is to use the integrating device vendor and name where the OEM is unknown.
Alter the filename and compatible string to reflect the convention.
Fixes f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")
Signed-off-by Ryan Walklin <[email protected]>
---
  .../{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml}     | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} (81%)
Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml renamed from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +3 -3
similarity index 81%
rename from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
rename to Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
index 397c26be9bda5..a7d5ad0f29389 100644
@@ -1,10 +1,10 @@
  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
  %YAML 1.2
  ---
-$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml#
+$id: http://devicetree.org/schemas/display/panel/anbernic,rg35xx-panel.yaml#
  $schema: http://devicetree.org/meta-schemas/core.yaml#
-title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel
+title: Anbernic RG35XX (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel
  maintainers:
    - Ryan Walklin <[email protected]>
@@ -15,7 +15,7 @@ allOf:
  properties:
    compatible:
-    const: wl-355608-a8
+    const: anbernic,rg35xx-panel
    reg:
      maxItems: 1
Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml examples: · line 43
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml renamed from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +1 -1
@@ -41,7 +41,7 @@ examples:
          #size-cells = <0>;
          panel@0 {
-            compatible = "wl-355608-a8";
+            compatible = "anbernic,rg35xx-panel";
Can it be more specific ? because there's a lot of rg35xx defined in bindings:
anbernic,rg351m

Quoted 8 lines

anbernic,rg351v
anbernic,rg353p
anbernic,rg353ps
anbernic,rg353v
anbernic,rg353vs
anbernic,rg35xx-2024
anbernic,rg35xx-plus
anbernic,rg35xx-h

Yeah, if we have an identified model name, we should probably use that, with a comment that we couldn't figure out what the vendor was and thus went for anbernic.

Maxime

Conor Dooley

2024-06-26 15:34 UTC #4 lore raw

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

Quoted 59 lines · Maxime Ripard

Quoted 49 lines · Neil Armstrong
Quoted 41 lines · Ryan Walklin
The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Previously committed using the OEM serial without a vendor prefix, however the preference is to use the integrating device vendor and name where the OEM is unknown.
Alter the filename and compatible string to reflect the convention.
Fixes f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")
Signed-off-by Ryan Walklin <[email protected]>
---
  .../{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml}     | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} (81%)
Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml renamed from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +3 -3
similarity index 81%
rename from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
rename to Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
index 397c26be9bda5..a7d5ad0f29389 100644
@@ -1,10 +1,10 @@
  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
  %YAML 1.2
  ---
-$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml#
+$id: http://devicetree.org/schemas/display/panel/anbernic,rg35xx-panel.yaml#
  $schema: http://devicetree.org/meta-schemas/core.yaml#
-title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel
+title: Anbernic RG35XX (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel
  maintainers:
    - Ryan Walklin <[email protected]>
@@ -15,7 +15,7 @@ allOf:
  properties:
    compatible:
-    const: wl-355608-a8
+    const: anbernic,rg35xx-panel
    reg:
      maxItems: 1
Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml examples: · line 43
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml renamed from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +1 -1
@@ -41,7 +41,7 @@ examples:
          #size-cells = <0>;
          panel@0 {
-            compatible = "wl-355608-a8";
+            compatible = "anbernic,rg35xx-panel";
Can it be more specific ? because there's a lot of rg35xx defined in bindings:
anbernic,rg351m
Quoted 8 lines
anbernic,rg351v
anbernic,rg353p
anbernic,rg353ps
anbernic,rg353v
anbernic,rg353vs
anbernic,rg35xx-2024
anbernic,rg35xx-plus
anbernic,rg35xx-h

Quoted 3 lines

Yeah, if we have an identified model name, we should probably use that, with a comment that we couldn't figure out what the vendor was and thus went for anbernic.

What's wrong with using the wl name that already exists as the model? Using rg<whatever>-panel is total invention on our part, especially seeing as the commit message says that multiple models can use it.

Maxime Ripard

maintainer

2024-06-27 17:59 UTC #5 lore raw

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

Quoted 60 lines · Conor Dooley

Quoted 59 lines · Maxime Ripard
Quoted 57 lines · Neil Armstrong
Quoted 41 lines · Ryan Walklin
The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Previously committed using the OEM serial without a vendor prefix, however the preference is to use the integrating device vendor and name where the OEM is unknown.
Alter the filename and compatible string to reflect the convention.
Fixes f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")
Signed-off-by Ryan Walklin <[email protected]>
---
  .../{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml}     | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} (81%)
Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml renamed from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +3 -3
similarity index 81%
rename from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
rename to Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
index 397c26be9bda5..a7d5ad0f29389 100644
@@ -1,10 +1,10 @@
  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
  %YAML 1.2
  ---
-$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml#
+$id: http://devicetree.org/schemas/display/panel/anbernic,rg35xx-panel.yaml#
  $schema: http://devicetree.org/meta-schemas/core.yaml#
-title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel
+title: Anbernic RG35XX (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel
  maintainers:
    - Ryan Walklin <[email protected]>
@@ -15,7 +15,7 @@ allOf:
  properties:
    compatible:
-    const: wl-355608-a8
+    const: anbernic,rg35xx-panel
    reg:
      maxItems: 1
Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml examples: · line 43
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml renamed from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +1 -1
@@ -41,7 +41,7 @@ examples:
          #size-cells = <0>;
          panel@0 {
-            compatible = "wl-355608-a8";
+            compatible = "anbernic,rg35xx-panel";
Can it be more specific ? because there's a lot of rg35xx defined in bindings:
anbernic,rg351m
anbernic,rg351v
anbernic,rg353p
anbernic,rg353ps
anbernic,rg353v
anbernic,rg353vs
anbernic,rg35xx-2024
anbernic,rg35xx-plus
anbernic,rg35xx-h

Quoted 7 lines

Quoted 3 lines
Yeah, if we have an identified model name, we should probably use that, with a comment that we couldn't figure out what the vendor was and thus went for anbernic.
What's wrong with using the wl name that already exists as the model? Using rg<whatever>-panel is total invention on our part, especially seeing as the commit message says that multiple models can use it.

Yeah, that makes sense, sorry for the noise

Maxime

Ryan Walklin

author

2024-06-30 08:16 UTC #6 lore raw

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

Quoted 13 lines · Maxime Ripard

Quoted 12 lines · Conor Dooley
Quoted 11 lines · Maxime Ripard
Quoted 10 lines · Neil Armstrong
Can it be more specific ? because there's a lot of rg35xx defined in bindings:
anbernic,rg351m
anbernic,rg351v
anbernic,rg353p
anbernic,rg353ps
anbernic,rg353v
anbernic,rg353vs
anbernic,rg35xx-2024
anbernic,rg35xx-plus
anbernic,rg35xx-h

Just to note only the three rg35xx-* devices use this particular panel.

Quoted 11 lines

Quoted 8 lines
Quoted 4 lines
Yeah, if we have an identified model name, we should probably use that, with a comment that we couldn't figure out what the vendor was and thus went for anbernic.
What's wrong with using the wl name that already exists as the model? Using rg<whatever>-panel is total invention on our part, especially seeing as the commit message says that multiple models can use it.
Yeah, that makes sense, sorry for the noise

Thanks both for the further feedback, agreed logical to use the device vendor and panel serial number, ie "anbernic,wl-355608-a8". Will post a V2 with a comment to that effect.

Regards,

Ryan

Neil Armstrong

maintainer

2024-08-27 16:28 UTC #7 lore raw

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

Quoted 22 lines · Ryan Walklin

Quoted 13 lines · Maxime Ripard
Quoted 12 lines · Conor Dooley
Quoted 11 lines · Maxime Ripard
Quoted 10 lines · Neil Armstrong
Can it be more specific ? because there's a lot of rg35xx defined in bindings:
anbernic,rg351m
anbernic,rg351v
anbernic,rg353p
anbernic,rg353ps
anbernic,rg353v
anbernic,rg353vs
anbernic,rg35xx-2024
anbernic,rg35xx-plus
anbernic,rg35xx-h
Just to note only the three rg35xx-* devices use this particular panel.
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Yeah, if we have an identified model name, we should probably use that, with a comment that we couldn't figure out what the vendor was and thus went for anbernic.

Quoted 7 lines

Quoted 6 lines
Quoted 3 lines
What's wrong with using the wl name that already exists as the model? Using rg<whatever>-panel is total invention on our part, especially seeing as the commit message says that multiple models can use it.
Yeah, that makes sense, sorry for the noise
Thanks both for the further feedback, agreed logical to use the device vendor and panel serial number, ie "anbernic,wl-355608-a8". Will post a V2 with a comment to that effect.

Well in this case we can keep "wl-355608-a8", because the panel vendor _is not_ anbernic.

Neil

Quoted 4 lines

Regards,
Ryan

Maxime Ripard

maintainer

2024-08-28 07:01 UTC #8 lore raw

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

Quoted 27 lines · Neil Armstrong

Quoted 26 lines · Ryan Walklin
Quoted 13 lines · Maxime Ripard
Quoted 12 lines · Conor Dooley
Quoted 11 lines · Maxime Ripard
Quoted 10 lines · Neil Armstrong
Can it be more specific ? because there's a lot of rg35xx defined in bindings:
anbernic,rg351m
anbernic,rg351v
anbernic,rg353p
anbernic,rg353ps
anbernic,rg353v
anbernic,rg353vs
anbernic,rg35xx-2024
anbernic,rg35xx-plus
anbernic,rg35xx-h
Just to note only the three rg35xx-* devices use this particular panel.
Quoted 9 lines
Quoted 8 lines
Quoted 4 lines
Yeah, if we have an identified model name, we should probably use that, with a comment that we couldn't figure out what the vendor was and thus went for anbernic.
What's wrong with using the wl name that already exists as the model? Using rg<whatever>-panel is total invention on our part, especially seeing as the commit message says that multiple models can use it.

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
Yeah, that makes sense, sorry for the noise
Thanks both for the further feedback, agreed logical to use the device vendor and panel serial number, ie "anbernic,wl-355608-a8". Will post a V2 with a comment to that effect.
Well in this case we can keep "wl-355608-a8", because the panel vendor _is not_ anbernic.

And it's not a generic or ubiquitous device either. We've been over this already, anbernic is the best we have.

Maxime

Ryan Walklin

author

2024-08-30 01:43 UTC #9 lore raw

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

Quoted 9 lines · Maxime Ripard

Quoted 4 lines · Neil Armstrong
Quoted 3 lines
Thanks both for the further feedback, agreed logical to use the device vendor and panel serial number, ie "anbernic,wl-355608-a8". Will post a V2 with a comment to that effect.

Quoted 5 lines

Quoted 2 lines
Well in this case we can keep "wl-355608-a8", because the panel vendor _is not_ anbernic.
And it's not a generic or ubiquitous device either. We've been over this already, anbernic is the best we have.

I don’t have a strong preference either way but agree the anbernic vendor string is the best compromise.

Regards,

Ryan

Neil Armstrong

maintainer

2024-08-30 07:56 UTC #10 lore raw

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

Quoted 9 lines · Ryan Walklin

Quoted 9 lines · Maxime Ripard
Quoted 4 lines · Neil Armstrong
Quoted 3 lines
Thanks both for the further feedback, agreed logical to use the device vendor and panel serial number, ie "anbernic,wl-355608-a8". Will post a V2 with a comment to that effect.

Quoted 7 lines

Quoted 5 lines
Quoted 2 lines
Well in this case we can keep "wl-355608-a8", because the panel vendor _is not_ anbernic.
And it's not a generic or ubiquitous device either. We've been over this already, anbernic is the best we have.
I don’t have a strong preference either way but agree the anbernic vendor string is the best compromise.

The only valid compatible with anbernic would be to use the exact device in use and not a wildcard, so you said the 3 devices using this panel are:
anbernic,rg35xx-2024
anbernic,rg35xx-plus
anbernic,rg35xx-h
you should introduce 3 compatibles:
anbernic,rg35xx-2024-panel
anbernic,rg35xx-plus-panel
anbernic,rg35xx-h-panel

but it's duplicating for nothing, to you should use fallbacks for 2 of them to have in DT :

anbernic,rg35xx-2024-panel anbernic,rg35xx-plus-panel, anbernic,rg35xx-2024-panel anbernic,rg35xx-h-panel, anbernic,rg35xx-2024-panel

and only use anbernic,rg35xx-2024-panel in the driver.

In this case bindings should be like:
properties:
compatible:
oneOf:
- const: anbernic,rg35xx-2024-panel
- items:
- enum:
- anbernic,rg35xx-plus-panel
- anbernic,rg35xx-h-panel
- const: anbernic,rg35xx-2024-panel

(of course I selected rg35xx-2024 as the primary one, it could be another, usually the older one)

Neil

Quoted 4 lines

Regards,
Ryan

Ryan Walklin

author

2024-09-03 01:53 UTC #11 lore raw

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

On Fri, 30 Aug 2024, at 7:56 PM, Neil Armstrong wrote:

Thanks Neil,

Quoted 33 lines

The only valid compatible with anbernic would be to use the exact device in use and not a wildcard,
so you said the 3 devices using this panel are:
anbernic,rg35xx-2024
anbernic,rg35xx-plus
anbernic,rg35xx-h
you should introduce 3 compatibles:
anbernic,rg35xx-2024-panel
anbernic,rg35xx-plus-panel
anbernic,rg35xx-h-panel
but it's duplicating for nothing, to you should use fallbacks for 2 of them to have in DT :
anbernic,rg35xx-2024-panel anbernic,rg35xx-plus-panel, anbernic,rg35xx-2024-panel anbernic,rg35xx-h-panel, anbernic,rg35xx-2024-panel
and only use anbernic,rg35xx-2024-panel in the driver.
In this case bindings should be like:
properties:
compatible:
oneOf:
- const: anbernic,rg35xx-2024-panel
- items:
- enum:
- anbernic,rg35xx-plus-panel
- anbernic,rg35xx-h-panel
- const: anbernic,rg35xx-2024-panel

Quoted 3 lines

(of course I selected rg35xx-2024 as the primary one, it could be another, usually the older one)

If all are happy with this approach I will resubmit a V2 with that change this evening.

Regards,

Ryan

Ryan Walklin

author

2024-06-26 11:20 UTC #12 lore raw

PATCH 2/3 drm: panel: nv3052c: Correct WL-355608-A8 panel compatible

In reply to Ryan Walklin

As per the previous dt-binding commit, update the WL-355608-A8 panel compatible to reflect the the integrating device vendor and name.

Signed-off-by Ryan Walklin <[email protected]>

---
 drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/gpu/drm/panel/panel-newvision-nv3052c.c +1 -1

index ee0ce271205e3..cee40269d9bb8 100644
@@ -925,7 +925,7 @@ MODULE_DEVICE_TABLE(spi, nv3052c_ids);
 static const struct of_device_id nv3052c_of_match[] = {
 	{ .compatible = "leadtek,ltk035c5444t", .data = &ltk035c5444t_panel_info },
 	{ .compatible = "fascontek,fs035vg158", .data = &fs035vg158_panel_info },
-	{ .compatible = "wl-355608-a8", .data = &wl_355608_a8_panel_info },
+	{ .compatible = "anbernic,rg35xx-panel", .data = &wl_355608_a8_panel_info },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, nv3052c_of_match);

Signature · 1 line

2.45.2

Ryan Walklin

author

2024-06-26 11:20 UTC #13 lore raw

PATCH 3/3 dt-bindings: display: panel: correct Anbernic RG35XX panel example

In reply to Ryan Walklin

make dt_bindings_check reports that sck-gpios and num-chipselects are required for spi nodes, therefore add these to the example.

Signed-off-by Ryan Walklin <[email protected]>

---
 .../bindings/display/panel/anbernic,rg35xx-panel.yaml          | 3 +++
 1 file changed, 3 insertions(+)

Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml +3 -0

index a7d5ad0f29389..610601c1594f3 100644
@@ -40,6 +40,9 @@ examples:
         #address-cells = <1>;
         #size-cells = <0>;
 
+        sck-gpios = <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9
+        num-chipselects = <1>;
+
         panel@0 {
             compatible = "anbernic,rg35xx-panel";
             reg = <0>;

Signature · 1 line

2.45.2

Conor Dooley

2024-06-26 15:38 UTC #14 lore raw

Re: [PATCH 3/3] dt-bindings: display: panel: correct Anbernic RG35XX panel example

Quoted 4 lines · Ryan Walklin

make dt_bindings_check reports that sck-gpios and num-chipselects are required for spi nodes, therefore add these to the example.
Signed-off-by Ryan Walklin <[email protected]>

huh, are you sure it does? It doesn't for me...

Quoted 21 lines

---
 .../bindings/display/panel/anbernic,rg35xx-panel.yaml          | 3 +++
 1 file changed, 3 insertions(+)

Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml +3 -0

index a7d5ad0f29389..610601c1594f3 100644
@@ -40,6 +40,9 @@ examples:
         #address-cells = <1>;
         #size-cells = <0>;
 
+        sck-gpios = <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9
+        num-chipselects = <1>;
+
         panel@0 {
             compatible = "anbernic,rg35xx-panel";
             reg = <0>;

Signature · 1 line

2.45.2

Ryan Walklin

author

2024-06-30 08:25 UTC #15 lore raw

Re: [PATCH 3/3] dt-bindings: display: panel: correct Anbernic RG35XX panel example

Hi Conor,

Quoted 6 lines · Conor Dooley

Quoted 2 lines · Ryan Walklin
make dt_bindings_check reports that sck-gpios and num-chipselects are required for spi nodes, therefore add these to the example.
huh, are you sure it does? It doesn't for me...

With:
make dt_binding_check -j32 -s -W 2

I get the following output:

/home/ryan/Projects/Develop/RG35XX+/kernel/linux/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.example.dtb: spi: 'num-chipselects' is a required property
from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
/home/ryan/Projects/Develop/RG35XX+/kernel/linux/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.example.dtb: spi: 'sck-gpios' is a required property
from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#

The relevant section from spi-gpio.yaml seems to be:

required:
- compatible
- num-chipselects
- sck-gpios

I am happy to leave this out if a simpler example is desired, but alternately if the chipselects/sck-gpios should stay then I would suggest a better example would include the mosi/miso/cs GPIOs as well which would make the example functional.

Regards,

Ryan

Maxime Ripard

maintainer

2024-08-27 13:10 UTC #16 lore raw

In reply to Ryan Walklin

Hi,

Quoted 3 lines · Ryan Walklin

The previous patch adding support for this panel [1] referred to previously by its serial number only. As discussed after the patch was committed, the preference is to use the integrating device vendor and name in this circumstance.
This series corrects the panel compatible to reflect the vendor (Anbernic, already in the vendor prefix table), updates the NV3052C panel driver with the new compatible, and lastly adds num-chipselects and sck-gpios to the DT binding example, identified by make dt_bindings_check as required for bit-banged SPI over GPIO lines.

Where are we on this?

The 6.11 release comes dangerously close now.

Maxime