Skip to contentSkip to conversation

dm: exynos: Correct CONFIG_SYS_BOARD setting for Odroid XU3 boards

PATCH In review Anand Moon 3 participants 7 messages Jun 26, 2024 – Jul 17, 2024

lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH 1/2 dm: exynos: Correct CONFIG_SYS_BOARD setting for Odroid XU3 boards

Fix the issue where CONFIG_SYS_BOARD was incorrectly set on Odroid XU3 boards, causing boot failure. This was resolved by correcting the SYS_BOARD entry in Kconfig to load the correct device tree source (dts) for the Odroid Exynos5422 Platforms.

Fixes f76750d11133 ("Convert CONFIG_CONS_INDEX et al to Kconfig")

---
U-Boot 2024.07-rc5-00042-g80a111f426 (Jun 26 2024 - 15:03:09 +0530) for ODROID-XU3/XU4/HC1/HC2

CPU:   Exynos5422 @ 800 MHz
DRAM:  2 GiB
Core:  74 devices, 12 uclasses, devicetree: separate
MMC:   mmc@12200000: 0, mmc@12220000: 2

Loading Environment from MMC... Reading from MMC(2)... *** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
Model: Odroid XU3/XU4/HC1/HC2 based on Exynos5422
Type:  xu4
Boot device: MMC(2)
Net:   No ethernet found.
Hit any key to stop autoboot:  0

switch to partitions #0, OK
mmc2 is current device
Scanning mmc 2:1...
Found U-Boot script /boot/boot.scr
2046 bytes read in 22 ms (90.8 KiB/s)
8104280 bytes read in 519 ms (14.9 MiB/s) Failed to load '/boot/dtbs/exynos5422-smdk5420xu4.dtb' SCRIPT FAILED: continuing...
No EFI system partition
No EFI system partition
Failed to persist EFI variables
No EFI system partition
Failed to persist EFI variables
No EFI system partition
Failed to persist EFI variables
Loading Boot0000 'mmc 2' failed
EFI boot manager: Cannot load any image
MMC Device 1 not found
no mmc device at slot 1

---
 board/samsung/smdk5420/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/samsung/smdk5420/Kconfig +1 -1
index a9d62fffa5..37d6bbbed1 100644
@@ -1,7 +1,7 @@
 if TARGET_ODROID_XU3
 
 config SYS_BOARD
-	default "smdk5420"
+	default "odroid"
 
 config SYS_VENDOR
 	default "samsung"

base-commit: c53b344475734d0d29f522b7b1d80c5b8204442d

Signature · 1 line
2.44.0
author
#1 lore raw

PATCH 2/2 odroid: Fix target platform compilation issue on Odroid-XU3

Resolved a compilation issue where the build system attempted to compile for the Odroid-XU3 platform instead of the specified Exynos4412 platform due to an incorrect CONFIG_SYS_BOARD setting. Updated the Makefile to ensure that compilation only occurs for the Odroid-XU3 specified target platform.

Now, object files will be generated only when building for the TARGET_ODROID platform.

---
Tested om Odroid-U3 and Odroid-XU4.

---
 board/samsung/odroid/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/samsung/odroid/Makefile +1 -1
index 5bf48313de..615c99f501 100644
@@ -3,4 +3,4 @@
 # Copyright (c) 2014 Samsung Electronics Co., Ltd. All rights reserved.
 # Przemyslaw Marczak <[email protected]>
 
-obj-y	:= odroid.o
+obj-$(CONFIG_TARGET_ODROID)	:= odroid.o
Signature · 1 line
2.44.0
Reviewed-by on v1 1/2
#4 lore raw
In reply to Anand Moon
Quoted 37 lines · Anand Moon

Fix the issue where CONFIG_SYS_BOARD was incorrectly set on Odroid XU3 boards, causing boot failure. This was resolved by correcting the SYS_BOARD entry in Kconfig to load the correct device tree source (dts) for the Odroid Exynos5422 Platforms.

Fixes f76750d11133 ("Convert CONFIG_CONS_INDEX et al to Kconfig")

---
U-Boot 2024.07-rc5-00042-g80a111f426 (Jun 26 2024 - 15:03:09 +0530) for ODROID-XU3/XU4/HC1/HC2

CPU:   Exynos5422 @ 800 MHz
DRAM:  2 GiB
Core:  74 devices, 12 uclasses, devicetree: separate
MMC:   mmc@12200000: 0, mmc@12220000: 2

Loading Environment from MMC... Reading from MMC(2)... *** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
Model: Odroid XU3/XU4/HC1/HC2 based on Exynos5422
Type:  xu4
Boot device: MMC(2)
Net:   No ethernet found.
Hit any key to stop autoboot:  0

switch to partitions #0, OK
mmc2 is current device
Scanning mmc 2:1...
Found U-Boot script /boot/boot.scr
2046 bytes read in 22 ms (90.8 KiB/s)
8104280 bytes read in 519 ms (14.9 MiB/s) Failed to load '/boot/dtbs/exynos5422-smdk5420xu4.dtb' SCRIPT FAILED: continuing...
No EFI system partition
No EFI system partition
Failed to persist EFI variables
No EFI system partition

Quoted 8 lines

Failed to persist EFI variables
No EFI system partition
Failed to persist EFI variables
Loading Boot0000 'mmc 2' failed
EFI boot manager: Cannot load any image
MMC Device 1 not found
no mmc device at slot 1
---

Quoted 21 lines
 board/samsung/smdk5420/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/samsung/smdk5420/Kconfig +1 -1
index a9d62fffa5..37d6bbbed1 100644
@@ -1,7 +1,7 @@
 if TARGET_ODROID_XU3
 
 config SYS_BOARD
-       default "smdk5420"
+       default "odroid"
 
 config SYS_VENDOR
        default "samsung"

base-commit: c53b344475734d0d29f522b7b1d80c5b8204442d --
2.44.0

Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH v1 2/2] odroid: Fix target platform compilation issue on Odroid-XU3

In reply to Anand Moon
Quoted 7 lines · Anand Moon

Resolved a compilation issue where the build system attempted to compile for the Odroid-XU3 platform instead of the specified Exynos4412 platform due to an incorrect CONFIG_SYS_BOARD setting. Updated the Makefile to ensure that compilation only occurs for the Odroid-XU3 specified target platform.

Quoted 5 lines

Now, object files will be generated only when building for the TARGET_ODROID platform.

---

Quoted 18 lines

Tested om Odroid-U3 and Odroid-XU4.

---
 board/samsung/odroid/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/samsung/odroid/Makefile +1 -2
index 5bf48313de..615c99f501 100644
@@ -3,4 +3,4 @@
 # Copyright (c) 2014 Samsung Electronics Co., Ltd. All rights reserved.
 # Przemyslaw Marczak <[email protected]>
 
-obj-y  := odroid.o
+obj-$(CONFIG_TARGET_ODROID)    := odroid.o
--

2.44.0

author
#5 lore raw
In reply to Sam Protsenko

Hi All,

Quoted 48 lines · Sam Protsenko
Quoted 37 lines · Anand Moon

Fix the issue where CONFIG_SYS_BOARD was incorrectly set on Odroid XU3 boards, causing boot failure. This was resolved by correcting the SYS_BOARD entry in Kconfig to load the correct device tree source (dts) for the Odroid Exynos5422 Platforms.

Fixes f76750d11133 ("Convert CONFIG_CONS_INDEX et al to Kconfig")

---
U-Boot 2024.07-rc5-00042-g80a111f426 (Jun 26 2024 - 15:03:09 +0530) for ODROID-XU3/XU4/HC1/HC2

CPU:   Exynos5422 @ 800 MHz
DRAM:  2 GiB
Core:  74 devices, 12 uclasses, devicetree: separate
MMC:   mmc@12200000: 0, mmc@12220000: 2

Loading Environment from MMC... Reading from MMC(2)... *** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
Model: Odroid XU3/XU4/HC1/HC2 based on Exynos5422
Type:  xu4
Boot device: MMC(2)
Net:   No ethernet found.
Hit any key to stop autoboot:  0

switch to partitions #0, OK
mmc2 is current device
Scanning mmc 2:1...
Found U-Boot script /boot/boot.scr
2046 bytes read in 22 ms (90.8 KiB/s)
8104280 bytes read in 519 ms (14.9 MiB/s) Failed to load '/boot/dtbs/exynos5422-smdk5420xu4.dtb' SCRIPT FAILED: continuing...
No EFI system partition
No EFI system partition
Failed to persist EFI variables
No EFI system partition

Quoted 8 lines

Failed to persist EFI variables
No EFI system partition
Failed to persist EFI variables
Loading Boot0000 'mmc 2' failed
EFI boot manager: Cannot load any image
MMC Device 1 not found
no mmc device at slot 1
---

Quoted 2 lines

Thanks

Gentle ping?

Thanks
-Anand

#6 lore raw

Hi,

2024년 7월 13일 (토) 16:51, Anand Moon <[email protected]>님이 작성:

Quoted 55 lines

Hi All,

Quoted 2 lines · Sam Protsenko

On Wed, Jun 26, 2024 at 10:15 AM Anand Moon <[email protected]>

Quoted 10 lines · wrote:
Quoted 10 lines

Fix the issue where CONFIG_SYS_BOARD was incorrectly set on Odroid XU3 boards, causing boot failure. This was resolved by correcting the SYS_BOARD entry in Kconfig to load the correct device tree source (dts) for the Odroid Exynos5422 Platforms.

Fixes f76750d11133 ("Convert CONFIG_CONS_INDEX et al to Kconfig")

---
U-Boot 2024.07-rc5-00042-g80a111f426 (Jun 26 2024 - 15:03:09 +0530)

for ODROID-XU3/XU4/HC1/HC2

Quoted 6 lines
Quoted 6 lines
CPU:   Exynos5422 @ 800 MHz
DRAM:  2 GiB
Core:  74 devices, 12 uclasses, devicetree: separate
MMC:   mmc@12200000: 0, mmc@12220000: 2

Loading Environment from MMC... Reading from MMC(2)... *** Warning -

bad CRC, using default environment

Quoted 30 lines
Quoted 29 lines
In:    serial
Out:   serial
Err:   serial
Model: Odroid XU3/XU4/HC1/HC2 based on Exynos5422
Type:  xu4
Boot device: MMC(2)
Net:   No ethernet found.
Hit any key to stop autoboot:  0

switch to partitions #0, OK
mmc2 is current device
Scanning mmc 2:1...
Found U-Boot script /boot/boot.scr
2046 bytes read in 22 ms (90.8 KiB/s)
8104280 bytes read in 519 ms (14.9 MiB/s) Failed to load '/boot/dtbs/exynos5422-smdk5420xu4.dtb' SCRIPT FAILED: continuing...
No EFI system partition
No EFI system partition
Failed to persist EFI variables
No EFI system partition
Failed to persist EFI variables
No EFI system partition
Failed to persist EFI variables
Loading Boot0000 'mmc 2' failed
EFI boot manager: Cannot load any image
MMC Device 1 not found
no mmc device at slot 1
---

Quoted 8 lines
Quoted 2 lines

Thanks

Gentle ping?

Thanks
-Anand

applied to u-boot-samsung.

Thanks.
Minkyu Kang.

#3 lore raw

Re: [PATCH v1 2/2] odroid: Fix target platform compilation issue on Odroid-XU3

In reply to Anand Moon

Hi,

2024년 6월 27일 (목) 00:41, Anand Moon <[email protected]>님이 작성:

Quoted 27 lines

Resolved a compilation issue where the build system attempted to compile for the Odroid-XU3 platform instead of the specified Exynos4412 platform due to an incorrect CONFIG_SYS_BOARD setting. Updated the Makefile to ensure that compilation only occurs for the Odroid-XU3 specified target platform.

Now, object files will be generated only when building for the TARGET_ODROID platform.

---
Tested om Odroid-U3 and Odroid-XU4.

---
 board/samsung/odroid/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/samsung/odroid/Makefile +1 -2
index 5bf48313de..615c99f501 100644
@@ -3,4 +3,4 @@
 # Copyright (c) 2014 Samsung Electronics Co., Ltd. All rights reserved.
 # Przemyslaw Marczak <[email protected]>
 
-obj-y  := odroid.o
+obj-$(CONFIG_TARGET_ODROID)    := odroid.o
--
Quoted 2 lines

2.44.0

applied to u-boot-samsung.

Thanks.
Minkyu Kang.