Skip to contentSkip to conversation

fs/procfs: fix integer to pointer cast warning in do_procmap_query()

PATCH Superseded Andrii Nakryiko 1 participant 1 message Jul 1, 2024

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/procfs: fix integer to pointer cast warning in do_procmap_query()

On 32-bit architectures compiler will complain about casting __u64 to void * pointer:

fs/proc/task_mmu.c: In function 'do_procmap_query':
fs/proc/task_mmu.c:598:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
598 | if (karg.vma_name_size && copy_to_user((void __user *)karg.vma_name_addr,
| ^
fs/proc/task_mmu.c:605:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
605 | if (karg.build_id_size && copy_to_user((void __user *)karg.build_id_addr,
| ^

Fix this by adding intermediate cast to uintptr_t.

Fixes df789ce1eb90 ("fs/procfs: add build ID fetching to PROCMAP_QUERY API")
Fixes 3757be498749 ("fs/procfs: implement efficient VMA querying API for /proc/<pid>/maps")
---
 fs/proc/task_mmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/proc/task_mmu.c +2 -2
index d99a390a0f41..e11d6197cef5 100644
@@ -595,14 +595,14 @@ static int do_procmap_query(struct proc_maps_private *priv, void __user *uarg)
 	query_vma_teardown(mm, vma);
 	mmput(mm);
 
-	if (karg.vma_name_size && copy_to_user((void __user *)karg.vma_name_addr,
+	if (karg.vma_name_size && copy_to_user((void __user *)(uintptr_t)karg.vma_name_addr,
 					       name, karg.vma_name_size)) {
 		kfree(name_buf);
 		return -EFAULT;
 	}
 	kfree(name_buf);
 
-	if (karg.build_id_size && copy_to_user((void __user *)karg.build_id_addr,
+	if (karg.build_id_size && copy_to_user((void __user *)(uintptr_t)karg.build_id_addr,
 					       build_id_buf, karg.build_id_size))
 		return -EFAULT;
 
Signature · 1 line
2.43.0