Remove inclusion of hw/hw.h from files that don't need it
PATCH 1/1 Remove inclusion of hw/hw.h from files that don't need it
hw/hw.h only contains the prototype of hw_error() nowadays, so files that don't use this function don't need to include this header.
Signed-off-by Thomas Huth <[email protected]>
--- include/hw/misc/xlnx-cfi-if.h | 1 - hw/misc/edu.c | 1 - hw/vfio/container.c | 1 - 3 files changed, 3 deletions(-)
include/hw/misc/xlnx-cfi-if.h +0 -1
@@ -11,7 +11,6 @@#define XLNX_CFI_IF_H 1#include "qemu/help-texts.h" -#include "hw/hw.h" #include "qom/object.h" #define TYPE_XLNX_CFI_IF "xlnx-cfi-if"
hw/misc/edu.c +0 -1
@@ -26,7 +26,6 @@#include "qemu/log.h" #include "qemu/units.h" #include "hw/pci/pci.h" -#include "hw/hw.h" #include "hw/pci/msi.h" #include "qemu/timer.h" #include "qom/object.h"
hw/vfio/container.c +0 -1
@@ -26,7 +26,6 @@#include "exec/address-spaces.h" #include "exec/memory.h" #include "exec/ram_addr.h" -#include "hw/hw.h" #include "qemu/error-report.h" #include "qemu/range.h" #include "sysemu/reset.h"
Signature · 1 line
2.45.2
Quoted 6 lines · Thomas Huth
hw/hw.honly contains the prototype ofhw_error()nowadays, so files that don't use this function don't need to include this header.Signed-off-by Thomas Huth <[email protected]>
Reviewed-by Peter Maydell <[email protected]>
thanks
-- PMM
Quoted 40 lines · Thomas Huth
hw/hw.honly contains the prototype ofhw_error()nowadays, so files that don't use this function don't need to include this header.Signed-off-by Thomas Huth <[email protected]>--- include/hw/misc/xlnx-cfi-if.h | 1 - hw/misc/edu.c | 1 - hw/vfio/container.c | 1 - 3 files changed, 3 deletions(-)include/hw/misc/xlnx-cfi-if.h +0
-1@@ -11,7 +11,6 @@#define XLNX_CFI_IF_H 1#include "qemu/help-texts.h" -#include "hw/hw.h" #include "qom/object.h" #define TYPE_XLNX_CFI_IF "xlnx-cfi-if"hw/misc/edu.c +0
-1@@ -26,7 +26,6 @@#include "qemu/log.h" #include "qemu/units.h" #include "hw/pci/pci.h" -#include "hw/hw.h" #include "hw/pci/msi.h" #include "qemu/timer.h" #include "qom/object.h" hw/vfio/container.c +0
-0
hw/vfio/container.c line 31
Quoted 7 lines
hw/vfio/container.c +0
-1@@ -26,7 +26,6 @@#include "exec/address-spaces.h" #include "exec/memory.h" #include "exec/ram_addr.h" -#include "hw/hw.h" #include "qemu/error-report.h" #include "qemu/range.h" #include "sysemu/reset.h"
Reviewed-by Cédric Le Goater <[email protected]>
Thanks,
C.
Quoted 10 lines · Thomas Huth
hw/hw.honly contains the prototype ofhw_error()nowadays, so files that don't use this function don't need to include this header.Signed-off-by Thomas Huth <[email protected]>--- include/hw/misc/xlnx-cfi-if.h | 1 - hw/misc/edu.c | 1 - hw/vfio/container.c | 1 - 3 files changed, 3 deletions(-)
Thanks, patch queued.