Skip to contentSkip to conversation

null_blk: Fix description of the fua parameter

PATCH Applied Damien Le Moal 5 participants 5 messages Jul 2, 2024 – Jul 4, 2024 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 null_blk: Fix description of the fua parameter

The description of the fua module parameter is defined using MODULE_PARM_DESC() with the first argument passed being "zoned". That is the wrong name, obviously. Fix that by using the correct "fua" parameter name so that "modinfo null_blk" displays correct information.

Fixes f4f84586c8b9 ("null_blk: Introduce fua attribute")
---
 drivers/block/null_blk/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/null_blk/main.c +1 -1
index 83a4ebe4763a..5de9ca4eceb4 100644
@@ -227,7 +227,7 @@ MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 (
 
 static bool g_fua = true;
 module_param_named(fua, g_fua, bool, 0444);
-MODULE_PARM_DESC(zoned, "Enable/disable FUA support when cache_size is used. Default: true");
+MODULE_PARM_DESC(fua, "Enable/disable FUA support when cache_size is used. Default: true");
 
 static unsigned int g_mbps;
 module_param_named(mbps, g_mbps, uint, 0444);
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Damien Le Moal

The description of the fua module parameter is defined using MODULE_PARM_DESC() with the first argument passed being "zoned". That is the wrong name, obviously. Fix that by using the correct "fua" parameter name so that "modinfo null_blk" displays correct information.

Looks good:

Reviewed-by on v1 1/1
#2 lore raw
In reply to Damien Le Moal
Quoted 10 lines · Damien Le Moal

The description of the fua module parameter is defined using MODULE_PARM_DESC() with the first argument passed being "zoned". That is the wrong name, obviously. Fix that by using the correct "fua" parameter name so that "modinfo null_blk" displays correct information.

Fixes f4f84586c8b9 ("null_blk: Introduce fua attribute")

---

Looks good.

-ck

maintainer Applied
#3 lore raw
In reply to Damien Le Moal
Quoted 6 lines · Damien Le Moal

The description of the fua module parameter is defined using MODULE_PARM_DESC() with the first argument passed being "zoned". That is the wrong name, obviously. Fix that by using the correct "fua" parameter name so that "modinfo null_blk" displays correct information.

Applied, thanks!

[1/1] null_blk: Fix description of the fua parameter

      commit: 1c0b3fca381bf879e2168b362692f83808677f95

Best regards,

Signature · 1 line
Jens Axboe
Reviewed-by on v1 1/1
#4 lore raw
In reply to Damien Le Moal
Quoted 17 lines · Damien Le Moal

The description of the fua module parameter is defined using MODULE_PARM_DESC() with the first argument passed being "zoned". That is the wrong name, obviously. Fix that by using the correct "fua" parameter name so that "modinfo null_blk" displays correct information.

Fixes f4f84586c8b9 ("null_blk: Introduce fua attribute")
---
  drivers/block/null_blk/main.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/null_blk/main.c +0 -0
index 83a4ebe4763a..5de9ca4eceb4 100644

drivers/block/null_blk/main.c MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 ( · line 230

Quoted 5 lines
drivers/block/null_blk/main.c +1 -1
@@ -227,7 +227,7 @@ MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 (
 
  static bool g_fua = true;
  module_param_named(fua, g_fua, bool, 0444);
-MODULE_PARM_DESC(zoned, "Enable/disable FUA support when cache_size is used. Default: true");
+MODULE_PARM_DESC(fua, "Enable/disable FUA support when cache_size is used. Default: true");

Zhu Yanjun

Quoted 3 lines
drivers/block/null_blk/main.c +0 -0
  static unsigned int g_mbps;
  module_param_named(mbps, g_mbps, uint, 0444);