null_blk: Fix description of the fua parameter
PATCH 1/1 null_blk: Fix description of the fua parameter
The description of the fua module parameter is defined using MODULE_PARM_DESC() with the first argument passed being "zoned". That is the wrong name, obviously. Fix that by using the correct "fua" parameter name so that "modinfo null_blk" displays correct information.
--- drivers/block/null_blk/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/null_blk/main.c +1 -1
@@ -227,7 +227,7 @@ MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 (static bool g_fua = true;module_param_named (fua, g_fua, bool,0444 ); -MODULE_PARM_DESC (zoned,"Enable/disable FUA support when cache_size is used. Default: true" ); +MODULE_PARM_DESC (fua,"Enable/disable FUA support when cache_size is used. Default: true" );static unsigned int g_mbps;module_param_named (mbps, g_mbps, uint,0444 );
Signature · 1 line
2.45.2
Quoted 4 lines · Damien Le Moal
The description of the fua module parameter is defined using
MODULE_PARM_DESC()with the first argument passed being "zoned". That is the wrong name, obviously. Fix that by using the correct "fua" parameter name so that "modinfonull_blk" displays correct information.
Looks good:
Quoted 10 lines · Damien Le Moal
The description of the fua module parameter is defined using
MODULE_PARM_DESC()with the first argument passed being "zoned". That is the wrong name, obviously. Fix that by using the correct "fua" parameter name so that "modinfonull_blk" displays correct information.Fixes f4f84586c8b9 ("null_blk: Introduce fua attribute")Signed-off-by Damien Le Moal <[email protected]>---
Looks good.
-ck
Quoted 6 lines · Damien Le Moal
The description of the fua module parameter is defined using
MODULE_PARM_DESC()with the first argument passed being "zoned". That is the wrong name, obviously. Fix that by using the correct "fua" parameter name so that "modinfonull_blk" displays correct information.
Applied, thanks!
[1/1] null_blk: Fix description of the fua parameter
commit: 1c0b3fca381bf879e2168b362692f83808677f95
Best regards,
Signature · 1 line
Jens Axboe
Quoted 17 lines · Damien Le Moal
The description of the fua module parameter is defined using
MODULE_PARM_DESC()with the first argument passed being "zoned". That is the wrong name, obviously. Fix that by using the correct "fua" parameter name so that "modinfonull_blk" displays correct information.Fixes f4f84586c8b9 ("null_blk: Introduce fua attribute")Signed-off-by Damien Le Moal <[email protected]>--- drivers/block/null_blk/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/block/null_blk/main.c +0
-0
drivers/block/null_blk/main.c MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 ( · line 230
Quoted 5 lines
drivers/block/null_blk/main.c +1
-1@@ -227,7 +227,7 @@ MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 (static bool g_fua = true;module_param_named (fua, g_fua, bool,0444 ); -MODULE_PARM_DESC (zoned,"Enable/disable FUA support when cache_size is used. Default: true" ); +MODULE_PARM_DESC (fua,"Enable/disable FUA support when cache_size is used. Default: true" );
Zhu Yanjun
Quoted 3 lines
drivers/block/null_blk/main.c +0
-0static unsigned int g_mbps;module_param_named (mbps, g_mbps, uint,0444 );