hw/nvme: Fix memory leak in nvme_dsm
PATCH 1/1 hw/nvme: Fix memory leak in nvme_dsm
The allocated memory to hold LBA ranges leaks in the nvme_dsm function. This happens because the allocated memory for iocb->range is not freed in all error handling paths.
Fix this by adding a free to ensure that the allocated memory is properly freed.
ASAN log:
==3075137==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 480 byte(s) in 6 object(s) allocated from:
#0 0x55f1f8a0eddd in malloc llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:129:3
#1 0x7f531e0f6738 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5e738)
#2 0x55f1faf1f091 in blk_aio_get block/block-backend.c:2583:12
#3 0x55f1f945c74b in nvme_dsm hw/nvme/ctrl.c:2609:30
#4 0x55f1f945831b in nvme_io_cmd hw/nvme/ctrl.c:4470:16
#5 0x55f1f94561b7 in nvme_process_sq hw/nvme/ctrl.c:7039:29--- hw/nvme/ctrl.c | 1 + 1 file changed, 1 insertion(+)
hw/nvme/ctrl.c +1 -0
@@ -2592,6 +2592,7 @@ next: done: iocb->aiocb =NULL ; iocb->common.cb (iocb->common.opaque, iocb->ret); +g_free (iocb->range);qemu_aio_unref (iocb); }
Signature · 1 line
2.34.1
Quoted 50 lines
-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Zheyu Ma
Sent: Wednesday, July 3, 2024 7:13 AM
To: Keith Busch <[email protected]>; Klaus Jensen <[email protected]>; Jesper Devantier <[email protected]>
Cc: Zheyu Ma <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] hw/nvme: Fix memory leak innvme_dsmThe allocated memory to hold LBA ranges leaks in the
nvme_dsmfunction. This happens because the allocated memory foriocb->rangeis not freed in all error handling paths.Fix this by adding a free to ensure that the allocated memory is properly freed.
ASAN log:
==3075137==ERROR: LeakSanitizer: detected memory leaksDirect leak of 480 byte(s) in 6 object(s) allocated from:
#0 0x55f1f8a0eddd in malloc llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:129:3 #1 0x7f531e0f6738 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5e738) #2 0x55f1faf1f091 in blk_aio_get block/block-backend.c:2583:12 #3 0x55f1f945c74b in nvme_dsm hw/nvme/ctrl.c:2609:30 #4 0x55f1f945831b in nvme_io_cmd hw/nvme/ctrl.c:4470:16 #5 0x55f1f94561b7 in nvme_process_sq hw/nvme/ctrl.c:7039:29Signed-off-by Zheyu Ma <[email protected]>--- hw/nvme/ctrl.c | 1 + 1 file changed, 1 insertion(+)hw/nvme/ctrl.c +1
-1@@ -2592,6 +2592,7 @@ next: done: iocb->aiocb =NULL ; iocb->common.cb (iocb->common.opaque, iocb->ret); +g_free (iocb->range);qemu_aio_unref (iocb); } --
Quoted 2 lines
2.34.1
Quoted 37 lines · Zheyu Ma
The allocated memory to hold LBA ranges leaks in the
nvme_dsmfunction. This happens because the allocated memory foriocb->rangeis not freed in all error handling paths.Fix this by adding a free to ensure that the allocated memory is properly freed.
ASAN log:
==3075137==ERROR: LeakSanitizer: detected memory leaksDirect leak of 480 byte(s) in 6 object(s) allocated from:
#0 0x55f1f8a0eddd in malloc llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:129:3 #1 0x7f531e0f6738 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5e738) #2 0x55f1faf1f091 in blk_aio_get block/block-backend.c:2583:12 #3 0x55f1f945c74b in nvme_dsm hw/nvme/ctrl.c:2609:30 #4 0x55f1f945831b in nvme_io_cmd hw/nvme/ctrl.c:4470:16 #5 0x55f1f94561b7 in nvme_process_sq hw/nvme/ctrl.c:7039:29Signed-off-by Zheyu Ma <[email protected]>--- hw/nvme/ctrl.c | 1 + 1 file changed, 1 insertion(+)hw/nvme/ctrl.c +1
-0@@ -2592,6 +2592,7 @@ next: done: iocb->aiocb =NULL ; iocb->common.cb (iocb->common.opaque, iocb->ret); +g_free (iocb->range);qemu_aio_unref (iocb); }Signature · 1 line
2.34.1
Thanks! LGTM