Skip to contentSkip to conversation

KVM: arm64: nv: Truely enable nXS TLBI operations

PATCH Applied Marc Zyngier 2 participants 2 messages Jul 3, 2024

Subsystems (3)
lore
Share & tools
lore

Marc Zyngier

author maintainer
#0 lore raw

PATCH 1/1 KVM: arm64: nv: Truely enable nXS TLBI operations

Although we now have support for nXS-flavoured TLBI instructions, we still don't expose the feature to the guest thanks to a mixture of misleading comment and use of a bunch of magic values.

Fix the comment and correctly express the masking of LS64, which is enough to expose nXS to the world. Not that anyone cares...

---
 arch/arm64/kvm/nested.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/kvm/nested.c +2 -2
index 81e0374a4a45b..b3c8d8e04a547 100644
@@ -810,8 +810,8 @@ static u64 limit_nv_id_reg(u32 id, u64 val)
 		break;
 
 	case SYS_ID_AA64ISAR1_EL1:
-		/* Support everything but Spec Invalidation */
-		val &= ~(GENMASK_ULL(63, 56)	|
+		/* Support everything but Spec Invalidation and LS64 */
+		val &= ~(NV_FTR(ISAR1, LS64)	|
 			 NV_FTR(ISAR1, SPECRES));
 		break;
 
Signature · 1 line
2.39.2
Applied
#1 lore raw
Quoted 8 lines · Marc Zyngier

Although we now have support for nXS-flavoured TLBI instructions, we still don't expose the feature to the guest thanks to a mixture of misleading comment and use of a bunch of magic values.

Fix the comment and correctly express the masking of LS64, which is enough to expose nXS to the world. Not that anyone cares...

[...]

Applied to kvmarm/next, thanks!

[1/1] KVM: arm64: nv: Truely enable nXS TLBI operations

      https://git.kernel.org/kvmarm/kvmarm/c/3cfde36df7ab

--
Best,
Oliver