Skip to contentSkip to conversation

Update the eeprom nodename following device tree specification

PATCH In review Andrei Simion 2 participants 12 messages Jul 4, 2024 – Jul 5, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Update the eeprom nodename following device tree specification

Change the nodename for each eeprom according to device tree specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
and according to the format specified in at24.yaml

Andrei Simion (7):
ARM: dts: microchip: at91-sama5d2_xplained: Align the eeprom nodename
ARM: dts: microchip: at91-sama5d2_ptc_ek: Align the eeprom nodename
ARM: dts: microchip: at91-sama5d34ek: Align the eeprom nodename
ARM: dts: microchip: at91-sama5d27_som1: Align the eeprom nodename
ARM: dts: microchip: at91sam9g20ek_common: Align the eeprom nodename
ARM: dts: microchip: at91sam9260ek: Align the eeprom nodename
ARM: dts: microchip: at91sam9263ek: Align the eeprom nodename

 arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi   | 2 +-
 arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts   | 2 +-
 arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts | 2 +-
 arch/arm/boot/dts/microchip/at91sam9260ek.dts         | 2 +-
 arch/arm/boot/dts/microchip/at91sam9263ek.dts         | 2 +-
 arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi | 2 +-
 arch/arm/boot/dts/microchip/sama5d34ek.dts            | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233

Signature · 1 line
2.34.1
#2 lore raw

PATCH 2/7 ARM: dts: microchip: at91-sama5d2_ptc_ek: Align the eeprom nodename

Aling the eeprom nodename according to device tree specification and at24.yaml.

---
 arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts +1 -1
index 200b20515ab1..e4ae60ef5f8a 100644
@@ -231,7 +231,7 @@ i2c1: i2c@fc028000 {
 				scl-gpios = <&pioA PIN_PC7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 				status = "okay";
 
-				at24@50 {
+				eeprom@50 {
 					compatible = "atmel,24c02";
 					reg = <0x50>;
 					pagesize = <8>;
Signature · 1 line
2.34.1
#4 lore raw

PATCH 3/7 ARM: dts: microchip: at91-sama5d34ek: Align the eeprom nodename

In reply to Andrei Simion

Align the eeprom nodename according to device tree specification and at24.yaml.

---
 arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/microchip/sama5d34ek.dts +1 -1
index bffd61397cb5..18943b873fff 100644
@@ -36,7 +36,7 @@ i2c0: i2c@f0014000 {
 			i2c1: i2c@f0018000 {
 				status = "okay";
 
-				24c256@50 {
+				eeprom@50 {
 					compatible = "atmel,24c256";
 					reg = <0x50>;
 					pagesize = <64>;
Signature · 1 line
2.34.1
#8 lore raw

PATCH 4/7 ARM: dts: microchip: at91-sama5d27_som1: Align the eeprom nodename

In reply to Andrei Simion

Align the eeprom nodename according to device tree specification and at24.yaml.

---
 arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d27_som1.dtsi +1 -1
index 95ecb7d040a8..8ac85dac5a96 100644
@@ -106,7 +106,7 @@ i2c0: i2c@f8028000 {
 				scl-gpios = <&pioA PIN_PD22 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 				status = "okay";
 
-				at24@50 {
+				eeprom@50 {
 					compatible = "atmel,24c02";
 					reg = <0x50>;
 					pagesize = <8>;
Signature · 1 line
2.34.1
#9 lore raw

PATCH 5/7 ARM: dts: microchip: at91sam9g20ek_common: Align the eeprom nodename

In reply to Andrei Simion

Align the eeprom nodename according to device tree specification and at24.yaml.

---
 arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/microchip/at91sam9g20ek_common.dtsi +1 -1
index 565b99e79c52..4e7cfbbd4241 100644
@@ -220,7 +220,7 @@ usb0: ohci@500000 {
 	i2c-gpio-0 {
 		status = "okay";
 
-		24c512@50 {
+		eeprom@50 {
 			compatible = "atmel,24c512";
 			reg = <0x50>;
 			vcc-supply = <&reg_3v3>;
Signature · 1 line
2.34.1
#10 lore raw

PATCH 6/7 ARM: dts: microchip: at91sam9260ek: Align the eeprom nodename

In reply to Andrei Simion

Align the eeprom nodename according to device tree specification and at24.yaml.

---
 arch/arm/boot/dts/microchip/at91sam9260ek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/microchip/at91sam9260ek.dts +1 -1
index 720c15472c4a..6bd60dce8378 100644
@@ -165,7 +165,7 @@ button-4 {
 	i2c-gpio-0 {
 		status = "okay";
 
-		24c512@50 {
+		eeprom@50 {
 			compatible = "atmel,24c512";
 			reg = <0x50>;
 		};
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/7 ARM: dts: microchip: at91-sama5d2_xplained: Align the eeprom nodename

In reply to Andrei Simion

Align the eeprom nodename according to device tree specification and at24.yaml.

---
 arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts +1 -1
index 6680031387e8..4bab3f25b855 100644
@@ -411,7 +411,7 @@ i2c1: i2c@fc028000 {
 				scl-gpios = <&pioA PIN_PD5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 				status = "okay";
 
-				at24@54 {
+				eeprom@54 {
 					compatible = "atmel,24c02";
 					reg = <0x54>;
 					pagesize = <16>;
Signature · 1 line
2.34.1
#11 lore raw

PATCH 7/7 ARM: dts: microchip: at91sam9263ek: Align the eeprom nodename

In reply to Andrei Simion

Align the eeprom nodename according to device tree specification and at24.yaml.

---
 arch/arm/boot/dts/microchip/at91sam9263ek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/microchip/at91sam9263ek.dts +1 -1
index ce8baff6a9f4..bad7dbecba3c 100644
@@ -253,7 +253,7 @@ button-right-click {
 	i2c-gpio-0 {
 		status = "okay";
 
-		24c512@50 {
+		eeprom@50 {
 			compatible = "atmel,24c512";
 			reg = <0x50>;
 			pagesize = <128>;
Signature · 1 line
2.34.1
#3 lore raw

Re: [PATCH 2/7] ARM: dts: microchip: at91-sama5d2_ptc_ek: Align the eeprom nodename

In reply to Andrei Simion
Quoted 13 lines · Andrei Simion

Aling the eeprom nodename according to device tree specification and at24.yaml.

---
 arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts +0 -0
index 200b20515ab1..e4ae60ef5f8a 100644

arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts i2c1: i2c@fc028000 { · line 234

Quoted 5 lines
arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts +1 -1
@@ -231,7 +231,7 @@ i2c1: i2c@fc028000 {
 				scl-gpios = <&pioA PIN_PC7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 				status = "okay";
 
-				at24@50 {
+				eeprom@50 {

Just squash these all into one commit. This is just naming, non-functional change so creating 7 patches for this is just huge churn.

Best regards,
Krzysztof

#5 lore raw

Re: [PATCH 3/7] ARM: dts: microchip: at91-sama5d34ek: Align the eeprom nodename

In reply to Andrei Simion
Quoted 4 lines · Andrei Simion

Align the eeprom nodename according to device tree specification and at24.yaml.

Squash.

Quoted 9 lines
---
 arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/microchip/sama5d34ek.dts +0 -0
index bffd61397cb5..18943b873fff 100644

arch/arm/boot/dts/microchip/sama5d34ek.dts i2c0: i2c@f0014000 { · line 39

Quoted 5 lines
arch/arm/boot/dts/microchip/sama5d34ek.dts +1 -1
@@ -36,7 +36,7 @@ i2c0: i2c@f0014000 {
 			i2c1: i2c@f0018000 {
 				status = "okay";
 
-				24c256@50 {
+				eeprom@50 {

What about other names? Why not fixing everything at once?

Best regards,
Krzysztof

#6 lore raw

Re: [PATCH 3/7] ARM: dts: microchip: at91-sama5d34ek: Align the eeprom nodename

Quoted 10 lines · Krzysztof Kozlowski

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 4 lines · Andrei Simion

Align the eeprom nodename according to device tree specification and at24.yaml.

Squash.

I will squash.

Quoted 12 lines
Quoted 12 lines
---
 arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/microchip/sama5d34ek.dts +0 -0
index bffd61397cb5..18943b873fff 100644
@@ -36,7 +36,7 @@ i2c0: i2c@f0014000 {
                      i2c1: i2c@f0018000 {
                              status = "okay";
 
Quoted 5 lines

arch/arm/boot/dts/microchip/sama5d34ek.dts i2c0: i2c@f0014000 { · line 39

Quoted 2 lines
arch/arm/boot/dts/microchip/sama5d34ek.dts +1 -1
-                             24c256@50 {
+                             eeprom@50 {

What about other names? Why not fixing everything at once?

There are 149 dts+dtsi files. I would like to fix them step by step. (lots to check)

Quoted 3 lines

Best regards,
Krzysztof

Best regards,
Andrei Simion

#7 lore raw

Re: [PATCH 3/7] ARM: dts: microchip: at91-sama5d34ek: Align the eeprom nodename

Quoted 26 lines · On 05/07/2024 11:31, [email protected] wrote:
Quoted 10 lines · Krzysztof Kozlowski

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 4 lines · Andrei Simion

Align the eeprom nodename according to device tree specification and at24.yaml.

Squash.

I will squash.

Quoted 12 lines
Quoted 12 lines
---
 arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/microchip/sama5d34ek.dts +0 -0
index bffd61397cb5..18943b873fff 100644
@@ -36,7 +36,7 @@ i2c0: i2c@f0014000 {
                      i2c1: i2c@f0018000 {
                              status = "okay";
 
Quoted 7 lines
Quoted 5 lines

arch/arm/boot/dts/microchip/sama5d34ek.dts i2c0: i2c@f0014000 { · line 39

Quoted 2 lines
arch/arm/boot/dts/microchip/sama5d34ek.dts +1 -1
-                             24c256@50 {
+                             eeprom@50 {

What about other names? Why not fixing everything at once?

There are 149 dts+dtsi files. I would like to fix them step by step. (lots to check)

I meant, if doing cosmetic changes like this to these files, why not fixing other names? Some of the work is automatic.

Best regards,
Krzysztof