kbuild: deb-pkg: use default string when variable is unset or null
PATCH 1/1 kbuild: deb-pkg: use default string when variable is unset or null
${DEBFULLNAME-${user}} falls back to ${user} when DEBFULLNAME is unset. It is more reasonable to do so when DEBFULLNAME is unset or null.
Otherwise, the command:
$ DEBFULLNAME= make deb-pkg
will leave the name field blank.
The same applies to KBUILD_BUILD_USER and KBUILD_BUILD_HOST.
Signed-off-by Masahiro Yamada <[email protected]>
---
scripts/package/mkdebian | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/package/mkdebian +3 -3
@@ -125,12 +125,12 @@ gen_source () rm -rf debian mkdir debian -user=${KBUILD_BUILD_USER-$(id -nu)} -name=${DEBFULLNAME-${user}} +user=${KBUILD_BUILD_USER:-$(id -nu)} +name=${DEBFULLNAME:-${user}} if [ "${DEBEMAIL:+set}" ]; then email=${DEBEMAIL} else - buildhost=${KBUILD_BUILD_HOST-$(hostname -f 2>/dev/null || hostname)} + buildhost=${KBUILD_BUILD_HOST:-$(hostname -f 2>/dev/null || hostname)} email="${user}@${buildhost}" fi maintainer="${name} <${email}>"
Signature · 1 line
2.43.0
Quoted 5 lines · Masahiro Yamada
${DEBFULLNAME-${user}} falls back to ${user} when DEBFULLNAME is unset. It is more reasonable to do so when DEBFULLNAME is unset or null.
Otherwise, the command:
Quoted 7 lines
$ DEBFULLNAME= make deb-pkgwill leave the name field blank.
The same applies to
KBUILD_BUILD_USERandKBUILD_BUILD_HOST.Signed-off-by Masahiro Yamada <[email protected]>
Yeah, it definitely does not really make sense to let someone do that, although I am not really sure why anyone would...
Reviewed-by Nathan Chancellor <[email protected]>
Quoted 28 lines
---
scripts/package/mkdebian | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)scripts/package/mkdebian +3
-3@@ -125,12 +125,12 @@ gen_source () rm -rf debian mkdir debian -user=${KBUILD_BUILD_USER-$(id -nu)} -name=${DEBFULLNAME-${user}} +user=${KBUILD_BUILD_USER:-$(id -nu)} +name=${DEBFULLNAME:-${user}} if [ "${DEBEMAIL:+set}" ]; then email=${DEBEMAIL} else - buildhost=${KBUILD_BUILD_HOST-$(hostname -f 2>/dev/null || hostname)} + buildhost=${KBUILD_BUILD_HOST:-$(hostname -f 2>/dev/null || hostname)} email="${user}@${buildhost}" fi maintainer="${name} <${email}>"Signature · 1 line
2.43.0