gitweb: rss/atom change published/updated date to committed date
PATCH 1/1 gitweb: rss/atom change published/updated date to committed date
Currently the published(in rss) and the updated(in atom) date used is the authored date. Change it to the committed date that betters reflect the "published/updated" definition and makes rss/atom feeds more lineal. Gitlab/Github rss/atom feeds use the commited date.
The committed date is already used to determine if more items should be fetched.
--- gitweb/gitweb.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
gitweb/gitweb.perl +1 -1
@@ -8329,7 +8329,7 @@ sub git_feed { if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) { last; } - my %cd = parse_date($co{'author_epoch'}, $co{'author_tz'}); + my %cd = parse_date($co{'committer_epoch'}, $co{'committer_tz'}); # get list of changed files open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,
Signature · 1 line
2.45.2
Quoted 8 lines · Jesús Ariel Cabello Mateos
Currently the published(in rss) and the updated(in atom) date used is the authored date. Change it to the committed date that betters reflect the "published/updated" definition and makes rss/atom feeds more lineal. Gitlab/Github rss/atom feeds use the commited date.
The committed date is already used to determine if more items should be fetched.
Even though "authored" and "committed" date may be grammatically correct if you use "to author" and "to commit" as verbs, the name we use for these two timestamps are "author date" and "committer date" (in other words, "author" and "committer" are not used as verbs but as nouns for possibly two distinct people). So
* "committed date" (on the title and elsewhere) and "commited date" -> "committer date".
* "authored date" -> "author date".
* "lineal" -> "linear"?
But your reasoning is absolutely correct about the concept of "publish" more closely corresponds to the committer date than the author date, and the change looks sensible.
Quoted 18 lines
Signed-off-by Jesús Ariel Cabello Mateos <[email protected]>--- gitweb/gitweb.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)gitweb/gitweb.perl +1
-1@@ -8329,7 +8329,7 @@ sub git_feed { if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) { last; } - my %cd = parse_date($co{'author_epoch'}, $co{'author_tz'}); + my %cd = parse_date($co{'committer_epoch'}, $co{'committer_tz'}); # get list of changed files open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,
PATCH v2 1/1 gitweb: rss/atom change published/updated date to committer date
In reply to Jesús Ariel Cabello MateosCurrently the value used is the author date. Change it to the committer date that betters reflect the "published/updated" definition and makes rss/atom feeds more linear. Gitlab/Github rss/atom feeds use the committer date.
The committer date is already used to determine if more items should be fetched.
---
Changes since v1:
- Typo fix in the commit message.
- Semantic fixes in the commit message.
Thank you, Junio!
gitweb/gitweb.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
gitweb/gitweb.perl +0 -1
@@ -8329,7 +8329,7 @@ sub git_feed { if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) { last; } - my %cd = parse_date($co{'author_epoch'}
, $co{'author_tz'});
+ my %cd = parse_date($co{'committer_epoch'},
$co{'committer_tz'});
# get list of changed files
open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,
--
2.45.2Quoted 31 lines · Jesús Ariel Cabello Mateos
Currently the published(in rss) and the updated(in atom) date used is the authored date. Change it to the committed date that betters reflect the "published/updated" definition and makes rss/atom feeds more lineal. Gitlab/Github rss/atom feeds use the commited date.
The committed date is already used to determine if more items should be fetched.
Signed-off-by Jesús Ariel Cabello Mateos <[email protected]>--- gitweb/gitweb.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)gitweb/gitweb.perl +1
-2@@ -8329,7 +8329,7 @@ sub git_feed { if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) { last; } - my %cd = parse_date($co{'author_epoch'}, $co{'author_tz'}); + my %cd = parse_date($co{'committer_epoch'}, $co{'committer_tz'}); # get list of changed files open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts, --2.45.2
Re: [PATCH v2] gitweb: rss/atom change published/updated date to committer date
Quoted 5 lines · Ariel Cabello Mateos
Currently the value used is the author date. Change it to the committer date that betters reflect the "published/updated" definition and makes rss/atom feeds more linear. Gitlab/Github rss/atom feeds use the committer date.
Quoted 7 lines
The committer date is already used to determine if more items should be fetched.
Signed-off-by Jesús Ariel Cabello Mateos <[email protected]>---
Changes since v1:
- Typo fix in the commit message.
- Semantic fixes in the commit message.
error: corrupt patch at line 20
Quoted 15 lines
gitweb/gitweb.perl +1
-1@@ -8329,7 +8329,7 @@ sub git_feed { if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) { last; } - my %cd = parse_date($co{'author_epoch'} , $co{'author_tz'}); + my %cd = parse_date($co{'committer_epoch'}, $co{'committer_tz'});# get list of changed files open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,
Re: [PATCH v2] gitweb: rss/atom change published/updated date to committer date
Quoted 3 lines · Junio C Hamano
Quoted 1 line · Ariel Cabello Mateos
Currently the value used is the author date. Change it to the
It is left unsaid what "the value" is used for. Let's rewrite the first sentence like so:
The author date is used for published/updated date in the rss/atom feed stream. Change it to ...
Another thing that is curious is why the mention of author_epoch is left as is before the hunk.
Shouldn't we use the same committer time for loop cut-off and also for display?
gitweb/gitweb.perl +2 -2
@@ -8324,10 +8324,10 @@ sub git_feed { my %co = %{$commitlist[$i]}; my $commit = $co{'id'}; # we read 150, we always show 30 and the ones more recent than 48 hours - if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) { + if (($i >= 20) && ((time - $co{'committer_epoch'}) > 48*60*60)) { last; } - my %cd = parse_date($co{'author_epoch'}, $co{'author_tz'}); + my %cd = parse_date($co{'committer_epoch'}, $co{'committer_tz'}); # get list of changed files open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,
Signature · 1 line
2.45.2-899-gfb4fe62777
PATCH v3 1/1 gitweb: rss/atom change published/updated date to committer date
In reply to Jesús Ariel Cabello MateosThe author date is used for published/updated date in the rss/atom feed stream. Change it to the committer date that betters reflect the "published/updated" definition and makes rss/atom feeds more linear. Gitlab/Github rss/atom feeds use the committer date.
Additionally, to be consistent, also use the committer date to determine the date of the last commit to send in the feed instead of the author date.
---
Changes since v2:
- Fix line wrapping in patch
- Also use authored date for processing loop.
- Rewrite commit message for clarity.
Thank you, Junio!
gitweb/gitweb.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
gitweb/gitweb.perl +2 -2
@@ -8326,10 +8326,10 @@ sub git_feed { my %co = %{$commitlist[$i]}; my $commit = $co{'id'}; # we read 150, we always show 30 and the ones more recent than 48 hours - if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) { + if (($i >= 20) && ((time - $co{'committer_epoch'}) > 48*60*60)) { last; } - my %cd = parse_date($co{'author_epoch'}, $co{'author_tz'}); + my %cd = parse_date($co{'committer_epoch'}, $co{'committer_tz'}); # get list of changed files open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,
Signature · 1 line
2.45.2
Re: [PATCH v3] gitweb: rss/atom change published/updated date to committer date
Quoted 7 lines · Jesús Ariel Cabello Mateos
...
Additionally, to be consistent, also use the committer date to determine the date of the last commit to send in the feed instead of the author date.Signed-off-by Jesús Ariel Cabello Mateos <[email protected]>---
Nicely done. Will queue. Let me mark the topic for 'next'.
Thanks.