Small API fix for bpf_wq
Subsystems (3)
cover Small API fix for bpf_wq
I realized this while having a map containing both a struct bpf_timer and a struct bpf_wq: the third argument provided to the bpf_wq callback is not the struct bpf_wq pointer itself, but the pointer to the value in the map.
Which means that the users need to double cast the provided "value" as this is not a struct bpf_wq *.
This is a change of API, but there doesn't seem to be much users of bpf_wq right now, so we should be able to go with this right now.
---
Benjamin Tissoires (2):
bpf: helpers: fix bpf_wq_set_callback_impl signature selftests/bpf: amend for wrong bpf_wq_set_callback_impl signature
kernel/bpf/helpers.c | 2 +- tools/testing/selftests/bpf/bpf_experimental.h | 2 +- tools/testing/selftests/bpf/progs/wq.c | 8 ++++---- tools/testing/selftests/bpf/progs/wq_failures.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-)
---
base-commit: fd8db07705c55a995c42b1e71afc42faad675b0b
change-id: 20240705-fix-wq-f069c7fb36c3
Best regards,
Signature · 1 line
Benjamin Tissoires <[email protected]>
PATCH 1/2 bpf: helpers: fix bpf_wq_set_callback_impl signature
I realized this while having a map containing both a struct bpf_timer and a struct bpf_wq: the third argument provided to the bpf_wq callback is not the struct bpf_wq pointer itself, but the pointer to the value in the map.
Which means that the users need to double cast the provided "value" as this is not a struct bpf_wq *.
This is a change of API, but there doesn't seem to be much users of bpf_wq right now, so we should be able to go with this right now.
--- kernel/bpf/helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/bpf/helpers.c +1 -1
@@ -2734,7 +2734,7 @@ __bpf_kfunc int bpf_wq_start(struct bpf_wq *wq, unsigned int flags) } __bpf_kfunc int bpf_wq_set_callback_impl(struct bpf_wq *wq, -int (callback_fn )(void *map,int *key,struct bpf_wq *wq), +int (callback_fn )(void *map,int *key,void *value),unsigned int flags,void *aux__ign) {
Signature · 1 line
2.44.0
Re: [PATCH bpf-next 1/2] bpf: helpers: fix bpf_wq_set_callback_impl signature
Quoted 8 lines · Benjamin Tissoires
I realized this while having a map containing both a struct
bpf_timerand a structbpf_wq: the third argument provided to thebpf_wqcallback is not the structbpf_wqpointer itself, but the pointer to the value in the map.Which means that the users need to double cast the provided "value" as this is not a struct
bpf_wq*.
Quoted 6 lines
This is a change of API, but there doesn't seem to be much users of
bpf_wqright now, so we should be able to go with this right now.Fixes 81f1d7a583fa ("bpf: wq: add bpf_wq_set_callback_impl")Signed-off-by Benjamin Tissoires <[email protected]>---
PATCH 2/2 selftests/bpf: amend for wrong bpf_wq_set_callback_impl signature
In reply to Benjamin TissoiresSee the previous patch: the API was wrong, we were provided the pointer to the value, not the actual struct bpf_wq *.
--- tools/testing/selftests/bpf/bpf_experimental.h | 2 +- tools/testing/selftests/bpf/progs/wq.c | 8 ++++---- tools/testing/selftests/bpf/progs/wq_failures.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-)
tools/testing/selftests/bpf/bpf_experimental.h +1 -1
@@ -552,7 +552,7 @@ extern void bpf_iter_css_destroy(struct bpf_iter_css *it) __weak __ksym; extern int bpf_wq_init(struct bpf_wq *wq, void *p__map, unsigned int flags) __weak __ksym; extern int bpf_wq_start(struct bpf_wq *wq, unsigned int flags) __weak __ksym; extern int bpf_wq_set_callback_impl(struct bpf_wq *wq, - int (callback_fn)(void *map, int *key, struct bpf_wq *wq), + int (callback_fn)(void *map, int *key, void *value), unsigned int flags__k, void *aux__ign) __ksym;#define bpf_wq_set_callback (timer, cb, flags) \ bpf_wq_set_callback_impl(timer, cb, flags, NULL)
tools/testing/selftests/bpf/progs/wq.c +4 -4
@@ -53,7 +53,7 @@ __u32 ok;__u32 ok_sleepable;static int test_elem_callback (void *map,int *key, -int (callback_fn )(void *map,int *key,struct bpf_wq *wq)) +int (callback_fn )(void *map,int *key,void *value)) {struct elem init = {}, *val;struct bpf_wq *wq;
@@ -84,7 +84,7 @@ static int test_elem_callback(void *map, int *key, }static int test_hmap_elem_callback (void *map,int *key, -int (callback_fn )(void *map,int *key,struct bpf_wq *wq)) +int (callback_fn )(void *map,int *key,void *value)) {struct hmap_elem init = {}, *val;struct bpf_wq *wq;
@@ -114,7 +114,7 @@ static int test_hmap_elem_callback(void *map, int *key, }/* callback for non sleepable workqueue */ -static int wq_callback (void *map,int *key,struct bpf_wq *work) +static int wq_callback (void *map,int *key,void *value) {bpf_kfunc_common_test (); ok |= (1 << *key);
@@ -122,7 +122,7 @@ static int wq_callback(void *map, int *key, struct bpf_wq *work) }/* callback for sleepable workqueue */ -static int wq_cb_sleepable (void *map,int *key,struct bpf_wq *work) +static int wq_cb_sleepable (void *map,int *key,void *value) {bpf_kfunc_call_test_sleepable (); ok_sleepable |= (1 << *key);
tools/testing/selftests/bpf/progs/wq_failures.c +2 -2
@@ -28,14 +28,14 @@ struct { } lru SEC(".maps");/* callback for non sleepable workqueue */ -static int wq_callback (void *map,int *key,struct bpf_wq *work) +static int wq_callback (void *map,int *key,void *value) {bpf_kfunc_common_test ();return 0 ; }/* callback for sleepable workqueue */ -static int wq_cb_sleepable (void *map,int *key,struct bpf_wq *work) +static int wq_cb_sleepable (void *map,int *key,void *value) {bpf_kfunc_call_test_sleepable ();return 0 ;
Signature · 1 line
2.44.0
Eduard Zingerman
maintainerRe: [PATCH bpf-next 2/2] selftests/bpf: amend for wrong bpf_wq_set_callback_impl signature
Quoted 5 lines · Benjamin Tissoires
See the previous patch: the API was wrong, we were provided the pointer to the value, not the actual struct
bpf_wq*.Signed-off-by Benjamin Tissoires <[email protected]>---
Would it make sense to update one of the tests, so that it checks the specific value put in the map?
E.g. extend struct elem:
struct elem {
int answer_to_the_ultimate_question;
struct bpf_wq w;
};And put something in there?
[...]
Re: [PATCH bpf-next 2/2] selftests/bpf: amend for wrong bpf_wq_set_callback_impl signature
Quoted 12 lines · Eduard Zingerman
Quoted 5 lines · Benjamin Tissoires
See the previous patch: the API was wrong, we were provided the pointer to the value, not the actual struct
bpf_wq*.Signed-off-by Benjamin Tissoires <[email protected]>---
Would it make sense to update one of the tests, so that it checks the specific value put in the map?
E.g. extend struct elem:
Quoted 6 lines
struct elem { int answer_to_the_ultimate_question; struct bpf_wq w; };And put something in there?
+1
let's tweak the selftest.
pw-bot: cr
Re: [PATCH bpf-next 2/2] selftests/bpf: amend for wrong bpf_wq_set_callback_impl signature
Quoted 18 lines · Alexei Starovoitov
Quoted 17 lines · Eduard Zingerman
Quoted 5 lines · Benjamin Tissoires
See the previous patch: the API was wrong, we were provided the pointer to the value, not the actual struct
bpf_wq*.Signed-off-by Benjamin Tissoires <[email protected]>---
Would it make sense to update one of the tests, so that it checks the specific value put in the map?
E.g. extend struct elem:struct elem { int answer_to_the_ultimate_question; struct bpf_wq w; };
Quoted 4 lines
Quoted 1 line
And put something in there?
+1
let's tweak the selftest.
OK, v2 it is then :)
Cheers,
Benjamin