Skip to contentSkip to conversation

bindings: rust: tests: set direction when reconfiguring lines

PATCH Applied Bartosz Golaszewski 1 participant 2 messages Jul 8, 2024 GPIO

lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

PATCH 1/1 bindings: rust: tests: set direction when reconfiguring lines

From: Bartosz Golaszewski <[email protected]>

Linux kernel commit b44039638741 ("gpiolib: cdev: Ignore reconfiguration without direction") made the direction setting mandatory for line config passed to the kernel when reconfiguring requested lines. Fix the Rust test cases which don't do it and now fail due to the rest of the settings being ignored.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 bindings/rust/libgpiod/tests/line_request.rs | 3 +++
 1 file changed, 3 insertions(+)
bindings/rust/libgpiod/tests/line_request.rs +3 -0
index 4e095a4..4ba0d18 100644
@@ -138,6 +138,7 @@ mod line_request {
             // Value read properly after reconfigure
             let mut lsettings = line::Settings::new().unwrap();
             lsettings.set_active_low(true);
+            lsettings.set_direction(Direction::Input).unwrap();
             let mut lconfig = line::Config::new().unwrap();
             lconfig.add_line_settings(&offsets, lsettings).unwrap();
             request.reconfigure_lines(&lconfig).unwrap();

@@ -452,6 +453,7 @@ mod line_request {
             let mut lconfig = line::Config::new().unwrap();
             let mut lsettings = line::Settings::new().unwrap();
             lsettings.set_event_clock(EventClock::Monotonic).unwrap();
+            lsettings.set_direction(Direction::Input).unwrap();
             lconfig.add_line_settings(&[0], lsettings).unwrap();
             config.request().reconfigure_lines(&lconfig).unwrap();
             let info = config.chip().line_info(0).unwrap();

@@ -460,6 +462,7 @@ mod line_request {
             let mut lconfig = line::Config::new().unwrap();
             let mut lsettings = line::Settings::new().unwrap();
             lsettings.set_event_clock(EventClock::Realtime).unwrap();
+            lsettings.set_direction(Direction::Input).unwrap();
             lconfig.add_line_settings(&[0], lsettings).unwrap();
             config.request().reconfigure_lines(&lconfig).unwrap();
             let info = config.chip().line_info(0).unwrap();
Signature · 1 line
2.43.0
author Applied
#1 lore raw

From: Bartosz Golaszewski <[email protected]>

Quoted 8 lines · Bartosz Golaszewski

Linux kernel commit b44039638741 ("gpiolib: cdev: Ignore reconfiguration without direction") made the direction setting mandatory for line config passed to the kernel when reconfiguring requested lines. Fix the Rust test cases which don't do it and now fail due to the rest of the settings being ignored.

[...]

Applied, thanks!

[1/1] bindings: rust: tests: set direction when reconfiguring lines

      commit: 2515fae57d88e0f4e916e66e358912b9f98914dd

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>