erofs-utils: fix bitops fls_long
PATCH 1/1 erofs-utils: fix bitops fls_long
The __builtin_clz is for unsigned int, while it is applied to unsigned long. This fixes it by using __builtin_clzl.
Signed-off-by Hongzhen Luo <[email protected]>
--- include/erofs/defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/erofs/defs.h +1 -1
@@ -288,7 +288,7 @@ static inline u32 get_unaligned_le64(const void *p)static inline unsigned int fls_long (unsigned long x) { -return x ?sizeof (x) *8 -__builtin_clz (x) :0 ; +return x ?sizeof (x) *8 -__builtin_clzl (x) :0 ; }static inline unsigned long lowbit (unsigned long n)
Signature · 1 line
2.43.5
Quoted 3 lines · Hongzhen Luo
The
__builtin_clzis for unsigned int, while it is applied to unsigned long. This fixes it by using__builtin_clzl.
Does it impact any exist use cases? If yes, we might need to add some words in the commit message.
Quoted 1 line
Signed-off-by Hongzhen Luo <[email protected]>
Reviewed-by Gao Xiang <[email protected]>
Thanks,
Gao Xiang