powerpc-km82xx.c: replace of_node_put with __free improves cleanup
PATCH 1/1 powerpc-km82xx.c: replace of_node_put with __free improves cleanup
The use of the __free function allows the cleanup to be based on scope instead of on another function called later. This makes the cleanup automatic and less susceptible to errors later.
This code was compiled without errors or warnings.
Signed-off-by David Hunter <[email protected]>
--- arch/powerpc/platforms/82xx/km82xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/powerpc/platforms/82xx/km82xx.c +3 -3
@@ -27,15 +27,15 @@static void __init km82xx_pic_init (void ) { -struct device_node *np =of_find_compatible_node (NULL ,NULL , -"fsl,pq2-pic" ); + struct device_node *np __free(device_node) = of_find_compatible_node(NULL, +NULL , +"fsl,pq2-pic" );if (!np) {pr_err ("PIC init: can not find cpm-pic node\n" );return ; }cpm2_pic_init (np); -of_node_put (np); }struct cpm_pin {
Signature · 1 line
2.34.1
Michael Ellerman
AppliedQuoted 8 lines · David Hunter
The use of the
__freefunction allows the cleanup to be based on scope instead of on another function called later. This makes the cleanup automatic and less susceptible to errors later.This code was compiled without errors or warnings.
[...]
Applied to powerpc/next.
[1/1] powerpc-km82xx.c: replace of_node_put with __free improves cleanup
https://git.kernel.org/powerpc/c/4aa5cc1e0012f784bc7f637458e597564833b425
cheers